[Bug] 艳丽围巾不能让次要资源免费

[iouter]

模块范围

Public API（公开 API）

严重程度

Minor（轻微）

发生了什么？

艳丽围巾不能让次要资源免费

复现步骤

有艳丽围巾，满足免费条件，打出一张带次要资源的卡

期望行为

艳丽围巾能让次要资源免费。
我看它的代码，是单独写的免费能量和星星。所以由ritsulib统一免费所有次要资源比较好。

日志 / 堆栈

RitsuLib 版本

0.4.62

运行环境

No response

[ritsukage-local-analyzer]

Warning

此分析由 AI 自动生成，仅供开发者参考，最终判断请以人工确认为准。如有疑问建议结合本地环境进一步复现确认。

摘要

艳丽围巾（Brilliant Scarf）在原版实现里只把能量与星星费用改为 0，RitsuLib 的次要资源支付路径目前不会自动把这种“免费出牌”语义扩展到已注册的次要资源。影响范围主要是带固定次要资源费用的 mod 卡在满足艳丽围巾第 5 张手牌条件时仍需支付或被判定不可支付，严重度与现有 severity/minor 基本匹配。

建议维护者把“原版/模型层免费出牌”桥接到 SecondaryResourcePaymentFreeMode，并补一个覆盖 Brilliant Scarf + 固定次要资源费用的回归测试；如果涉及 X 型次要资源，还需明确是否跟随原版 X 牌免费语义。

重点结论

项目	结论
简单介绍	满足艳丽围巾条件时，带次要资源费用的卡没有像能量/星星一样被视为免费。
可能原因	较高置信：原版 BrilliantScarf 只覆盖 TryModifyEnergyCostInCombatLate 与 TryModifyStarCost；RitsuLib 的次要资源规划只从自身 free-play binding 推导 FixedSecondaryCostsFree，未把这种原版模型费用修改统一映射到次要资源。
可能解决方案	在 RitsuLib 的 free-play/secondary-resource 桥接层识别“本次出牌被模型效果免费化”，让固定次要资源成本走 isFree 分支；同时新增 Brilliant Scarf 场景测试，确认可打出、显示为 0、结算不扣次要资源。
需要补充	需要一个具体测试卡/次要资源 ID 或最小 mod 示例；运行环境字段为空，若只在特定游戏版本/分支复现也需补充。

展开详细分析、证据与验证

问题描述

期望行为

满足艳丽围巾“每回合从手牌打出的第 5 张牌免费”条件时，该次出牌的次要资源费用也应免费。

实际行为

报告称带次要资源费用的卡仍不能被艳丽围巾免费化；这通常会表现为仍显示/要求支付次要资源，或在次要资源不足时无法打出。

复现步骤

1. 玩家拥有艳丽围巾。
2. 本回合已从手牌打出 4 张牌，使下一张从手牌打出的牌满足艳丽围巾条件。
3. 打出一张带 RitsuLib 次要资源费用的卡。
4. 观察该次要资源费用是否被置为 0、是否扣除资源、资源不足时是否仍可打出。

环境与版本

• RitsuLib 版本：0.4.62
• 模块范围：Public API（公开 API）
• 运行环境：未提供

日志、附件与原文摘录

• 原文：艳丽围巾不能让次要资源免费
  要点：问题集中在原版遗物的“免费出牌”语义没有覆盖 RitsuLib 次要资源。
• 原文：它的代码，是单独写的免费能量和星星。所以由ritsulib统一免费所有次要资源比较好。
  要点：报告者已指出可疑设计点：原版只处理能量/星星，RitsuLib 需要提供统一桥接。
• 日志区为空；没有截图、存档或最小示例卡。

详细分析依据

• 原版 recovered source 中，BrilliantScarf 的免费逻辑分别实现为：
  • official-source/src/Core/Models/Relics/BrilliantScarf.cs:57 的 TryModifyEnergyCostInCombatLate 将满足条件的能量费用改为 0；
  • official-source/src/Core/Models/Relics/BrilliantScarf.cs:68 的 TryModifyStarCost 将满足条件的星星费用改为 0；
  • official-source/src/Core/Models/Relics/BrilliantScarf.cs:113 的 ShouldModifyCost 限定战斗中、同一拥有者、第 5 张、且卡在手牌/打出区。
• RitsuLib 的次要资源出牌检查与支付位于 src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:41 与 src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:73，会先调用 FreePlayBindingRegistry.ResolveCardCostScopeForUpcomingPlay，再传给 SecondaryResourcePaymentResolver.Plan。
• FreePlayBindingRegistry.ResolveCardCostScopeForUpcomingPlay 在 src/Cards/FreePlay/FreePlayBindingRegistry.cs:220 主要读取 RitsuLib 自己记录的 card binding 状态；虽然同文件 src/Cards/FreePlay/FreePlayBindingRegistry.cs:353 有通过模型同时把能量和星星改到 0 来识别 free play 的逻辑，但该逻辑针对已有 CardPlay 的 Resolve(CardPlay)，并未直接用于 upcoming-play 的次要资源付费规划。
• 次要资源实际免费分支在 src/Combat/SecondaryResources/SecondaryResourceCosts.cs:675 到 src/Combat/SecondaryResources/SecondaryResourceCosts.cs:683：FixedSecondaryCostsFree/XSecondaryCostsFree 决定某条次要资源费用是否 IsFree。如果艳丽围巾没有被映射到这些标志，固定次要资源仍会按正常费用走 ModifyCost、可支付性检查与扣费流程。
• 因此，当前静态证据支持报告者判断：这更像是 RitsuLib 与原版模型费用修改之间缺少统一 free-play 语义桥接，而不是单张 mod 卡费用配置错误。尚未进行本地运行复现，结论仍需用最小卡例验证。

反馈规范性提醒

维度	状态
复现步骤	含糊：给出了顺序，但缺少具体卡、次要资源类型、资源余额。
期望/实际	已提供：期望和实际都明确指向艳丽围巾与次要资源免费。
环境与版本	含糊：RitsuLib 版本已提供，运行环境为空；未说明游戏公开/测试分支版本。
日志/附件	缺失：日志块为空，未附截图或最小示例。
标题与背景	已提供：标题能准确概括问题，正文补充了代码层可疑点。

详细验证建议

• 构造一张固定能量 + 固定次要资源费用的测试卡，确认无艳丽围巾时正常支付两类费用。
• 在拥有艳丽围巾且本回合第 5 张从手牌打出该卡时，确认 CardModel.CanPlay 不因次要资源不足失败。
• 确认 SecondaryResourcePaymentResolver.Plan 生成的固定次要资源 payment line 为 IsFree=true、AmountToSpend=0。
• 确认实际结算后次要资源余额不减少，并且 card play ledger 能向后续 hook 暴露“免费支付”的结果。
• 若项目支持次要资源 X 费用，单独验证艳丽围巾是否应让 X 次要资源保留 X 值但不扣资源，避免与固定费用语义混在一起。

风险与未决

• 如果仅把“能量和星星同时为 0”当作免费信号，可能漏掉无星星费用或单资源卡；需要确认应按原版免费出牌语义、模型类型、还是 cost-modifier 结果来判断。
• X 型次要资源的语义可能不同于固定次要资源：原版补丁说明全局免费效果会影响 X 牌，但需要决定 RitsuLib 的 XSecondaryCostsFree 是否同步启用。
• 报告缺少最小示例卡；若某些次要资源是 optional/extra spend，修复期望可能不同于 required cost。

---

English translation

Summary

Brilliant Scarf appears to make only energy and star costs zero in the vanilla implementation, while RitsuLib's secondary-resource payment path currently does not automatically extend that "free play" meaning to registered secondary resources. The impact is mainly that mod cards with fixed secondary-resource costs may still require payment, or be considered unaffordable, when they are the 5th card from hand under Brilliant Scarf; the existing severity/minor label looks reasonable.

Maintainers should bridge vanilla/model-level free-play effects into SecondaryResourcePaymentFreeMode, then add a regression test for Brilliant Scarf plus a fixed secondary-resource cost. If X-style secondary resources are involved, the intended behavior should be specified separately from fixed costs.

Key Takeaways

Item	Conclusion
Brief description	When Brilliant Scarf's condition is met, cards with secondary-resource costs are not treated as free in the same way as energy/star costs.
Likely cause	High confidence: vanilla BrilliantScarf only overrides TryModifyEnergyCostInCombatLate and TryModifyStarCost; RitsuLib's secondary-resource planner derives FixedSecondaryCostsFree from its own free-play bindings and does not uniformly map this vanilla model cost modifier to secondary resources.
Possible fix	In RitsuLib's free-play/secondary-resource bridge, detect that the current play is made free by a model effect and route fixed secondary-resource costs through the isFree branch; add a Brilliant Scarf scenario test that verifies playability, displayed 0 cost, and no secondary-resource spending.
Needs more information	A concrete test card/secondary-resource ID or minimal mod sample is needed; the runtime environment is empty, so any game-version or channel-specific reproduction details should also be added.

Expand detailed analysis, evidence, and verification

Problem Description

Expected behavior

When Brilliant Scarf's "the 5th card played from hand each turn is free" condition is met, secondary-resource costs for that play should also be free.

Actual behavior

The report says cards with secondary-resource costs are not made free by Brilliant Scarf. In practice this would usually mean the secondary resource is still displayed/required, or the card cannot be played when the secondary resource is insufficient.

Reproduction steps

1. The player has Brilliant Scarf.
2. The player has already played 4 cards from hand this turn, so the next card from hand satisfies Brilliant Scarf's condition.
3. Play a card that has a RitsuLib secondary-resource cost.
4. Check whether the secondary-resource cost becomes 0, whether the resource is spent, and whether the card remains playable when the resource is insufficient.

Environment and Version

• RitsuLib version: 0.4.62
• Module scope: Public API
• Runtime environment: not provided

Logs, Attachments, and Original Excerpts

• Original: 艳丽围巾不能让次要资源免费
  Key point: the issue is specifically that the vanilla relic's free-play behavior does not cover RitsuLib secondary resources.
• Original: 它的代码，是单独写的免费能量和星星。所以由ritsulib统一免费所有次要资源比较好。
  Key point: the reporter already points to the likely design gap: vanilla handles energy/star separately, so RitsuLib needs a unified bridge.
• The log block is empty; no screenshots, saves, or minimal sample card were attached.

Detailed Analysis Basis

• In the recovered vanilla source, Brilliant Scarf's free-cost logic is implemented separately as:
  • official-source/src/Core/Models/Relics/BrilliantScarf.cs:57, where TryModifyEnergyCostInCombatLate sets matching energy costs to 0;
  • official-source/src/Core/Models/Relics/BrilliantScarf.cs:68, where TryModifyStarCost sets matching star costs to 0;
  • official-source/src/Core/Models/Relics/BrilliantScarf.cs:113, where ShouldModifyCost restricts the effect to combat, same owner, the 5th card, and cards in hand/play piles.
• RitsuLib's secondary-resource playability and payment hooks are in src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:41 and src/Combat/SecondaryResources/Patches/SecondaryResourceCardPatches.cs:73; they first call FreePlayBindingRegistry.ResolveCardCostScopeForUpcomingPlay, then pass the result into SecondaryResourcePaymentResolver.Plan.
• FreePlayBindingRegistry.ResolveCardCostScopeForUpcomingPlay at src/Cards/FreePlay/FreePlayBindingRegistry.cs:220 mainly reads RitsuLib's own card binding state. The same file has logic at src/Cards/FreePlay/FreePlayBindingRegistry.cs:353 that can infer free play from a model that makes both energy and star costs 0, but that path is for an existing CardPlay via Resolve(CardPlay) and is not directly used by upcoming-play secondary-resource payment planning.
• The secondary-resource free branch is controlled by FixedSecondaryCostsFree/XSecondaryCostsFree in src/Combat/SecondaryResources/SecondaryResourceCosts.cs:675 through src/Combat/SecondaryResources/SecondaryResourceCosts.cs:683. If Brilliant Scarf is not mapped into those flags, fixed secondary-resource costs still go through normal ModifyCost, affordability checks, and spending.
• The static evidence therefore supports the reporter's assessment: this looks like a missing bridge between RitsuLib and vanilla model-level cost-free semantics, not simply a per-card cost configuration bug. A local runtime reproduction has not been performed, so the conclusion should still be validated with a minimal card case.

Feedback Hygiene Reminder

Dimension	Status
Reproduction steps	Ambiguous: an order is provided, but the exact card, secondary-resource type, and resource balance are missing.
Expected/actual	Provided: both point clearly to Brilliant Scarf and secondary-resource free play.
Environment and version	Ambiguous: the RitsuLib version is provided, but runtime environment is empty and the game public/beta version is not stated.
Logs/attachments	Missing: the log block is empty and no screenshot or minimal sample is attached.
Title and background	Provided: the title accurately summarizes the issue, and the body adds a code-level suspicion.

Detailed Verification Suggestions

• Create a test card with a fixed energy cost plus a fixed secondary-resource cost, and confirm both costs are normally paid without Brilliant Scarf.
• With Brilliant Scarf owned and the card being the 5th card played from hand this turn, confirm CardModel.CanPlay does not fail because of insufficient secondary resources.
• Confirm SecondaryResourcePaymentResolver.Plan produces a fixed secondary-resource payment line with IsFree=true and AmountToSpend=0.
• Confirm actual resolution does not reduce the secondary-resource balance, and the card play ledger exposes the free-payment result to downstream hooks.
• If secondary-resource X costs are supported, separately verify whether Brilliant Scarf should preserve the X value while avoiding resource spending, instead of mixing that behavior with fixed-cost semantics.

Risks and Open Questions

• If the implementation treats "both energy and stars are 0" as the free signal, it may miss cards without a star cost or single-resource cards; maintainers should decide whether detection should follow vanilla free-play semantics, specific model types, or cost-modifier outcomes.
• X-style secondary-resource semantics may differ from fixed secondary-resource costs: vanilla patch notes indicate global free effects affect X cards, but RitsuLib still needs an explicit decision on whether to enable XSecondaryCostsFree in the same situations.
• The report lacks a minimal sample card; if the affected secondary-resource use is optional or extra spend, the desired fix may differ from required-cost behavior.

---

工具侧记录

• BAKAOLC/STS2-RitsuLib#90 · 退出码 0 · 进程 140.23s
• gpt-5.5(high) · API 138584ms · 16 轮 · ↓86548 ↑5870 · 缓存读288256 写0 · $0.7236
• MCP available: management tools exposed to Claude.