From b265cf2c4666ab90031f151f2f7932b045be9837 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 10:31:51 -0400 Subject: [PATCH 01/15] Updated actions to versions that use Node 24 * Node 20 is being deprecated on GitHub Actions runners Signed-off-by: Jared Duffey --- .github/workflows/asan.yml | 6 +++--- .github/workflows/format_pr.yml | 4 ++-- .github/workflows/format_push.yml | 4 ++-- .github/workflows/linux.yml | 6 +++--- .github/workflows/macos.yml | 6 +++--- .github/workflows/windows.yml | 4 ++-- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml index 9064734e9f..9d3fd8bca1 100644 --- a/.github/workflows/asan.yml +++ b/.github/workflows/asan.yml @@ -13,11 +13,11 @@ jobs: runs-on: ubuntu-24.04 steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: submodules: true - name: Set up Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: '3.10' - name: Install Python dependencies @@ -25,7 +25,7 @@ jobs: python -m pip install --upgrade pip pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher - uses: ammaraskar/gcc-problem-matcher@0.2.0 + uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install Dependencies run: | sudo apt-get -y install ninja-build diff --git a/.github/workflows/format_pr.yml b/.github/workflows/format_pr.yml index b59992a007..ece06d2851 100644 --- a/.github/workflows/format_pr.yml +++ b/.github/workflows/format_pr.yml @@ -11,11 +11,11 @@ jobs: runs-on: ubuntu-24.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v7 with: fetch-depth: 2 - name: Add Problem Matcher - uses: ammaraskar/gcc-problem-matcher@a141586609e2a558729b99a8c574c048f7f56204 + uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install clang-format-19 run: | sudo apt-get update diff --git a/.github/workflows/format_push.yml b/.github/workflows/format_push.yml index 53502dc923..015a8a9488 100644 --- a/.github/workflows/format_push.yml +++ b/.github/workflows/format_push.yml @@ -11,9 +11,9 @@ jobs: runs-on: ubuntu-24.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v7 - name: Add Problem Matcher - uses: ammaraskar/gcc-problem-matcher@a141586609e2a558729b99a8c574c048f7f56204 + uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install clang-format-19 run: | sudo apt-get update diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 23eabca9b4..242e1b6d12 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -30,11 +30,11 @@ jobs: runs-on: ${{matrix.os}} steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: submodules: true - name: Set up Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: '3.10' - name: Install Python dependencies @@ -42,7 +42,7 @@ jobs: python -m pip install --upgrade pip pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher - uses: ammaraskar/gcc-problem-matcher@0.2.0 + uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install Dependencies - 2 run: | sudo apt-get -y install ninja-build diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index d8db316e0d..70a27e5662 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -28,7 +28,7 @@ jobs: runs-on: ${{matrix.os}} steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: submodules: true - name: Checkout vcpkg @@ -39,7 +39,7 @@ jobs: echo "VCPKG_INSTALLATION_ROOT=$VCPKG_INSTALLATION_ROOT" >> "$GITHUB_ENV" if: matrix.os == 'macos-14' - name: Set up Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: '3.10' - name: Install Python dependencies @@ -47,7 +47,7 @@ jobs: python -m pip install --upgrade pip pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher - uses: ammaraskar/gcc-problem-matcher@0.2.0 + uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install Dependencies run: | brew install ninja mono diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index d27e98c1c4..2b9e2b19e2 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -24,11 +24,11 @@ jobs: runs-on: ${{matrix.os}} steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: submodules: true - name: Add C++ Problem Matcher - uses: ammaraskar/msvc-problem-matcher@0.2.0 + uses: ammaraskar/msvc-problem-matcher@541aa4360062d76d9620af6b8bd35cfa0c5ef19f - name: Setup Build Environment uses: ilammy/msvc-dev-cmd@v1.12.1 with: From 1f870863bf966fcaa002aa3d09114c6a2deaed1a Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 10:37:06 -0400 Subject: [PATCH 02/15] Removed ilammy/msvc-dev-cmd * No longer required as the windows-2022 only has one visual studio version available * The action has not been updated in several years and did not have a Node 24 version Signed-off-by: Jared Duffey --- .github/workflows/windows.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 2b9e2b19e2..b9bb1b203f 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -29,10 +29,6 @@ jobs: submodules: true - name: Add C++ Problem Matcher uses: ammaraskar/msvc-problem-matcher@541aa4360062d76d9620af6b8bd35cfa0c5ef19f - - name: Setup Build Environment - uses: ilammy/msvc-dev-cmd@v1.12.1 - with: - vsversion: 2022 - name: Setup NuGet Credentials shell: bash run: | From f49ce7f6a8e1dfd4a6921eb3f3d08145dee6f894 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 11:04:02 -0400 Subject: [PATCH 03/15] Removed ninja install on macos since it was already installed Signed-off-by: Jared Duffey --- .github/workflows/macos.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 70a27e5662..9b7fb43126 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -50,7 +50,7 @@ jobs: uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install Dependencies run: | - brew install ninja mono + brew install mono - name: Install Sphinx run: | sudo pip3 install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy From 17624d176e5b6115adfffb5c2aca4e5f054239ec Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 11:04:39 -0400 Subject: [PATCH 04/15] Removed duplicate sphinx install command on linux and macos Signed-off-by: Jared Duffey --- .github/workflows/linux.yml | 3 --- .github/workflows/macos.yml | 3 --- 2 files changed, 6 deletions(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 242e1b6d12..8022a69e3a 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -46,9 +46,6 @@ jobs: - name: Install Dependencies - 2 run: | sudo apt-get -y install ninja-build - - name: Install Sphinx - run: | - sudo pip3 install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Setup NuGet Credentials shell: bash run: | diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 9b7fb43126..b1ca119194 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -51,9 +51,6 @@ jobs: - name: Install Dependencies run: | brew install mono - - name: Install Sphinx - run: | - sudo pip3 install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Setup NuGet Credentials shell: bash run: | From 6d57bba6777a5b1b171e1d43ac853ef953c9d914 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 11:09:30 -0400 Subject: [PATCH 05/15] Removed extraneous text in step name Signed-off-by: Jared Duffey --- .github/workflows/linux.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 8022a69e3a..f0e3ba91ff 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -43,7 +43,7 @@ jobs: pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - - name: Install Dependencies - 2 + - name: Install Dependencies run: | sudo apt-get -y install ninja-build - name: Setup NuGet Credentials From 5989c1692754256cbed265bdde7221be51a4304b Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 11:27:04 -0400 Subject: [PATCH 06/15] Removed macos-14 from CI due to deprecation Signed-off-by: Jared Duffey --- .github/workflows/macos.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index b1ca119194..33b3e26575 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -18,11 +18,8 @@ jobs: fail-fast: false matrix: os: - - macos-14 - macos-15 include: - - os: macos-14 - preset: ci-macos-arm64 - os: macos-15 preset: ci-macos-arm64 runs-on: ${{matrix.os}} @@ -31,13 +28,6 @@ jobs: uses: actions/checkout@v7 with: submodules: true - - name: Checkout vcpkg - run: | - git clone https://www.github.com/microsoft/vcpkg && cd vcpkg && ./bootstrap-vcpkg.sh - VCPKG_INSTALLATION_ROOT=${{github.workspace}}/vcpkg - echo "$VCPKG_INSTALLATION_ROOT" >> $GITHUB_PATH - echo "VCPKG_INSTALLATION_ROOT=$VCPKG_INSTALLATION_ROOT" >> "$GITHUB_ENV" - if: matrix.os == 'macos-14' - name: Set up Python uses: actions/setup-python@v7 with: From 27c44e3d8aadd06bb67fe0f98531a0e92a630dfa Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 11:31:45 -0400 Subject: [PATCH 07/15] Switched to ubuntu-24.04 for linux CI due to deprecation * Bumped gcc and clang to 12 and 16 respectively since they are the lowest versions installed by default Signed-off-by: Jared Duffey --- .github/workflows/linux.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index f0e3ba91ff..604142191d 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -18,15 +18,15 @@ jobs: fail-fast: false matrix: os: - - ubuntu-22.04 + - ubuntu-24.04 cxx: - - g++-11 - - clang++-14 + - g++-12 + - clang++-16 include: - - cxx: g++-11 - cc: gcc-11 - - cxx: clang++-14 - cc: clang-14 + - cxx: g++-12 + cc: gcc-12 + - cxx: clang++-16 + cc: clang-16 runs-on: ${{matrix.os}} steps: - name: Checkout From 3694fc557b81172b0333149c7d043a650e42c721 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 14:47:11 -0400 Subject: [PATCH 08/15] Removed ninja install on linux since it was already installed Signed-off-by: Jared Duffey --- .github/workflows/asan.yml | 3 --- .github/workflows/linux.yml | 3 --- 2 files changed, 6 deletions(-) diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml index 9d3fd8bca1..f84750140d 100644 --- a/.github/workflows/asan.yml +++ b/.github/workflows/asan.yml @@ -26,9 +26,6 @@ jobs: pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - - name: Install Dependencies - run: | - sudo apt-get -y install ninja-build - name: Install mono shell: bash run: | diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 604142191d..843e4651e0 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -43,9 +43,6 @@ jobs: pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - - name: Install Dependencies - run: | - sudo apt-get -y install ninja-build - name: Setup NuGet Credentials shell: bash run: | From 328a2e0588ca24bc05cc1dcfa56ea1362017e608 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Thu, 27 Aug 2026 15:24:47 -0400 Subject: [PATCH 09/15] Switched to default mono-complete and added for linux Signed-off-by: Jared Duffey --- .github/workflows/asan.yml | 8 ++------ .github/workflows/linux.yml | 4 ++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml index f84750140d..3ca3170120 100644 --- a/.github/workflows/asan.yml +++ b/.github/workflows/asan.yml @@ -27,13 +27,9 @@ jobs: - name: Add C++ Problem Matcher uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 - name: Install mono - shell: bash run: | - sudo apt-get -y install ca-certificates gnupg - sudo gpg --homedir /tmp --no-default-keyring --keyring /usr/share/keyrings/mono-official-archive-keyring.gpg --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF - echo "deb [signed-by=/usr/share/keyrings/mono-official-archive-keyring.gpg] https://download.mono-project.com/repo/ubuntu stable-focal main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list - sudo apt-get -y update - sudo apt-get -y install mono-complete + sudo apt-get update + sudo apt-get install mono-complete - name: Setup NuGet Credentials shell: bash run: | diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 843e4651e0..ceea23cbc9 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -43,6 +43,10 @@ jobs: pip install sphinx myst-parser sphinx-markdown-tables sphinx_rtd_theme numpy - name: Add C++ Problem Matcher uses: ammaraskar/gcc-problem-matcher@cb2e3f949c41b7818628f35f8484a9b0acf90cf9 + - name: Install mono + run: | + sudo apt-get update + sudo apt-get install mono-complete - name: Setup NuGet Credentials shell: bash run: | From f7d719753c5073f7e0034ca8c064ba7dd1ce3687 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Fri, 28 Aug 2026 13:21:33 -0400 Subject: [PATCH 10/15] Trying gcc 13 to avoid false positive -Wstringop-overread - Possibly related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107852 Signed-off-by: Jared Duffey --- .github/workflows/linux.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index ceea23cbc9..7f89b60300 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -20,11 +20,11 @@ jobs: os: - ubuntu-24.04 cxx: - - g++-12 + - g++-13 - clang++-16 include: - - cxx: g++-12 - cc: gcc-12 + - cxx: g++-13 + cc: gcc-13 - cxx: clang++-16 cc: clang-16 runs-on: ${{matrix.os}} From d76a4b0de7b4ada652b97b773d41520e954cc263 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Fri, 28 Aug 2026 13:22:21 -0400 Subject: [PATCH 11/15] Switched macos image to macos-26 Signed-off-by: Jared Duffey --- .github/workflows/macos.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 33b3e26575..14e91faf39 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -18,9 +18,9 @@ jobs: fail-fast: false matrix: os: - - macos-15 + - macos-26 include: - - os: macos-15 + - os: macos-26 preset: ci-macos-arm64 runs-on: ${{matrix.os}} steps: From b6eefbc39169c9989aca3b1aa553ad5fd098fd16 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Mon, 31 Aug 2026 11:43:46 -0400 Subject: [PATCH 12/15] Trying gcc 14 Signed-off-by: Jared Duffey --- .github/workflows/linux.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 7f89b60300..5fdb5e249f 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -20,11 +20,11 @@ jobs: os: - ubuntu-24.04 cxx: - - g++-13 + - g++-14 - clang++-16 include: - - cxx: g++-13 - cc: gcc-13 + - cxx: g++-14 + cc: gcc-14 - cxx: clang++-16 cc: clang-16 runs-on: ${{matrix.os}} From 1d93eda601a42242096dfc134c42df20036a98a7 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Tue, 1 Sep 2026 11:39:42 -0400 Subject: [PATCH 13/15] Revert "Trying gcc 14" This reverts commit b6eefbc39169c9989aca3b1aa553ad5fd098fd16. --- .github/workflows/linux.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 5fdb5e249f..7f89b60300 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -20,11 +20,11 @@ jobs: os: - ubuntu-24.04 cxx: - - g++-14 + - g++-13 - clang++-16 include: - - cxx: g++-14 - cc: gcc-14 + - cxx: g++-13 + cc: gcc-13 - cxx: clang++-16 cc: clang-16 runs-on: ${{matrix.os}} From 7c97060b556b04069f3c2775749462861c8b669d Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Tue, 1 Sep 2026 12:12:10 -0400 Subject: [PATCH 14/15] Disabled Wstringop-overflow warning for 12.4 <= gcc < 15 * False positive warning * See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94335 and https://godbolt.org/z/qTr8hPo1e Signed-off-by: Jared Duffey --- .../Filters/Algorithms/SharedFeatureFace.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/SharedFeatureFace.cpp b/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/SharedFeatureFace.cpp index 16ceaaaff1..2328e678bd 100644 --- a/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/SharedFeatureFace.cpp +++ b/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/SharedFeatureFace.cpp @@ -192,7 +192,18 @@ Result<> SharedFeatureFace::operator()() // Grain Boundary Attribute Matrix auto& faceFeatureAttrMat = m_DataStructure.getDataRefAs(m_InputValues->GrainBoundaryAttributeMatrixPath); ShapeType tDims = {static_cast(index)}; + // This line has a Wstringop-overflow warning starting in gcc 12.4 in release configuration + // This is a false positive that eventually disappears in gcc 15 + // Likely related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94335 + // Minimum reproducible example: https://godbolt.org/z/qTr8hPo1e +#if defined(__GNUC__) && !defined(__clang__) && __GNUC__ < 15 && (__GNUC__ > 12 || (__GNUC__ == 12 && __GNUC_MINOR__ >= 4)) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstringop-overflow" +#endif faceFeatureAttrMat.resizeTuples(tDims); +#if defined(__GNUC__) && !defined(__clang__) && __GNUC__ < 15 && (__GNUC__ > 12 || (__GNUC__ == 12 && __GNUC_MINOR__ >= 4)) +#pragma GCC diagnostic pop +#endif auto& surfaceMeshFeatureFaceLabels = m_DataStructure.getDataAs(m_InputValues->FeatureFaceLabelsArrayPath)->getDataStoreRef(); auto& surfaceMeshFeatureFaceNumTriangles = m_DataStructure.getDataAs(m_InputValues->FeatureFaceNumTrianglesArrayPath)->getDataStoreRef(); From 1dc91c071bed20785af2c4bbf4b38e5a92ebb923 Mon Sep 17 00:00:00 2001 From: Jared Duffey Date: Mon, 31 Aug 2026 11:36:04 -0400 Subject: [PATCH 15/15] Fixed Wnonnull warning after updating gcc * fclose with null is undefined behavior Signed-off-by: Jared Duffey --- .../src/SimplnxCore/Filters/Algorithms/WriteStlFile.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/WriteStlFile.cpp b/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/WriteStlFile.cpp index e7c57d0954..95116d0e81 100644 --- a/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/WriteStlFile.cpp +++ b/src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/WriteStlFile.cpp @@ -82,7 +82,6 @@ Result<> SingleWriteOutStl(WriteStlFile* filter, const fs::path& path, const IGe if(filePtr == nullptr) { - fclose(filePtr); return {MakeWarningVoidResult(-27886, fmt::format("Error Opening STL File. Unable to create temp file at path '{}' for original file '{}'", path.string(), path.filename().string()))}; } @@ -252,7 +251,6 @@ class MultiWriteStlFileImpl if(filePtr == nullptr) { - fclose(filePtr); m_Filter->sendThreadSafeProgressMessage( {MakeWarningVoidResult(-27876, fmt::format("Error Opening STL File. Unable to create temp file at path '{}' for original file '{}'", activePath.string(), activePath.filename().string()))}); return;