feedback fix 2

Author: TarasMykytiuk

Sprint-1/JavaScript/hasPairWithSum/hasPairWithSum.js

@@ -11,12 +11,13 @@
  */
 
 export function hasPairWithSum(numbers, target) {
-  const numbersSet = new Set(numbers);
-  const complementsSet = new Set();
+  const checkedNumbers = new Set();
   for (let i = 0; i < numbers.length; i++) {
-    complementsSet.add(target - numbers[i])
+    const complement = target - numbers[i];
+    if ( checkedNumbers.has(complement)) {
+      return true;
+    }
+    checkedNumbers.add(numbers[i])
   }
-  const intersection = complementsSet.intersection(numbersSet);
-  if (intersection.size > 0) return true;
   return false;
 }

Sprint-1/Python/has_pair_with_sum/has_pair_with_sum.py

@@ -7,15 +7,15 @@ def has_pair_with_sum(numbers: List[Number], target_sum: Number) -> bool:
     """
     Find if there is a pair of numbers that sum to a target value.
 
-    Time Complexity: worst O(N!) - factorial
+    Time Complexity: worst O(N^2) - square
     Space Complexity: O(numbers.length)
     Optimal time complexity: worth become O(N)
     """
-    num_set = set(numbers)
-    complements_set = set()
-    for i in range(len(numbers)):
-        complements_set.add(target_sum - numbers[i])
-    intersection = num_set.intersection(complements_set)
-    if len(intersection) > 0:
-        return True
+
+    cheked_numbers = set()
+    for number in numbers:
+        complement = target_sum - number
+        if complement in cheked_numbers:
+            return True
+        cheked_numbers.add(number)
     return False

Sprint-1/Python/remove_duplicates/remove_duplicates.py

@@ -12,7 +12,6 @@ def remove_duplicates(values: Sequence[ItemType]) -> List[ItemType]:
     Optimal time complexity: become O(N)
     """
 
-    unique_items = set()
     result = []
     for value in values:
         if value not in result: