refactoring the isProperFraction task

Author: Dagim-Daniel

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -14,14 +14,8 @@ function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
   numerator = Math.abs(numerator);
   denominator = Math.abs(denominator);
-  if (numerator<denominator)
-  {
-    return true;
-  }
-  else
-    return false;
+  return numerator < denominator;
 }
-
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
@@ -40,9 +34,9 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: 1/2 is a proper fraction.
 assertEquals(isProperFraction(1, 2), true);
 
-assertEquals(isProperFraction(1,1),false);
-assertEquals(isProperFraction(40234,98543),true);
-assertEquals(isProperFraction(2,1),false);
-assertEquals(isProperFraction(-10,-1),false);
-assertEquals(isProperFraction(-1,-10),true);
-assertEquals(isProperFraction(1.5,1),false);
+assertEquals(isProperFraction(1, 1), false);
+assertEquals(isProperFraction(40234, 98543), true);
+assertEquals(isProperFraction(2, 1), false);
+assertEquals(isProperFraction(-10, -1), false);
+assertEquals(isProperFraction(-1, -10), true);
+assertEquals(isProperFraction(1.5, 1), false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,24 +23,26 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
-   const value = card.slice(0, -1).toUpperCase();
+  const value = card.slice(0, -1).toUpperCase();
   const validSuits = "♠,♥,♦,♣".split(",");
   const suit = card.slice(-1);
 
-
-  if(!validSuits.includes(suit)) {
+  if (!validSuits.includes(suit)) {
     throw new Error("Invalid card");
   }
 
-  const faceCardValues = {'A': 11, 'J': 10, 'Q': 10, 'K': 10};
+  const faceCardValues = { A: 11, J: 10, Q: 10, K: 10 };
 
-  if(faceCardValues[value] === undefined && (Number(value) < 2 || Number(value) > 10)) {
+  if (
+    faceCardValues[value] === undefined &&
+    (Number(value) < 2 || Number(value) > 10)
+  ) {
     throw new Error("Invalid card");
   }
-  
+
   if (faceCardValues[value] !== undefined) {
     return faceCardValues[value];
-  } 
+  }
 
   const numvalue = Number(value);
   if (numvalue >= 2 && numvalue <= 10) {
@@ -64,9 +66,8 @@ function assertEquals(actualOutput, targetOutput) {
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
 
-assertEquals(getCardValue("A♥"),11);
-assertEquals(getCardValue("10♠"),10);
-
+assertEquals(getCardValue("A♥"), 11);
+assertEquals(getCardValue("10♠"), 10);
 
 assertEquals(getCardValue("2♠"), 2);
 assertEquals(getCardValue("K♠"), 10);