Merge branch 'main' into acoursework/sprint-2

Author: Ebrahim-Moqbel

Sprint-1/2-mandatory-errors/4.js

@@ -1,2 +1,2 @@
-const 12HourClockTime = "20:53";
-const 24hourClockTime = "08:53";
+const 12HourClockTime = "8:53pm";
+const 24hourClockTime = "20:53";

Sprint-2/4-mandatory-interpret/time-format.js

@@ -1,5 +1,9 @@
 function pad(num) {
-  return num.toString().padStart(2, "0");
+  let numString = num.toString();
+  while (numString.length < 2) {
+    numString = "0" + numString;
+  }
+  return numString;
 }
 
 function formatTimeDisplay(seconds) {
@@ -11,7 +15,7 @@ function formatTimeDisplay(seconds) {
   return `${pad(totalHours)}:${pad(remainingMinutes)}:${pad(remainingSeconds)}`;
 }
 
-console.log(formatTimeDisplay(60))
+console.log(formatTimeDisplay(61))
 // You will need to play computer with this example - use the Python Visualiser https://pythontutor.com/visualize.html#mode=edit
 // to help you answer these questions
 
@@ -26,13 +30,14 @@ console.log(formatTimeDisplay(60))
 // =============> the first time pad was called with the totalHours
 
 // c) What is the return value of pad is called for the first time?
-// =============> "00"
+// =============> "0"
 
 
 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> "1"
 // the last time, pad() is called with the remaining seconds which is value "1"
 
-// e) What is the return value assigned to num when pad is called for the last time in this program?  Explain your answer
+// e) What is the return value of pad when it is called for the last time in this program?  Explain your answer
 // =============> "01"
-// When it is called for the last time it adds 0 before 1 to make it 2 characters long
+
+

Sprint-3/1-implement-and-rewrite-tests/README.md

@@ -8,7 +8,7 @@ to choose test values that thoroughly test a function.
 In the `implement` directory you've got a number of functions you'll need to implement.
 For each function, you also have a number of different cases you'll need to check for your function.
 
-Write your assertions and build up your program case by case. Don't rush to a solution. The point of these assignments is to learn how to write assertions and build up a program step by step.
+Write your implementation and your tests to cover the cases the function should fulfil.
 
 Here is a recommended order:
 

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -46,7 +46,9 @@ try {
   getCardValue("invalid");
 
   // This line will not be reached if an error is thrown as expected
-  console.error("Error was not thrown for invalid card");
-} catch (e) {}
+  console.error("Error was not thrown for invalid card 😢");
+} catch (e) {
+  console.log("Error thrown for invalid card 🎉");
+}
 
 // What other invalid card cases can you think of?

Sprint-3/2-practice-tdd/repeat-str.js

@@ -1,4 +1,6 @@
 function repeatStr() {
+  // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
+  // The goal is to re-implement that function, not to use it.
   return "hellohellohello";
 }