Update isProperFraction logic for denominator checks

Author: ChinweP

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,7 +12,7 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
- if (denominator === 0) {
+ if (denominator <= 0) {
     return false;
   }
   return numerator < denominator;

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,37 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+// Denominator zero
+test("should return false when denominator is zero", () => {
+  expect(isProperFraction(1, 0)).toEqual(false);
+});
+
+// Proper fractions
+test("should return true for proper fractions (numerator < denominator)", () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(2, 3)).toEqual(true);
+  expect(isProperFraction(3, 4)).toEqual(true);
+  expect(isProperFraction(0, 5)).toEqual(true); // zero numerator is allowed
+});
+
+// Improper fractions
+test("should return false for improper fractions (numerator >= denominator)", () => {
+  expect(isProperFraction(5, 5)).toEqual(false);
+  expect(isProperFraction(7, 3)).toEqual(false);
+});
+
+// Negative numerators
+test("should return true when numerator is negative and denominator is positive", () => {
+  expect(isProperFraction(-1, 2)).toEqual(true);
+});
+
+// Negative denominators
+test("should return false when denominator is negative", () => {
+  expect(isProperFraction(1, -2)).toEqual(false);
+});
+
+// Both negative
+test("should return false when both numerator and denominator are negative", () => {
+  expect(isProperFraction(-3, -2)).toEqual(false);
+});