Skip to content

Commit dad46f3

Browse files
committed
rewrite code completely and tests
1 parent b31a586 commit dad46f3

1 file changed

Lines changed: 47 additions & 0 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,34 @@
1616

1717
function getAngleType(angle) {
1818
// TODO: Implement this function
19+
// first converting conditions into variables
20+
const acuteAngle = (angle > 0 && angle < 90);
21+
const rightAngle = (angle === 90);
22+
const obtuseAngle = (angle > 90 && angle < 180);
23+
const straightAngle = (angle === 180);
24+
const reflexAngle = (angle > 180 && angle < 360);
25+
const zeroAngle = (angle === 0);
26+
27+
28+
if (rightAngle) {
29+
// checking for conditions
30+
return "Right angle";
31+
} else if (zeroAngle) {
32+
return "Invalid angle";
33+
}else if (obtuseAngle) {
34+
return "Obtuse angle";
35+
} else if (straightAngle) {
36+
return "Straight angle";
37+
} else if (reflexAngle) {
38+
return "Reflex angle";
39+
} else if (acuteAngle) {
40+
return "Acute angle";
41+
} else if (angle === zeroAngle || angle != acuteAngle || angle != rightAngle || angle != obtuseAngle || angle != straightAngle || angle != reflexAngle) {
42+
return "Invalid angle";
43+
}
1944
}
2045

46+
2147
// The line below allows us to load the getAngleType function into tests in other files.
2248
// This will be useful in the "rewrite tests with jest" step.
2349
module.exports = getAngleType;
@@ -35,3 +61,24 @@ function assertEquals(actualOutput, targetOutput) {
3561
// Example: Identify Right Angles
3662
const right = getAngleType(90);
3763
assertEquals(right, "Right angle");
64+
65+
const acute = getAngleType(45);
66+
assertEquals(acute, "Acute angle");
67+
68+
const obtuse = getAngleType(120);
69+
assertEquals(obtuse, "Obtuse angle");
70+
71+
const straight = getAngleType(180);
72+
assertEquals(straight, "Straight angle");
73+
74+
const reflex = getAngleType(270);
75+
assertEquals(reflex, "Reflex angle");
76+
77+
const invalidAngle1 = getAngleType(360);
78+
assertEquals(invalidAngle1, "Invalid angle");
79+
80+
const invalidAngle2 = getAngleType(0);
81+
assertEquals(invalidAngle2, "Invalid angle");
82+
83+
const invalidAngle3 = getAngleType(-1);
84+
assertEquals(invalidAngle3, "Invalid angle");

0 commit comments

Comments
 (0)