Skip to content

Bug: subsample group name parsing and unnecessary dense matrix conversion #7

Description

@anastasiya-pendragon

Hello there! Thank you very much for the package!

I wanted to point out two issues that might affect other users.

  1. Unnecessary conversion of sparse matrix to dense matrix, which explodes in memory for huge datasets. For me, with 100k peaks and 30k cells, it was impossible to run the method on personal machine. I have used the patched function of create.group.matrices without this line and it worked fine.

counts <- as.matrix(counts)

  1. Problem with subsample group name parsing. If the group names do not have underscores, then all groups are just called "group" in the results.

het$state <- sub("-[^_]+$", "", het$state)

I suggest using this line instead.
het$state <- sub("-\\d+$", "", het$state)

Thank you, and I hope it helps.

Best,
Anastasiya

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions