From b36be720f557f647b339ec7dec9fd14ee4d88d54 Mon Sep 17 00:00:00 2001
From: Ubuntu <ubuntu@ip-172-31-1-247.eu-central-1.compute.internal>
Date: Tue, 1 Sep 2026 23:15:27 +0000
Subject: [PATCH 1/2] fix(search-filters): remove facet region landmarks and
 group under single section landmark (#5497)

---
 .../search-filter/search-filter.component.html           | 2 +-
 .../search-filter/search-filter.component.spec.ts        | 6 ++++++
 .../search/search-filters/search-filters.component.html  | 4 +++-
 .../search-filters/search-filters.component.spec.ts      | 9 +++++++++
 4 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/src/app/shared/search/search-filters/search-filter/search-filter.component.html b/src/app/shared/search/search-filters/search-filter/search-filter.component.html
index e1083fc7abd..8b23f001603 100644
--- a/src/app/shared/search/search-filters/search-filter/search-filter.component.html
+++ b/src/app/shared/search/search-filters/search-filter/search-filter.component.html
@@ -1,6 +1,6 @@
 @if (active$ | async) {
   <div class="facet-filter d-block mb-3 p-3"
-    [id]="regionId" [attr.aria-labelledby]="toggleId" [ngClass]="{ 'focus': focusBox }" role="region">
+    [id]="regionId" [attr.aria-labelledby]="toggleId" [ngClass]="{ 'focus': focusBox }">
     <button (click)="toggle()" (focusin)="focusBox = true" (focusout)="focusBox = false"
       class="filter-name d-flex" [attr.aria-controls]="regionId" [id]="toggleId"
       [attr.aria-expanded]="(collapsed$ | async) !== true"
diff --git a/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts b/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
index 352073c2b37..575c9c2954a 100644
--- a/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
+++ b/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
@@ -7,6 +7,7 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { RouterModule } from '@angular/router';
 import { AppliedFilter } from '@dspace/core/shared/search/models/applied-filter.model';
@@ -94,6 +95,11 @@ describe('SearchFilterComponent', () => {
     expect(comp.regionId).toContain('17');
   });
 
+  it('should not expose individual facet filter as a region landmark', () => {
+    const facetFilterElement = fixture.debugElement.query(By.css('.facet-filter'));
+    expect(facetFilterElement.attributes['role']).not.toBe('region');
+  });
+
   describe('when the toggle method is triggered', () => {
     beforeEach(() => {
       spyOn(searchFilterService, 'toggle');
diff --git a/src/app/shared/search/search-filters/search-filters.component.html b/src/app/shared/search/search-filters/search-filters.component.html
index bea2ea94671..4130e92f39d 100644
--- a/src/app/shared/search/search-filters/search-filters.component.html
+++ b/src/app/shared/search/search-filters/search-filters.component.html
@@ -1,3 +1,5 @@
+<section [attr.aria-label]="filterLabel + '.filters.head' | translate">
+
 @if (inPlaceSearch) {
   <h3>{{filterLabel+'.filters.head' | translate}}</h3>
 } @else {
@@ -21,4 +23,4 @@ <h2>{{filterLabel+'.filters.head' | translate}}</h2>
     <i class="fas fa-undo"></i> {{"search.filters.reset" | translate}}
   </button>
 }
-
+</section>
diff --git a/src/app/shared/search/search-filters/search-filters.component.spec.ts b/src/app/shared/search/search-filters/search-filters.component.spec.ts
index b0d268db996..656dcaef61f 100644
--- a/src/app/shared/search/search-filters/search-filters.component.spec.ts
+++ b/src/app/shared/search/search-filters/search-filters.component.spec.ts
@@ -7,6 +7,7 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { RouterModule } from '@angular/router';
 import { APP_CONFIG } from '@dspace/config/app-config.interface';
@@ -68,4 +69,12 @@ describe('SearchFiltersComponent', () => {
     });
   });
 
+  describe('accessibility', () => {
+    it('should render a section landmark with an accessible aria-label', () => {
+      const sectionElement = fixture.debugElement.query(By.css('section'));
+      expect(sectionElement).toBeTruthy();
+      expect(sectionElement.attributes['aria-label']).toBeTruthy();
+    });
+  });
+
 });

From 0145c85fe6cbdf9424545858ead207ff9370bc83 Mon Sep 17 00:00:00 2001
From: Ubuntu <ubuntu@ip-172-31-1-247.eu-central-1.compute.internal>
Date: Wed, 2 Sep 2026 10:48:53 +0000
Subject: [PATCH 2/2] test(search-filter): use dot notation for attributes.role
 to satisfy ESLint

---
 .../search-filter/search-filter.component.spec.ts               | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts b/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
index 575c9c2954a..132d0bca8d1 100644
--- a/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
+++ b/src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
@@ -97,7 +97,7 @@ describe('SearchFilterComponent', () => {
 
   it('should not expose individual facet filter as a region landmark', () => {
     const facetFilterElement = fixture.debugElement.query(By.css('.facet-filter'));
-    expect(facetFilterElement.attributes['role']).not.toBe('region');
+    expect(facetFilterElement.attributes.role).not.toBe('region');
   });
 
   describe('when the toggle method is triggered', () => {