fix(digest): compile and cover per-recipient Slack delivery

Seed checks User.isActiveAccount() (there is no isActive), and delivery
tests construct SlackDailyDigestService with the assembler + user repo.
Create-preference now asserts connection access and refuses EMAIL so the
UI cannot advertise a delivery path this PR does not implement.

Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>

Author: cursoragent

backend/src/main/java/com/dbaagent/controller/DigestPreferenceController.java

@@ -49,9 +49,23 @@ public ResponseEntity<List<UserDigestPreference>> getMyPreferences() {
     public ResponseEntity<UserDigestPreference> createPreference(@RequestBody CreatePreferenceRequest request) {
         String username = accessControlService.requireCurrentUsername();
 
-        DigestDeliveryMethod method = request.deliveryMethod != null
-            ? DigestDeliveryMethod.fromString(request.deliveryMethod)
-            : DigestDeliveryMethod.SLACK_DM;
+        DigestDeliveryMethod method;
+        if (request.deliveryMethod == null || request.deliveryMethod.isBlank()) {
+            method = DigestDeliveryMethod.SLACK_DM;
+        } else {
+            method = DigestDeliveryMethod.fromString(request.deliveryMethod);
+            if (method == null) {
+                throw new IllegalArgumentException("Unknown delivery method: " + request.deliveryMethod);
+            }
+        }
+
+        if (method == DigestDeliveryMethod.EMAIL) {
+            throw new IllegalArgumentException("Email digest delivery is not available yet");
+        }
+
+        if (request.connectionId != null && !request.connectionId.isBlank()) {
+            accessControlService.assertCanReadConnectionContent(request.connectionId);
+        }
 
         PersonaTag persona = request.personaTag != null
             ? PersonaTag.fromString(request.personaTag)
@@ -164,10 +178,10 @@ public ResponseEntity<List<Map<String, String>>> getPersonaTags() {
      */
     @GetMapping("/delivery-methods")
     public ResponseEntity<List<Map<String, String>>> getDeliveryMethods() {
+        // Only advertise methods this PR actually delivers. EMAIL/WhatsApp are PR4.
         List<Map<String, String>> methods = List.of(
             Map.of("value", "SLACK_DM", "label", DigestDeliveryMethod.SLACK_DM.getDisplayName(), "description", DigestDeliveryMethod.SLACK_DM.getDescription()),
-            Map.of("value", "SLACK_CHANNEL", "label", DigestDeliveryMethod.SLACK_CHANNEL.getDisplayName(), "description", DigestDeliveryMethod.SLACK_CHANNEL.getDescription()),
-            Map.of("value", "EMAIL", "label", DigestDeliveryMethod.EMAIL.getDisplayName(), "description", DigestDeliveryMethod.EMAIL.getDescription())
+            Map.of("value", "SLACK_CHANNEL", "label", DigestDeliveryMethod.SLACK_CHANNEL.getDisplayName(), "description", DigestDeliveryMethod.SLACK_CHANNEL.getDescription())
         );
         return ResponseEntity.ok(methods);
     }

backend/src/main/java/com/dbaagent/service/DigestPreferenceSeedService.java

@@ -73,7 +73,7 @@ public SeedResult seedPreferencesFromSingleton(boolean dryRun) {
             }
 
             User user = userOpt.get();
-            if (!user.isActive()) {
+            if (!user.isActiveAccount()) {
                 skipped.add(username + ": user inactive");
                 continue;
             }
@@ -136,7 +136,7 @@ public SeedResult seedPreferencesForUser(String username, boolean dryRun) {
         }
 
         User user = userOpt.get();
-        if (!user.isActive()) {
+        if (!user.isActiveAccount()) {
             return new SeedResult(0, 0, List.of(username + ": user inactive"), List.of());
         }
 

backend/src/main/java/com/dbaagent/service/SlackDailyDigestService.java

@@ -542,10 +542,14 @@ private PersonalizedDigestResult sendPersonalizedDigestToUser(
         String username = pref.getUsername();
         PersonaTag personaTag = pref.getPersonaTag();
 
-        // Resolve user's role
-        Role role = userRepository.findByUsernameIgnoreCase(username)
-            .map(User::getRoleEnum)
-            .orElse(Role.DEVELOPER);
+        // Resolve user's built-in role. Custom roles have no Role enum — rank as
+        // DEVELOPER rather than NPE on role.name(). Persist the stored role code
+        // on the log so the audit trail still names ANALYST, not a silent fallback.
+        User recipient = userRepository.findByUsernameIgnoreCase(username).orElse(null);
+        Role role = recipient != null && recipient.getRoleEnum() != null
+            ? recipient.getRoleEnum()
+            : Role.DEVELOPER;
+        String roleCode = recipient != null ? recipient.getRoleCode() : Role.DEVELOPER.name();
 
         // Assemble personalized digest
         DigestAssemblyResult assembly = digestInsightAssemblerService.assembleDigest(
@@ -562,7 +566,7 @@ private PersonalizedDigestResult sendPersonalizedDigestToUser(
         logEntry.setContent(message);
         logEntry.setHeadline(assembly.getHeadline());
         logEntry.setRecipientUsername(username);
-        logEntry.setRecipientRole(role.name());
+        logEntry.setRecipientRole(roleCode);
         logEntry.setPersonaTag(personaTag);
         logEntry.setDeliveryMethod(DigestDeliveryMethod.SLACK_DM);
         logEntry.setPreferenceId(pref.getId());

backend/src/test/java/com/dbaagent/service/DigestPreferenceSeedServiceTest.java

@@ -67,7 +67,7 @@ void seedPreferences_createsPreferenceForLinkedUser() {
         User alice = new User();
         alice.setUsername("alice");
         alice.setRole("DBA");
-        alice.setStatus("ACTIVE");
+        alice.setAccountStatus("ACTIVE");
         when(userRepository.findByUsernameIgnoreCase("alice")).thenReturn(Optional.of(alice));
 
         DatabaseConnection conn = new DatabaseConnection();
@@ -159,7 +159,7 @@ void seedPreferences_skipsExistingPreference() {
         User alice = new User();
         alice.setUsername("alice");
         alice.setRole("DBA");
-        alice.setStatus("ACTIVE");
+        alice.setAccountStatus("ACTIVE");
         when(userRepository.findByUsernameIgnoreCase("alice")).thenReturn(Optional.of(alice));
 
         DatabaseConnection conn = new DatabaseConnection();
@@ -193,7 +193,7 @@ void seedPreferences_dryRun_doesNotPersist() {
         User alice = new User();
         alice.setUsername("alice");
         alice.setRole("DBA");
-        alice.setStatus("ACTIVE");
+        alice.setAccountStatus("ACTIVE");
         when(userRepository.findByUsernameIgnoreCase("alice")).thenReturn(Optional.of(alice));
 
         DatabaseConnection conn = new DatabaseConnection();
@@ -221,7 +221,7 @@ void seedPreferences_skipsInactiveUser() {
 
         User inactive = new User();
         inactive.setUsername("inactive");
-        inactive.setStatus("SUSPENDED");
+        inactive.setAccountStatus("DISABLED");
         when(userRepository.findByUsernameIgnoreCase("inactive")).thenReturn(Optional.of(inactive));
 
         // When: seeding
@@ -239,7 +239,7 @@ void seedPreferences_skipsUserWithNoConnections() {
 
         User noconn = new User();
         noconn.setUsername("noconn");
-        noconn.setStatus("ACTIVE");
+        noconn.setAccountStatus("ACTIVE");
         when(userRepository.findByUsernameIgnoreCase("noconn")).thenReturn(Optional.of(noconn));
 
         when(connectionAccessService.getVisibleConnections("noconn", false))
@@ -259,7 +259,7 @@ void seedForUser_createsPreferencesForSpecificUser() {
         User alice = new User();
         alice.setUsername("alice");
         alice.setRole("DBA");
-        alice.setStatus("ACTIVE");
+        alice.setAccountStatus("ACTIVE");
         when(userRepository.findByUsernameIgnoreCase("alice")).thenReturn(Optional.of(alice));
 
         SlackUserLink link = new SlackUserLink();
@@ -288,7 +288,7 @@ private void setupUser(String username, String role) {
         User user = new User();
         user.setUsername(username);
         user.setRole(role);
-        user.setStatus("ACTIVE");
+        user.setAccountStatus("ACTIVE");
         when(userRepository.findByUsernameIgnoreCase(username)).thenReturn(Optional.of(user));
     }
 }