From 0df4a48e30bab3ff4ceb7947f5ef1f757776ff01 Mon Sep 17 00:00:00 2001 From: Yun Wang Date: Thu, 17 Sep 2026 17:51:59 +0200 Subject: [PATCH] ci: skip the GCP load balancer test on Release PRs too This job was left out of the skip on the grounds that it is a keep-alive probe rather than a gate. It is not. spec/integration/gcp_lb_keepalive_spec.rb is an ordinary regression test for CHA-4943: the SDK's connection pool must drop a pooled connection before the GCP SSL proxy closes it at ~30s idle, or the next request raises TransportError. "Keep-alive" there is HTTP connection reuse, not warming anything, and 35 of its 71 seconds are a hardcoded sleep. A Release PR changes no SDK code, so it has nothing to regress. All five test jobs now behave the same, and a Release PR waits on CodeQL alone: 58s rather than 71s. --- .github/workflows/run_tests.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index eb14b3f..4067748 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -152,9 +152,11 @@ jobs: run: make test-integration-video integration-gcp-lb: - # Not guarded below: this is a keep-alive probe, not a gate. It runs beside the other - # integration jobs rather than after them, so skipping it shortens nothing, and each - # skipped run is one fewer exercise of the GCP load balancer path it exists to keep warm. + if: >- + ${{ !(github.actor == 'github-actions[bot]' + && github.event.pull_request.user.login == 'github-actions[bot]' + && github.event.pull_request.head.repo.full_name == github.repository + && startsWith(github.head_ref, 'release-please--')) }} name: GCP load balancer keep-alive runs-on: ubuntu-latest timeout-minutes: 30