From ea5b1afd268cf8e1ddd9f33c28022a1ca309aa8b Mon Sep 17 00:00:00 2001 From: Lakshman Patel Date: Fri, 31 Jul 2026 10:52:39 +0530 Subject: [PATCH] ci: decouple test job from vet so test regressions can't be skipped A vet failure currently skips the entire tier 2+3 job graph, including test (race + coverage). This masked the DrainAlerts test breakage in PR #155, where vet failed on the trailer-strip force-push and the test job was silently skipped. The test job now depends only on [format] so the suite always runs and regressions surface. --- .github/workflows/ci.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c6a74d40..a9a51624 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -211,7 +211,13 @@ jobs: test: name: test (race + coverage) runs-on: ubuntu-latest - needs: [format, vet] + # NOTE: depends only on `format`, deliberately NOT on `vet`. + # A `vet` (or upstream) failure must never skip the test job — that + # historically masked real test regressions (see hawk PR #155, where + # DrainAlerts code shipped with failing tests because `test` was skipped + # when `vet` failed on the trailer-strip force-push). Tests must always + # run so regressions surface instead of being hidden. + needs: [format] steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: