3.7.0 disable isNil optimization during 3.7.0 upgrade

[dalehenrich]

in a standard 3.7.0 image, the isNil selector was optimized (i.e., not sent) the adverse effect on the GLASS/GsDevKit ecosystem wasn't noticed until too late in the release cycle to properly address the issues, so the decision was made to turn off isNil optimization in seaside extents for the time being ...

Individual developers can choose to turn isNil optimization on after upgrading and determine if their code base is affected or not as well as measure the benefits of the optimization in their application.

The

Log in as SystemUser and run the following code to enable isNil optimization in the base. Then login as each of your users with and run the just recompile doit:

category: 'Private'
classmethod: GsNMethod
_adjustOptimizedSelectors
  OptimizedSelectors := #( isNil notNil yourself ).
%
run
| x |
GsNMethod _adjustOptimizedSelectors .
(x := GsNMethod configurableOptimizedSelectors) = #( isNil notNil yourself ) 
ifFalse:[ Error signal: 'wrong value ', x printString ].
true
%
commit
logout
login
run
 "recompile methods that contain an isNil selector pattern ... to ensure method is optimized"
 | cnt | 
 cnt := 0 .
 ((ClassOrganizer new substringSearch: 'isNil') at: 1) do:[:meth |
   meth recompileFromSource .
   GsFile gciLogServer:'recompiled  ' , meth printString .
   cnt := cnt + 1 .
 ].
 ^ cnt
%
commit