From 819cf6a29230d123d77e9c998f4142588d3701f2 Mon Sep 17 00:00:00 2001 From: ky-hiverge Date: Wed, 26 Aug 2026 16:09:30 +0100 Subject: [PATCH] polish new modal provider Signed-off-by: ky-hiverge --- cmd/main.go | 6 +++++- pkg/provider/modal/client.go | 3 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/main.go b/cmd/main.go index befe39d..c964697 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -476,7 +476,11 @@ func setupVirtualNodes(mgr ctrl.Manager, blocklist vnode.Blocklister, kubeletSrv // unregistered provider surfaces as a clear NodePool condition rather than a // crash loop. func registerProviders(ctx context.Context, c client.Client) { - if p, err := modal.NewSDKClient(ctx, os.Getenv("MODAL_APP_NAME"), os.Getenv("MODAL_ENVIRONMENT")); err != nil { + appName := os.Getenv("MODAL_APP_NAME") + if appName == "" { + appName = "nebula" + } + if p, err := modal.NewSDKClient(ctx, appName, os.Getenv("MODAL_ENVIRONMENT")); err != nil { setupLog.Info("skipping Modal provider registration", "reason", err.Error()) } else { provider.Register(p) diff --git a/pkg/provider/modal/client.go b/pkg/provider/modal/client.go index 314e5a4..f4fcd6e 100644 --- a/pkg/provider/modal/client.go +++ b/pkg/provider/modal/client.go @@ -102,9 +102,6 @@ func NewSDKClient(ctx context.Context, appName, environment string) (*Provider, if err != nil { return nil, fmt.Errorf("modal: init SDK client: %w", err) } - if appName == "" { - appName = "nebula" - } cat, err := catalog.Load() if err != nil { return nil, fmt.Errorf("modal: load price catalog: %w", err)