From d3e77bad789267e6ca3032d7b828d9781293a185 Mon Sep 17 00:00:00 2001 From: Sascha Willems Date: Sat, 19 Sep 2026 12:46:49 +0200 Subject: [PATCH] Remove mentions of render passes Fixes #506 --- en/03_Drawing_a_triangle/04_Swap_chain_recreation.adoc | 5 ----- .../Debugging_Visual_Auditing/02_debug_drawers.adoc | 2 +- en/Building_a_Simple_Engine/Tooling/02_cicd.adoc | 4 +--- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/en/03_Drawing_a_triangle/04_Swap_chain_recreation.adoc b/en/03_Drawing_a_triangle/04_Swap_chain_recreation.adoc index c5a480af2..164eb098c 100644 --- a/en/03_Drawing_a_triangle/04_Swap_chain_recreation.adoc +++ b/en/03_Drawing_a_triangle/04_Swap_chain_recreation.adoc @@ -48,11 +48,6 @@ void recreateSwapChain() } ---- -Note that we don't recreate the renderpass here for simplicity. -In theory, it can be possible for the swap chain image format to change during an applications' lifetime, e.g., -when moving a window from a standard range to a high dynamic range monitor. -This may require the application to recreate the renderpass to make sure the change between dynamic ranges is properly reflected. - We'll move the cleanup code of all objects that are recreated as part of a swap chain refresh from `cleanup` to `cleanupSwapChain`: [,c++] diff --git a/en/Advanced_glTF/Debugging_Visual_Auditing/02_debug_drawers.adoc b/en/Advanced_glTF/Debugging_Visual_Auditing/02_debug_drawers.adoc index 73f931552..9fae4108a 100644 --- a/en/Advanced_glTF/Debugging_Visual_Auditing/02_debug_drawers.adoc +++ b/en/Advanced_glTF/Debugging_Visual_Auditing/02_debug_drawers.adoc @@ -169,7 +169,7 @@ Rendering colored lines requires a specialized graphics pipeline. Because we wan [source,cpp] ---- -void create_debug_pipeline(VkDevice device, VkRenderPass render_pass, VkPipelineLayout layout, VkPipeline& out_pipeline) +void create_debug_pipeline(VkDevice device, VkPipelineLayout layout, VkPipeline& out_pipeline) { // 1. Shaders: Simple unlit color pass // Vertex shader takes vec3 pos, vec3 color and multiplies by ViewProj. diff --git a/en/Building_a_Simple_Engine/Tooling/02_cicd.adoc b/en/Building_a_Simple_Engine/Tooling/02_cicd.adoc index 52d14c0c9..487c7a050 100644 --- a/en/Building_a_Simple_Engine/Tooling/02_cicd.adoc +++ b/en/Building_a_Simple_Engine/Tooling/02_cicd.adoc @@ -121,7 +121,6 @@ import vulkan_raii; // A testable function using vk::raii bool create_pipeline(vk::raii::Device& device, - vk::raii::RenderPass& render_pass, vk::raii::PipelineLayout& layout, vk::raii::Pipeline& out_pipeline) { try { @@ -139,11 +138,10 @@ TEST_CASE("Pipeline creation") { vk::raii::Context context; auto instance = create_test_instance(context); auto device = create_test_device(instance); - auto render_pass = create_test_render_pass(device); auto layout = create_test_pipeline_layout(device); vk::raii::Pipeline pipeline{nullptr}; - REQUIRE(create_pipeline(device, render_pass, layout, pipeline)); + REQUIRE(create_pipeline(device, layout, pipeline)); REQUIRE(pipeline); } ----