fix(sonar): resolve final 9 issues (S6549/S2077/S125/S4143/S1172)

- S6549: justified NOSONAR for user-configured storage roots with fixed filenames

- S2077: NOSONAR moved to the execution (sink) lines in DapperAsyncExtensions

- S125: rephrased comments that looked like commented-out code

- S4143: justified NOSONAR for the intentional community-restore assignment in Louvain

- S1172: justified NOSONAR for the API-symmetry query parameter in the demo

Author: MPCoreDeveloper

Examples/SharpCoreDB.GraphRAG.AIAssistant/Services/DocumentationService.cs

@@ -99,7 +99,7 @@ public async Task<List<GraphRAGResult>> VectorOnlySearchAsync(
     /// Performs vector similarity search using embeddings.
     /// </summary>
     private async Task<List<GraphRAGResult>> VectorSearchAsync(
-        string query, 
+        string query, // NOSONAR:S1172 - kept for API symmetry; the demo uses mock embeddings.
         int topK, 
         CancellationToken ct)
     {

src/SharpCoreDB.Extensions/DapperAsyncExtensions.cs

@@ -239,13 +239,13 @@ public static async Task<PagedResult<T>> QueryPagedAsync<T>(
             : null;
 
         // Get total count
-        var countSql = $"SELECT COUNT(*) FROM ({sql}) AS CountQuery"; // NOSONAR:S2077 - 'sql' is the caller's own (already parameterized) query wrapped in a COUNT(*) subquery; it cannot itself be bound as a parameter.
-        var totalCount = await connection.ExecuteScalarAsync<long>(countSql, parameters);
+        var countSql = $"SELECT COUNT(*) FROM ({sql}) AS CountQuery";
+        var totalCount = await connection.ExecuteScalarAsync<long>(countSql, parameters); // NOSONAR:S2077 - 'sql' is the caller's own (already parameterized) query wrapped in a COUNT(*) subquery; it cannot itself be bound as a parameter.
 
         // Get paged data
         var offset = (pageNumber - 1) * pageSize;
-        var pagedSql = $"{sql} LIMIT {pageSize} OFFSET {offset}"; // NOSONAR:S2077 - 'sql' is the caller's own query; pageSize/offset are validated integers.
-        var items = await connection.QueryAsync<T>(pagedSql, parameters);
+        var pagedSql = $"{sql} LIMIT {pageSize} OFFSET {offset}";
+        var items = await connection.QueryAsync<T>(pagedSql, parameters); // NOSONAR:S2077 - 'sql' is the caller's own query; pageSize/offset are validated integers.
 
         return new PagedResult<T>
         {

src/SharpCoreDB.Graph.Advanced/CommunityDetection/LouvainAlgorithm.cs

@@ -82,7 +82,7 @@ public async Task<CommunityDetectionResult> ExecuteAsync(GraphData graphData, Ca
                     }
 
                     // Restore old community for next test
-                    communities[i] = oldComm;
+                    communities[i] = oldComm; // NOSONAR:S4143 - intentional: restore the previous community before testing the next candidate.
                 }
 
                 // Apply best move

src/SharpCoreDB.VectorSearch/Index/HnswIndex.cs

@@ -38,8 +38,8 @@ public HnswIndex(HnswConfig config, int? seed = null)
         ArgumentNullException.ThrowIfNull(config);
         config.Validate();
         _config = config;
-        // Random is used only for HNSW graph level assignment (non-security);
-        // a seed is supported for deterministic testing.
+        // Random is used only for HNSW level assignment (not security);
+        // a seed is supported for deterministic tests.
         _levelRng = seed.HasValue ? new Random(seed.Value) : new Random(); // NOSONAR:S2245
     }
 

src/SharpCoreDB/Database/Core/Database.Core.cs

@@ -229,7 +229,7 @@ private void Load()
         else
         {
             // ✅ Legacy: Use IStorage (file-based)
-            var metaPath = Path.Combine(_dbPath, PersistenceConstants.MetaFileName);
+            var metaPath = Path.Combine(_dbPath, PersistenceConstants.MetaFileName); // NOSONAR:S6549 - _dbPath is the user-configured storage root; derived paths use fixed filenames.
             metaExists = File.Exists(metaPath);
 
 #if DEBUG

src/SharpCoreDB/Services/QueryCompiler.cs

@@ -656,8 +656,8 @@ void AddColumn(string? column)
 
         AddColumn(orderByColumn);
 
-        // local function 'AddColumn' mutates the captured 'columns' list;
-        // SonarC# cannot track the side effect and wrongly reports the loop as unreachable.
+        // Note: the local AddColumn helper mutates the captured columns list; SonarC#
+        // cannot track that side effect and wrongly reports the loop as unreachable.
         for (int i = 0; i < columns.Count; i++) // NOSONAR:S2583
         {
             indices[columns[i]] = i;

src/SharpCoreDB/Storage/Engines/AppendOnlyEngine.cs

@@ -46,7 +46,7 @@ public AppendOnlyEngine(IStorage storage, string databasePath)
         this.storage = storage ?? throw new ArgumentNullException(nameof(storage));
         this.databasePath = Path.GetFullPath(databasePath ?? throw new ArgumentNullException(nameof(databasePath)));
 
-        if (!Directory.Exists(databasePath))
+        if (!Directory.Exists(databasePath)) // NOSONAR:S6549 - databasePath is the user-configured storage root.
         {
             Directory.CreateDirectory(databasePath);
         }

src/SharpCoreDB/Storage/Engines/PageBasedEngine.cs

@@ -57,7 +57,7 @@ public PageBasedEngine(string databasePath, DatabaseConfig? config = null)
         this.databasePath = Path.GetFullPath(databasePath ?? throw new ArgumentNullException(nameof(databasePath)));
         this.config = config; // ✅ NEW: Store config
 
-        if (!Directory.Exists(databasePath))
+        if (!Directory.Exists(databasePath)) // NOSONAR:S6549 - databasePath is the user-configured storage root.
         {
             Directory.CreateDirectory(databasePath);
         }