Skip to content

Commit f5047c2

Browse files
fix: remove record rejection from error report (#149)
1 parent 2f5bb71 commit f5047c2

3 files changed

Lines changed: 5 additions & 14 deletions

File tree

src/dve/pipeline/pipeline.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,11 @@ def error_report(
852852
summary_items = er.SummaryItems(
853853
submission_status=submission_status,
854854
summary_dict=summary_dict,
855-
row_headings=[e.reporting_name for e in ErrorReportCategories],
855+
row_headings=[
856+
e.reporting_name
857+
for e in ErrorReportCategories
858+
if e != ErrorReportCategories.RECORD_REJECTION
859+
],
856860
)
857861

858862
workbook = er.ExcelFormat(

src/dve/reporting/excel_report.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -153,17 +153,6 @@ def _add_submission_info(self, status: str, summary: Worksheet):
153153
), # pylint: disable=C0301
154154
]
155155
)
156-
if status not in (
157-
ErrorReportStatus.PROCESSING_FAILED,
158-
ErrorReportStatus.FILE_REJECTION,
159-
):
160-
summary.append(
161-
[
162-
"",
163-
"Total Number of Records Rejected",
164-
self.submission_status.number_of_records_rejected,
165-
]
166-
)
167156
summary.append(["", ""])
168157

169158

tests/test_pipeline/test_spark_pipeline.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,9 +440,7 @@ def test_error_report_where_report_is_expected( # pylint: disable=redefined-out
440440
("File Name", "doesnotmatter"),
441441
("File Extension", "json"),
442442
("Total Number of Records Processed", "9"),
443-
("Total Number of Records Rejected", "2"),
444443
("File Rejection", "0"),
445-
("Record Rejection", "2"),
446444
("Warning", "0"),
447445
]
448446

0 commit comments

Comments
 (0)