[CSTACKEX-204] Address Review Comments

Author: Gupta, Surya

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapConfigurationManager.java

@@ -37,8 +37,7 @@ public class OntapConfigurationManager implements Configurable {
             OntapStorageConstants.ASUP_INTERVAL_CONFIG_KEY,
             String.valueOf(OntapStorageConstants.ASUP_DEFAULT_INTERVAL_HOURS),
             OntapStorageConstants.ASUP_INTERVAL_DESCRIPTION,
-            true, ConfigKey.Scope.Global, null,
-            OntapStorageConstants.ASUP_INTERVAL_DISPLAY_TEXT, asupIntervalValidator());
+            true, ConfigKey.Scope.Global, null, asupIntervalValidator());
 
     public static final ConfigKey<?>[] CONFIG_KEYS = new ConfigKey<?>[] {
             AsupIntervalHours

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageConstants.java

@@ -174,7 +174,6 @@ public class OntapStorageConstants {
     public static final int ASUP_MIN_INTERVAL_HOURS = 1;
     public static final int ASUP_MAX_INTERVAL_HOURS = 168; // once a week
     public static final int ASUP_DEFAULT_INTERVAL_HOURS = 24; // once a day
-    public static final String ASUP_INTERVAL_DISPLAY_TEXT = "NetApp ONTAP AutoSupport interval";
 
     public static final String ASUP_INTERVAL_DESCRIPTION =
             "The interval in hours between telemetry reports sent to the ONTAP cluster. "

plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/asup/OntapAsupManagerTest.java

@@ -520,11 +520,10 @@ void asupIntervalHours_defaultIsProductionValue() {
     }
 
     @Test
-    void asupIntervalHours_keyAndDisplayText() {
+    void asupIntervalHours_keyIsAutosupportInterval() {
         assertEquals(OntapStorageConstants.ASUP_INTERVAL_CONFIG_KEY,
                 OntapConfigurationManager.AsupIntervalHours.key());
-        assertEquals(OntapStorageConstants.ASUP_INTERVAL_DISPLAY_TEXT,
-                OntapConfigurationManager.AsupIntervalHours.displayText());
+        assertEquals("ontap.autosupport.interval", OntapConfigurationManager.AsupIntervalHours.key());
     }
 
     @Test