From 6087566c3d36f512093bb636ef1ff963dc47fea6 Mon Sep 17 00:00:00 2001 From: Oskar Eichler <62393985+OskarEichler@users.noreply.github.com> Date: Fri, 28 Aug 2026 02:45:53 +0300 Subject: [PATCH] fix(example): do not report malformed notification responses as success --- examples/demo/src/services/OneSignalApiService.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/demo/src/services/OneSignalApiService.ts b/examples/demo/src/services/OneSignalApiService.ts index dc040a3d..75d1bb9e 100644 --- a/examples/demo/src/services/OneSignalApiService.ts +++ b/examples/demo/src/services/OneSignalApiService.ts @@ -121,7 +121,11 @@ class OneSignalApiService { return false; } - const data = await response.json().catch(() => undefined); + const data = await response.json(); + if (data === null || typeof data !== 'object' || Array.isArray(data)) { + console.error('Send notification failed: invalid response'); + return false; + } if (isTransientSendFailure(data)) { if (attempt < maxAttempts) { await new Promise((resolve) => setTimeout(() => resolve(), 3_000 * attempt));