[Bug] Cannot determine line endings as the text probably contains mixed line endings.

[Frank-GTH]

Prerequisites

• Ensure you write a short, descriptive title after [Bug] above.
• Make sure to search for any existing issues before filing a new one.
• Verify you are able to reproduce the issue with the latest released version

PSAppDeployToolkit.Tools version

0.2.2

PSAppDeployToolkit version

4.0.5

Describe the bug

When converting a version 3.9.3 PSADT app I get this error:
Cannot determine line endings as the text probably contains mixed line endings.

Showing the CR and LF caracters in the file to be converted I do not seen anything different from a version 3.10.2 file.

Steps to reproduce

1.Convert-ADTDeployment -path .\v3.9.3-app
2.
3.

Environment data

OsName               : Microsoft Windows 10 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsProductName   : Windows 10 Enterprise
WindowsBuildLabEx    : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage           : en-US
OsMuiLanguages       : {en-US}
KeyboardLayout       : en-US
TimeZone             : (UTC+01:00) Amsterdam, Berlin, Bern, Rome, Stockholm, Vienna
HyperVisorPresent    : True
CsPartOfDomain       : False
CsPCSystemType       : Desktop

.NET SDK:
Version:           8.0.203
Commit:            5e1ceea679
Workload version:  8.0.200-manifests.4e94be9c

Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19045
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.203\

.NET workloads installed:
There are no installed workloads to display.

Host:
  Version:      8.0.3
  Architecture: x64
  Commit:       9f4b1f5d66

.NET SDKs installed:
  7.0.407 [C:\Program Files\dotnet\sdk]
  8.0.203 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 7.0.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 7.0.17 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 7.0.17 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

[DanGough]

Unable to reproduce this using the default Deploy-Application.ps1 that ships with 3.9.3. Would you be able to send us the .ps1 file that is causing the issue please?

[Frank-GTH]

Sure. Here is the file. Just change is back to ps1. Regards, Frank From: Dan Gough ***@***.***> Sent: 24 January 2025 18:28 To: PSAppDeployToolkit/PSAppDeployToolkit.Tools ***@***.***> Cc: Frank Langbein ***@***.***>; Author ***@***.***> Subject: Re: [PSAppDeployToolkit/PSAppDeployToolkit.Tools] [Bug] Cannot determine line endings as the text probably contains mixed line endings. (Issue #10) You don't often get email from ***@***.******@***.***>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> Unable to reproduce this using the default Deploy-Application.ps1 that ships with 3.9.3. Would you be able to send us the .ps1 file that is causing the issue please? — Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4P24IVXSEEIWQJBCIDC32T2MJZ2LAVCNFSM6AAAAABVXCNWAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJTGA2DINBVGU>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> <# .SYNOPSIS PSApppDeployToolkit - This script performs the installation or uninstallation of an application(s). .DESCRIPTION - The script is provided as a template to perform an install or uninstall of an application(s). - The script either performs an "Install" deployment type or an "Uninstall" deployment type. - The install deployment type is broken down into 3 main sections/phases: Pre-Install, Install, and Post-Install. The script dot-sources the AppDeployToolkitMain.ps1 script which contains the logic and functions required to install or uninstall an application. PSApppDeployToolkit is licensed under the GNU LGPLv3 License - (C) 2023 PSAppDeployToolkit Team (Sean Lillis, Dan Cunningham and Muhammad Mashwani). This program is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation, either version 3 of the License, or any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. .PARAMETER DeploymentType The type of deployment to perform. Default is: Install. .PARAMETER DeployMode Specifies whether the installation should be run in Interactive, Silent, or NonInteractive mode. Default is: Interactive. Options: Interactive = Shows dialogs, Silent = No dialogs, NonInteractive = Very silent, i.e. no blocking apps. NonInteractive mode is automatically set if it is detected that the process is not user interactive. .PARAMETER AllowRebootPassThru Allows the 3010 return code (requires restart) to be passed back to the parent process (e.g. SCCM) if detected from an installation. If 3010 is passed back to SCCM, a reboot prompt will be triggered. .PARAMETER TerminalServerMode Changes to "user install mode" and back to "user execute mode" for installing/uninstalling applications for Remote Desktop Session Hosts/Citrix servers. .PARAMETER DisableLogging Disables logging to file for the script. Default is: $false. .EXAMPLE powershell.exe -Command "& { & '.\Deploy-Application.ps1' -DeployMode 'Silent'; Exit $LastExitCode }" .EXAMPLE powershell.exe -Command "& { & '.\Deploy-Application.ps1' -AllowRebootPassThru; Exit $LastExitCode }" .EXAMPLE powershell.exe -Command "& { & '.\Deploy-Application.ps1' -DeploymentType 'Uninstall'; Exit $LastExitCode }" .EXAMPLE Deploy-Application.exe -DeploymentType "Install" -DeployMode "Silent" .INPUTS None You cannot pipe objects to this script. .OUTPUTS None This script does not generate any output. .NOTES Toolkit Exit Code Ranges: - 60000 - 68999: Reserved for built-in exit codes in Deploy-Application.ps1, Deploy-Application.exe, and AppDeployToolkitMain.ps1 - 69000 - 69999: Recommended for user customized exit codes in Deploy-Application.ps1 - 70000 - 79999: Recommended for user customized exit codes in AppDeployToolkitExtensions.ps1 .LINK https://psappdeploytoolkit.com #> [CmdletBinding()] Param ( [Parameter(Mandatory = $false)] [ValidateSet('Install', 'Uninstall', 'Repair')] [String]$DeploymentType = 'Install', [Parameter(Mandatory = $false)] [ValidateSet('Interactive', 'Silent', 'NonInteractive')] [String]$DeployMode = 'Interactive', [Parameter(Mandatory = $false)] [switch]$AllowRebootPassThru = $false, [Parameter(Mandatory = $false)] [switch]$TerminalServerMode = $false, [Parameter(Mandatory = $false)] [switch]$DisableLogging = $false ) Try { ## Set the script execution policy for this process Try { Set-ExecutionPolicy -ExecutionPolicy 'ByPass' -Scope 'Process' -Force -ErrorAction 'Stop' } Catch { } ##*=============================================== ##* VARIABLE DECLARATION ##*=============================================== ## Variables: Application [String]$appVendor = 'PayGlobal Technology B.V.' [String]$appName = 'IBANC' [String]$appVersion = '6.0.0' [String]$appArch = 'x64' [String]$appLang = 'EN' [String]$appRevision = '01' [String]$appScriptVersion = '1.0.0' [String]$appScriptDate = '14/01/2025' [String]$appScriptAuthor = 'Frank Langbein' ##*=============================================== ## Variables: Install Titles (Only set here to override defaults set by the toolkit) [String]$installName = '' [String]$installTitle = '' ##* Do not modify section below #region DoNotModify ## Variables: Exit Code [Int32]$mainExitCode = 0 ## Variables: Script [String]$deployAppScriptFriendlyName = 'Deploy Application' [Version]$deployAppScriptVersion = [Version]'3.9.3' [String]$deployAppScriptDate = '02/05/2023' [Hashtable]$deployAppScriptParameters = $PsBoundParameters ## Variables: Environment If (Test-Path -LiteralPath 'variable:HostInvocation') { $InvocationInfo = $HostInvocation } Else { $InvocationInfo = $MyInvocation } [String]$scriptDirectory = Split-Path -Path $InvocationInfo.MyCommand.Definition -Parent ## Dot source the required App Deploy Toolkit Functions Try { [String]$moduleAppDeployToolkitMain = "$scriptDirectory\AppDeployToolkit\AppDeployToolkitMain.ps1" If (-not (Test-Path -LiteralPath $moduleAppDeployToolkitMain -PathType 'Leaf')) { Throw "Module does not exist at the specified location [$moduleAppDeployToolkitMain]." } If ($DisableLogging) { . $moduleAppDeployToolkitMain -DisableLogging } Else { . $moduleAppDeployToolkitMain } } Catch { If ($mainExitCode -eq 0) { [Int32]$mainExitCode = 60008 } Write-Error -Message "Module [$moduleAppDeployToolkitMain] failed to load: `n$($_.Exception.Message)`n `n$($_.InvocationInfo.PositionMessage)" -ErrorAction 'Continue' ## Exit the script, returning the exit code to SCCM If (Test-Path -LiteralPath 'variable:HostInvocation') { $script:ExitCode = $mainExitCode; Exit } Else { Exit $mainExitCode } } #endregion ##* Do not modify section above ##*=============================================== ##* END VARIABLE DECLARATION ##*=============================================== If ($deploymentType -ine 'Uninstall' -and $deploymentType -ine 'Repair') { ##*=============================================== ##* PRE-INSTALLATION ##*=============================================== [String]$installPhase = 'Pre-Installation' ### Start NAUTADUTILH ### <#$SWProc = @("outlook","winword","excel","powerpnt","codex") $i_sw = 0 Foreach ($sw in $SWProc) { $IsRunning = Get-Process $SWProc -ErrorAction SilentlyContinue If ($IsRunning) { $i_sw ++ } } # Run Silent if app not running If ($i_sw -ne 0) { # Pre-install messagebox $MsgND= "During the Codex installation please don't use Microsoft Office Programs and Codex. Please close Microsoft Office and Codex now. Please click OK." Show-InstallationPrompt -MessageAlignment 'Left' -Message $MsgND -ButtonMiddleText 'OK' -Icon Information -Timeout 900 -ExitOnTimeout $false ## Show Welcome Message, close programs if required, allow up to 3 deferrals, verify there is enough disk space to complete the install, and persist the prompt $CloseAppsND = 'outlook=Microsoft Office Outlook,winword=Microsoft Office Word,excel=Microsoft Office Excel,powerpnt=Microsoft Office Powerpoint,codex=Codex' $DeferDeadlineND = '2023-10-31 12:00:00Z' Show-InstallationWelcome -CloseApps $CloseAppsND -BlockExecution -AllowDeferCloseApps -DeferTimes 3 -CheckDiskSpace -PersistPrompt -ForceCloseAppsCountdown 2700 #-DeferDeadline $DeferDeadlineND ## Show Progress Message (with the default message) Show-InstallationProgress }#> ## <Perform Pre-Installation tasks here> # Start uninstall of old versions ### End NAUTADUTILH ### ##*=============================================== ##* INSTALLATION ##*=============================================== [String]$installPhase = 'Installation' ## Handle Zero-Config MSI Installations If ($useDefaultMsi) { [Hashtable]$ExecuteDefaultMSISplat = @{ Action = 'Install'; Path = $defaultMsiFile }; If ($defaultMstFile) { $ExecuteDefaultMSISplat.Add('Transform', $defaultMstFile) } Execute-MSI @ExecuteDefaultMSISplat; If ($defaultMspFiles) { $defaultMspFiles | ForEach-Object { Execute-MSI -Action 'Patch' -Path $_ } } } ## <Perform Installation tasks here> ### Start NAUTADUTILH ### Execute-MSI -Action 'Install' -Path 'IBANC6.0.0.msi' -Parameters '/QN' ### End NAUTADUTILH ### ##*=============================================== ##* POST-INSTALLATION ##*=============================================== [String]$installPhase = 'Post-Installation' ## <Perform Post-Installation tasks here> ### Start NAUTADUTILH ### # Delete shortcut Remove-File -Path "$envCommonDesktop\IBANC.lnk" ### End NAUTADUTILH ### ## Display a message at the end of the install If ((-not $useDefaultMsi) -and ($i_sw -ne 0)) { $MsgND = 'You may (re)start Micrososft Outlook.' #Show-InstallationPrompt -MessageAlignment 'Left' -Message $MsgND -ButtonMiddleText 'OK' -Icon Information -NoWait } } ElseIf ($deploymentType -ieq 'Uninstall') { ##*=============================================== ##* PRE-UNINSTALLATION ##*=============================================== [String]$installPhase = 'Pre-Uninstallation' ##Show-InstallationWelcome -CloseApps 'iexplore' -CloseAppsCountdown 60 # Will silently close Outlook only when app is open Show-InstallationWelcome -CloseApps 'outlook' -Silent #Show-InstallationWelcome -CloseApps 'iexplore' -CloseAppsCountdown 60 ## Show Progress Message (with the default message) #Show-InstallationProgress ## <Perform Pre-Uninstallation tasks here> ##*=============================================== ##* UNINSTALLATION ##*=============================================== [String]$installPhase = 'Uninstallation' ## Handle Zero-Config MSI Uninstallations If ($useDefaultMsi) { [Hashtable]$ExecuteDefaultMSISplat = @{ Action = 'Uninstall'; Path = $defaultMsiFile }; If ($defaultMstFile) { $ExecuteDefaultMSISplat.Add('Transform', $defaultMstFile) } Execute-MSI @ExecuteDefaultMSISplat } ## <Perform Uninstallation tasks here> ### Start NAUTADUTILH ### Execute-MSI -Action 'Uninstall' -Path '{5720DEAE-1851-4E9C-9DAE-ECF5121FEE72}' -Parameters '/QB-!' ### End NAUTADUTILH ### ##*=============================================== ##* POST-UNINSTALLATION ##*=============================================== [String]$installPhase = 'Post-Uninstallation' ## <Perform Post-Uninstallation tasks here> ### Start NAUTADUTILH ### ### End NAUTADUTILH ### } ElseIf ($deploymentType -ieq 'Repair') { ##*=============================================== ##* PRE-REPAIR ##*=============================================== [String]$installPhase = 'Pre-Repair' ## Show Welcome Message, close Internet Explorer with a 60 second countdown before automatically closing Show-InstallationWelcome -CloseApps 'iexplore' -CloseAppsCountdown 60 ## Show Progress Message (with the default message) Show-InstallationProgress ## <Perform Pre-Repair tasks here> ##*=============================================== ##* REPAIR ##*=============================================== [String]$installPhase = 'Repair' ## Handle Zero-Config MSI Repairs If ($useDefaultMsi) { [Hashtable]$ExecuteDefaultMSISplat = @{ Action = 'Repair'; Path = $defaultMsiFile; }; If ($defaultMstFile) { $ExecuteDefaultMSISplat.Add('Transform', $defaultMstFile) } Execute-MSI @ExecuteDefaultMSISplat } ## <Perform Repair tasks here> ##*=============================================== ##* POST-REPAIR ##*=============================================== [String]$installPhase = 'Post-Repair' ## <Perform Post-Repair tasks here> } ##*=============================================== ##* END SCRIPT BODY ##*=============================================== ## Call the Exit-Script function to perform final cleanup operations Exit-Script -ExitCode $mainExitCode } Catch { [Int32]$mainExitCode = 60001 [String]$mainErrorMessage = "$(Resolve-Error)" Write-Log -Message $mainErrorMessage -Severity 3 -Source $deployAppScriptFriendlyName Show-DialogBox -Text $mainErrorMessage -Icon 'Stop' Exit-Script -ExitCode $mainExitCode }

[PZan]

I stumbled upon this issue myself as I was testing out converting a package. In my case I simply changed the End of Line Sequence in my old package from CRLF to LF. This is easily done in the bottom right corner in VSCode when editing a file.

[DanGough]

Thanks, I'll see if I can repro and fix by doing the opposite!

[SPatrickStevens]

The following snippet is from a larger script I put together, but this is what I ended up putting together to address the mixed line endings issue. You can see I'm making a copy of the original Deploy-Application.ps1 just in case, but that is probably not 100% necessary.

## Avoid PSScriptAnalyzer message: Cannot determine line endings as the text probably contain mixed line endings.
$DeployApplicationFilePath = "$Path\Deploy-Application.ps1"
$DeployApplicationFileContent = Get-Content -Path $DeployApplicationFilePath -Raw
if ($DeployApplicationFileContent -match "\r\n") {
    Write-Verbose -Message "Deploy-Application.ps1 - CRLF line endings detected. Will convert file to LF." -Verbose
    ## Back up original file
    Copy-ADTFile -Path "$DeployApplicationFilePath" -Destination "$Path\Deploy-Application-Originial.ps1"
    ## Convert from CRLF to LF
    $DeployApplicationFileText = [IO.File]::ReadAllText($DeployApplicationFilePath) -replace "`r`n", "`n"
    [IO.File]::WriteAllText($DeployApplicationFilePath, $DeployApplicationFileText)
}
else {
    Write-Verbose -Message "Deploy-Application.ps1 - CRLF line endings not detected. No conversion to LF required." -Verbose
}

After converting the file to LF, Convert-ADTDeployment will work. Although, now I seem to be running into a new PSScriptAnalyzer issue after it was updated by Microsoft in recent weeks. PSAppDeployToolkit.Tools doesn't seem to play nicely with it...

## Convert legacy PSAppDeployToolkit deployment to newest version based on installed PowerShell module
Convert-ADTDeployment -Path $Path -Verbose

[DanGough]

Thanks for the heads-up re not playing nice with the new PSScriptAnalyzer, I'll check that out.

[DanGough]

This is a limitation of PSScriptAnalyzer, which this module uses for processing:
PowerShell/PSScriptAnalyzer#2074
https://github.com/PowerShell/PSScriptAnalyzer/blob/ea70855e9d6de8c214757b4dad7b6ed92e8348c8/Engine/EditableText.cs#L185

I suggest that for now, you sanitise your scripts by saving them in a decent editor like VSCode, and track that issue for further developments.

[iRon7]

This also happens with a "decent" Set-Content cmdlet under Windows PowerShell 5.1:

$tempFile = Join-Path $TestDrive 'TestScript.ps1'
Set-Content -LiteralPath $tempFile -Value {
    for ($i = 0; $i -lt 100000; $i++) {
        $resultObject = New-Object PSCustomObject -Property @{
            Name = "Name$i"
            Value = $i
        }
    }
}
$violations = Invoke-ScriptAnalyzer -Path $tempFile -Settings $Settings -fix

The workaround is to add the -NoNewline parameter:

Set-Content -LiteralPath $tempFile -NoNewline -Value { ...