|
108 | 108 |
|
109 | 109 | concurrency: |
110 | 110 | group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} |
111 | | - cancel-in-progress: false |
| 111 | + cancel-in-progress: ${{ github.event_name == 'pull_request' }} |
112 | 112 |
|
113 | 113 | permissions: |
114 | 114 | contents: write |
@@ -136,7 +136,7 @@ decisions before canonical guides, templates, or consumer workflows adopt it: |
136 | 136 | | Wrapper scope | Exactly one reusable-workflow job. | Permit repository-specific jobs in the same file, or define pre/post extension jobs. | |
137 | 137 | | Trigger ownership | The caller owns manual, schedule, default-branch push, and pull-request triggers. | Move some trigger policy into separate workflows or omit selected event classes. | |
138 | 138 | | Pull-request activities | Keep all six listed activity types. | Reduce the activity list if a v8 behavior is intentionally unsupported. | |
139 | | -| Concurrency | Use the PR-number-or-ref key and never cancel a release-capable run. | Use separate groups per event class or permit cancellation for non-mutating paths. | |
| 139 | +| Concurrency | Use the workflow plus PR-number-or-full-ref key and cancel only pull-request runs. | Selected for the candidate: PR reconciliation must be resumable; non-PR runs serialize by full ref. | |
140 | 140 | | Permissions | Declare the five current scopes at workflow level. | Introduce settings-based least-privilege profiles or split read-only validation from release work. | |
141 | 141 | | Fork behavior | Skip fork-originated pull requests in this credentialed wrapper. | Add a separate secret-free workflow or define another supported fork-validation design. | |
142 | 142 | | Credentials | Explicitly map the three v8 credentials. | Define a narrower credential profile for repositories that cannot publish. | |
@@ -171,7 +171,7 @@ fleet campaign. Branch names, `latest`, floating minor tags, and unqualified tar |
171 | 171 | | Default-branch push | Keep `push.branches: [main]`. | `v8` authorizes stable releases from the tested default-branch push. | |
172 | 172 | | Manual dispatch | Keep `workflow_dispatch`. | Provides the documented default-branch manual release and recovery path. | |
173 | 173 | | Schedule | Keep a scheduled health run. | Exercises current dependencies even when repository code is unchanged. | |
174 | | -| Concurrency | Use the PR-number-or-ref key with `cancel-in-progress: false`. | Cleanup and stable release runs stay distinct; release mutations queue instead of being interrupted. | |
| 174 | +| Concurrency | Use the PR-number-or-ref key and cancel only pull-request runs. | New PR events supersede older declarative reconciliation runs; same-ref push, dispatch, and schedule runs serialize without cancellation. | |
175 | 175 | | Permissions | Declare the five documented permissions explicitly. | The called workflow cannot elevate caller permissions. | |
176 | 176 | | Fork guard | Skip pull requests whose head repository differs from `github.repository`. | GitHub withholds the required repository secrets from fork pull requests. | |
177 | 177 | | Reference | Use the intended internal floating major tag (`v8`) after tag governance is enforced. | Compatible owned releases roll out centrally; breaking releases require a new major and campaign. | |
@@ -202,7 +202,7 @@ an approved structure: |
202 | 202 | - any Process-PSModule reference other than the intended major tag (`v8`), including a branch, `latest`, minor tag, |
203 | 203 | exact patch tag, or full commit SHA; |
204 | 204 | - missing `push` or `unlabeled` triggers; |
205 | | -- `cancel-in-progress: true` or the old ref-only concurrency key; |
| 205 | +- a concurrency key other than workflow plus PR number or full ref, or cancellation behavior other than pull-request-only; |
206 | 206 | - trigger-level path filters that bypass Process-PSModule important-file evaluation; |
207 | 207 | - unrelated additional jobs in the caller wrapper; |
208 | 208 | - omitted documented permissions without a verified settings-based least-privilege profile. |
|
0 commit comments