Normalize the releases JSON in a dedicated conversion function

Write-Output -NoEnumerate handed the caller an array nested inside an
array, so the tag name of every release was concatenated into one string
and rejected as an invalid SemVer. The JSON conversion now lives in its
own function that always yields a flat array, including when the gh
command produced no output at all.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: MariusStorhaug

.github/actions/Resolve-PSModuleVersion/src/Resolve-PSModuleVersion.Helpers.psm1

@@ -277,20 +277,52 @@ function Resolve-ReleaseDecision {
     }
 }
 
+function ConvertFrom-GitHubReleaseJson {
+    <#
+        .SYNOPSIS
+        Converts the JSON output of 'gh release list' into a flat array of release objects.
+
+        .DESCRIPTION
+        Normalizes the release listing so a repository with no releases, or a command that
+        produced no output at all, yields an empty array instead of $null.
+
+        .OUTPUTS
+        Array of release objects. Empty when there are no releases.
+
+        .EXAMPLE
+        $releases = ConvertFrom-GitHubReleaseJson -Json '[{"tagName":"v1.0.0"}]'
+    #>
+    [CmdletBinding()]
+    [OutputType([object[]], [array])]
+    param(
+        # The raw JSON returned by 'gh release list'. Empty or null when the command produced no output.
+        [Parameter()]
+        [AllowNull()]
+        [AllowEmptyString()]
+        [string] $Json
+    )
+
+    if ([string]::IsNullOrWhiteSpace($Json)) {
+        return @()
+    }
+
+    @($Json | ConvertFrom-Json)
+}
+
 function Get-GitHubRelease {
     <#
         .SYNOPSIS
         Retrieves all releases from the current GitHub repository.
 
         .DESCRIPTION
         Lists the releases of the current repository. A repository that has no releases yet
-        returns an empty array rather than $null, so callers can treat the result uniformly.
+        produces no output, so callers normalize the result with @() before using it.
 
         .OUTPUTS
-        Array of release objects. Empty when the repository has no releases.
+        Array of release objects. Nothing when the repository has no releases.
 
         .EXAMPLE
-        $releases = Get-GitHubRelease
+        $releases = @(Get-GitHubRelease)
     #>
     [CmdletBinding()]
     [OutputType([array])]
@@ -302,16 +334,15 @@ function Get-GitHubRelease {
             Write-Error 'Failed to list releases for the repo.'
             exit $LASTEXITCODE
         }
-        $releases = @($releasesJson | ConvertFrom-Json)
+        $releases = ConvertFrom-GitHubReleaseJson -Json $releasesJson
 
         Write-Host '-------------------------------------------------'
         Write-Host "Found [$($releases.Count)] releases."
         Write-Host ($releases | Select-Object -Property name, isPrerelease, isLatest, publishedAt |
                 Format-Table | Out-String)
         Write-Host '-------------------------------------------------'
 
-        # -NoEnumerate keeps an empty or single-element result an array through the pipeline.
-        Write-Output -NoEnumerate -InputObject $releases
+        $releases
     }
 }
 

.github/actions/Resolve-PSModuleVersion/tests/Resolve-PSModuleVersion.Helpers.Tests.ps1

@@ -91,6 +91,54 @@ BeforeAll {
 }
 
 Describe 'Resolve-PSModuleVersion' {
+    Describe 'ConvertFrom-GitHubReleaseJson' {
+        Context 'ConvertFrom-GitHubReleaseJson - repository without releases' {
+            It 'ConvertFrom-GitHubReleaseJson - returns an empty array for an empty JSON array' {
+                $result = ConvertFrom-GitHubReleaseJson -Json '[]'
+                @($result).Count | Should -Be 0
+            }
+
+            It 'ConvertFrom-GitHubReleaseJson - returns an empty array when the command produced no output' {
+                $result = ConvertFrom-GitHubReleaseJson -Json ''
+                @($result).Count | Should -Be 0
+            }
+
+            It 'ConvertFrom-GitHubReleaseJson - returns an empty array for null input' {
+                $result = ConvertFrom-GitHubReleaseJson -Json $null
+                @($result).Count | Should -Be 0
+            }
+        }
+
+        Context 'ConvertFrom-GitHubReleaseJson - releases present' {
+            It 'ConvertFrom-GitHubReleaseJson - returns a flat array of release objects' {
+                $json = '[{"tagName":"v1.2.3","isLatest":true},{"tagName":"v1.2.2","isLatest":false}]'
+                $result = @(ConvertFrom-GitHubReleaseJson -Json $json)
+                $result.Count | Should -Be 2
+                $result[0].tagName | Should -Be 'v1.2.3'
+            }
+
+            It 'ConvertFrom-GitHubReleaseJson - returns a single release without nesting it in an inner array' {
+                $result = @(ConvertFrom-GitHubReleaseJson -Json '[{"tagName":"v0.0.1","isLatest":true}]')
+                $result.Count | Should -Be 1
+                $result[0].tagName | Should -Be 'v0.0.1'
+            }
+
+            It 'ConvertFrom-GitHubReleaseJson - output binds to the Releases parameter without nesting' {
+                $json = '[{"tagName":"v1.2.3","isLatest":true},{"tagName":"v1.2.2","isLatest":false}]'
+                $releases = @(ConvertFrom-GitHubReleaseJson -Json $json)
+                $result = Get-LatestGitHubVersion -Releases $releases
+                $result.ToString() | Should -Be 'v1.2.3'
+            }
+
+            It 'ConvertFrom-GitHubReleaseJson - survives the log group wrapper without nesting' {
+                $json = '[{"tagName":"v1.2.3","isLatest":true},{"tagName":"v1.2.2","isLatest":false}]'
+                $releases = @(LogGroup 'Get releases - GitHub' { ConvertFrom-GitHubReleaseJson -Json $json })
+                $releases.Count | Should -Be 2
+                $releases[0].tagName | Should -Be 'v1.2.3'
+            }
+        }
+    }
+
     Describe 'Get-LatestGitHubVersion' {
         Context 'Get-LatestGitHubVersion - repository without releases' {
             It 'Get-LatestGitHubVersion - returns 0.0.0 when the releases list is null' {