Skip to content

Fresh install of extension_drop fails on PostgreSQL 9.3-10 (hardcoded DROP ROUTINE via cat_tools) #44

Description

@jnasbyupgrade

extension_drop's install script (both the historical 0.1.1 release and the
current stable source) unconditionally calls
cat_tools.routine__parse_arg_types_text(), which transitively hits
cat_tools's _cat_tools.function__drop_temp(). That function runs a
hardcoded DROP ROUTINE statement -- syntax that doesn't exist before
PostgreSQL 11. A fresh install of extension_drop on PG9.3-10 hits this and
fails.

extension_drop's declared floor is already PostgreSQL 12+ (cat_tools's own
requirement -- see HISTORY.asc's "Drop support for PostgreSQL versions
before 12"), so this doesn't affect anyone following that floor. Nothing
currently enforces it at install time, though -- there's no version check
that would turn this into a clear error instead of the raw DROP ROUTINE
syntax error. It's also not gated in CI, since the test matrix only covers
PG12+.

Given the floor is already 12+, this may not be worth fixing directly --
closing as won't-fix (already out of the supported range) is a reasonable
resolution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions