Commit a78c968
Don't clobber caller's client_min_messages on install (#4)
The install script began with an unconditional
`SET LOCAL client_min_messages = WARNING`. Because CREATE EXTENSION
runs the whole script in a single transaction, that SET LOCAL applied
for the entire statement -- including any CASCADE that pulls
object_reference in as a dependency -- silently overriding a caller
who had deliberately set a stricter level (e.g. `SET client_min_messages
= error`) to keep install output quiet.
Replace it with a DO block that only raises the floor to WARNING when
the caller's current level is more verbose than WARNING; a stricter
level (warning/error) is left untouched. SET LOCAL inside the DO block
still applies to the rest of the CREATE EXTENSION transaction and
reverts at commit, so it never leaks into the caller's session.
Note: the zzz_build test echoes the install script with source line
numbers, so its expected output shifts by the number of lines this
block adds (+32). It could not be regenerated in place here because
master does not build on modern PostgreSQL with the pgxn-provided
cat_tools; regenerate expected output in the canonical CI environment.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent d191ef1 commit a78c968
1 file changed
Lines changed: 33 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
2 | 34 | | |
3 | 35 | | |
4 | 36 | | |
| |||
0 commit comments