From b723a8e90d1e036507d89fd1ee91f40098798d08 Mon Sep 17 00:00:00 2001 From: lizschwab Date: Mon, 10 Aug 2026 16:26:04 -0700 Subject: [PATCH 1/2] chore: remove test timeouts and add fake timers --- .../plugins/workspace-minimap/test/minimap_tests.mocha.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js b/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js index 5d0efe9ac59..be604f3cb91 100644 --- a/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js +++ b/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js @@ -444,6 +444,7 @@ suite('Mirroring events', function () { window.HTMLCanvasElement.prototype.getContext = () => ({ measureText: () => ({width: ''}), }); + this.clock = sinon.useFakeTimers(); window.requestAnimationFrame = (callback) => setTimeout(callback, 0); window.cancelAnimationFrame = (id) => clearTimeout(id); this.workspace = Blockly.inject('blocklyDiv', { @@ -456,6 +457,8 @@ suite('Mirroring events', function () { teardown(function () { this.minimap.dispose(); this.workspace.dispose(); + this.clock.runAll(); + sinon.restore(); this.jsdomCleanup(); }); @@ -463,10 +466,9 @@ suite('Mirroring events', function () { const variable = this.workspace.getVariableMap().createVariable('a'); const block = this.workspace.newBlock('variables_set'); block.getField('VAR').setValue(variable.getId()); - await new Promise((resolve) => setTimeout(resolve, 0)); this.workspace.getVariableMap().renameVariable(variable, 'b'); - await new Promise((resolve) => setTimeout(resolve, 0)); + this.clock.tick(1); const minimapBlock = this.minimap.minimapWorkspace.getBlockById(block.id); assert.equal( From a84582e49160e5c9fda3c91acaa4ca4ef30c3974 Mon Sep 17 00:00:00 2001 From: lizschwab Date: Tue, 11 Aug 2026 09:11:06 -0700 Subject: [PATCH 2/2] chore: removed async --- packages/plugins/workspace-minimap/test/minimap_tests.mocha.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js b/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js index be604f3cb91..37f60ac6726 100644 --- a/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js +++ b/packages/plugins/workspace-minimap/test/minimap_tests.mocha.js @@ -462,7 +462,7 @@ suite('Mirroring events', function () { this.jsdomCleanup(); }); - test('Renaming a variable updates the minimap', async function () { + test('Renaming a variable updates the minimap', function () { const variable = this.workspace.getVariableMap().createVariable('a'); const block = this.workspace.newBlock('variables_set'); block.getField('VAR').setValue(variable.getId());