service: extract status handling to fix too-many-branches linter error

All status-related logic (errors and unexpected-2xx warnings) is consolidated
into _handle_function_import_response_status, resolving the pylint R0912 violation.

Author: phanak-sap

pyodata/v2/service.py

@@ -1659,52 +1659,52 @@ def __getattr__(self, name):
 
         fimport = self._service.schema.function_import(name)
 
-        def function_import_handler(fimport, response):
-            """Get function call response from HTTP Response"""
-
+        def _handle_function_import_response_status(fimport, response):
+            # errors — raise on any non-2xx response
             if 300 <= response.status_code < 400:
                 raise HttpError(f'Function Import {fimport.name} requires Redirection which is not supported',
                                 response)
-
             if response.status_code == 401:
                 raise HttpError(f'Not authorized to call Function Import {fimport.name}',
                                 response)
-
             if response.status_code == 403:
                 raise HttpError(f'Missing privileges to call Function Import {fimport.name}',
                                 response)
-
             if response.status_code == 405:
                 raise HttpError(
                     f'Despite definition Function Import {fimport.name} does not support HTTP {fimport.http_method}',
                     response)
-
             if 400 <= response.status_code < 500:
                 raise HttpError(
                     f'Function Import {fimport.name} call has failed with status code {response.status_code}',
                     response)
-
             if response.status_code >= 500:
                 raise HttpError(f'Server has encountered an error while processing Function Import {fimport.name}',
                                 response)
 
+            # warnings — unexpected 2xx codes
             if fimport.return_type is None:
                 if response.status_code != 204:
                     logging.getLogger(LOGGER_NAME).warning(
                         'The No Return Function Import %s has replied with HTTP Status Code %d instead of 204',
                         fimport.name, response.status_code)
+            elif response.status_code != 200:
+                logging.getLogger(LOGGER_NAME).warning(
+                    'The Function Import %s has replied with HTTP Status Code %d instead of 200',
+                    fimport.name, response.status_code)
+
+        def function_import_handler(fimport, response):
+            """Get function call response from HTTP Response"""
+
+            _handle_function_import_response_status(fimport, response)
 
+            if fimport.return_type is None:
                 if response.text:
                     logging.getLogger(LOGGER_NAME).warning(
                         'The No Return Function Import %s has returned content:\n%s', fimport.name, response.text)
 
                 return None
 
-            if response.status_code != 200:
-                logging.getLogger(LOGGER_NAME).warning(
-                    'The Function Import %s has replied with HTTP Status Code %d instead of 200',
-                    fimport.name, response.status_code)
-
             response_data = response.json()['d']
 
             # 1. if return type is an entity type or collection, resolve the entity set once