From a013dbb86830f4bbc2a25332a61cbd4343298fc0 Mon Sep 17 00:00:00 2001 From: Jacob Ledbetter Date: Wed, 26 Aug 2026 22:03:27 -0600 Subject: [PATCH 1/2] fix(clang-tidy): Accept both slashes so we can get the header diagnostics on Windows and Unix Signed-off-by: Jacob Ledbetter --- .clang-tidy | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 69fe82afafb..11df5313317 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -87,8 +87,10 @@ Checks: > # Treat warnings as errors for CI/CD WarningsAsErrors: false -# Header filter to include project headers -HeaderFilterRegex: '(Core|Generals|GeneralsMD|Dependencies)/.*\.(h|hpp)$' +# Header filter to include project headers. +# Accept both / and \ so Windows diagnostics (Core\Include\Common/Foo.h) are not dropped. +HeaderFilterRegex: '[/\\](Core|GeneralsMD|Generals|Dependencies)[/\\].*\.(h|hpp)$' +ExcludeHeaderFilterRegex: '[/\\](MaxSDK|_deps)[/\\]' # Check options for specific rules CheckOptions: From d133bf19d3dd5d1156b60b9fe646c06c8e2c214a Mon Sep 17 00:00:00 2001 From: Jacob Ledbetter Date: Wed, 26 Aug 2026 22:11:46 -0600 Subject: [PATCH 2/2] fix(clang-tidy): Match relative header paths in HeaderFilterRegex Require slash-or-start before Core/Generals/Dependencies so both Core\Include\Foo.h and ...\Core\Include\Foo.h match. The previous pattern required a separator before the project root and dropped relative Windows and Unix paths. Co-authored-by: Cursor --- .clang-tidy | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 11df5313317..135f35e4664 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -88,9 +88,10 @@ Checks: > WarningsAsErrors: false # Header filter to include project headers. -# Accept both / and \ so Windows diagnostics (Core\Include\Common/Foo.h) are not dropped. -HeaderFilterRegex: '[/\\](Core|GeneralsMD|Generals|Dependencies)[/\\].*\.(h|hpp)$' -ExcludeHeaderFilterRegex: '[/\\](MaxSDK|_deps)[/\\]' +# Match relative paths (Core/Foo.h, Core\Foo.h) and absolute ones (.../Core/Foo.h). +# Accept both / and \ so Windows diagnostics are not dropped. +HeaderFilterRegex: '(^|[/\\])(Core|GeneralsMD|Generals|Dependencies)[/\\].*\.(h|hpp)$' +ExcludeHeaderFilterRegex: '(^|[/\\])(MaxSDK|_deps)[/\\]' # Check options for specific rules CheckOptions: