From 3c8f18083c6f9c3ae1fd742366a7dc49e1302c7c Mon Sep 17 00:00:00 2001 From: morningman Date: Thu, 6 Aug 2026 16:34:19 +0800 Subject: [PATCH] [fix](fe) give ConfField.description a single string in the streaming-job config master does not compile. fe-common fails at Config.java:[1177,65] annotation value not of an allowable type #66342 retyped ConfigBase.ConfField.description() from String[] to String and rewrote all 419 call sites accordingly. #66238 landed shortly after with @ConfField(mutable = true, masterOnly = true, description = { "Minimum interval in seconds between snapshot offset persistence operations"}) written against the older String[] signature. The two are textually disjoint, so git merges them without a conflict and neither pull request could see the other: each was green on its own base. The seven further errors in the same module are secondary. The bad annotation value aborts the annotation-processing round, so lombok never contributes its generated members, and @Slf4j's log plus @AllArgsConstructor/@Data's constructors go missing: DiskUtils.java:[70,13] cannot find symbol JobBaseConfig ... constructor cannot be applied to given types AbstractSourceSplit ... constructor cannot be applied to given types All seven disappear once the annotation value is fixed; nothing else in the tree needed a change. This is the only remaining array-form description in fe/ (grep -rnE 'description\s*=\s*\{'), and the wrapped-argument layout matches the neighbouring long descriptions such as max_create_table_timeout_second. ConfigTest.testConfFieldDescriptionsAreEnglishStrings, the guard #66342 added, reflects over the annotation at runtime and so cannot catch a compile-time signature mismatch; it passes here because the text is already English. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01S73AWq9AHxYfKkzWJfTcKs --- .../src/main/java/org/apache/doris/common/Config.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java index 114112d9e58523..af7d3a434082e1 100644 --- a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java +++ b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java @@ -1174,8 +1174,8 @@ public class Config extends ConfigBase { @ConfField(mutable = true, masterOnly = true) public static int streaming_task_min_timeout_sec = 300; - @ConfField(mutable = true, masterOnly = true, description = { - "Minimum interval in seconds between snapshot offset persistence operations"}) + @ConfField(mutable = true, masterOnly = true, + description = "Minimum interval in seconds between snapshot offset persistence operations") public static int streaming_job_snapshot_offset_persist_interval_sec = 300; @ConfField(mutable = true, masterOnly = true)