From a3c363954188723cbac050faf2d268cf4d0fbcf3 Mon Sep 17 00:00:00 2001 From: Yang Zhang Date: Sat, 12 Sep 2026 20:44:52 -0700 Subject: [PATCH] feat(config): turn the Form View on by default Every piece of the Form View (parent issue #8011) has landed behind form-view-enabled = false. Flip the default to true, with the GuiConfigSpec assertion updated to match. GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED=false turns it off for a deployment. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY --- common/config/src/main/resources/gui.conf | 2 +- .../scala/org/apache/texera/common/config/GuiConfigSpec.scala | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common/config/src/main/resources/gui.conf b/common/config/src/main/resources/gui.conf index b49cc348ddd..509ec6ebdc3 100644 --- a/common/config/src/main/resources/gui.conf +++ b/common/config/src/main/resources/gui.conf @@ -86,7 +86,7 @@ gui { timetravel-enabled = ${?GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED} # whether the Form View (a second, form-based view of a workflow) is enabled - form-view-enabled = false + form-view-enabled = true form-view-enabled = ${?GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED} # Whether to connect to local or production shared editing server. Set to true if you have diff --git a/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala b/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala index 45e4adecd40..c6aab016c05 100644 --- a/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala +++ b/common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala @@ -59,9 +59,9 @@ class GuiConfigSpec extends AnyFlatSpec with Matchers { ifUnset("GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED")( GuiConfig.guiWorkflowWorkspaceTimetravelEnabled shouldBe false ) - // Form View ships disabled so merging the feature never turns it on; the final PR flips it. + // Form View is on by default now that the whole feature has landed. ifUnset("GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED")( - GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe false + GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe true ) ifUnset("GUI_WORKFLOW_WORKSPACE_PRODUCTION_SHARED_EDITING_SERVER")( GuiConfig.guiWorkflowWorkspaceProductionSharedEditingServer shouldBe false