Missing proxy support through FCM

[lucarosty]

Unlike the GCM and APN sections, the FCM section doesn't support the use of proxies. This can be resolved simply by adding this line of code (httpAgent: settings.fcm.httpAgent) to the sendFCM.js file at line 83, where the opts variable is configured.

[alex-friedl]

@lucarosty Thanks for reporting this. Could you test dev/bump-firebase-remove-gcm (#227) and let me know if the httpAgent setting is working as expected for you on that branch? See https://github.com/appfeel/node-pushnotifications/blob/dev/bump-firebase-remove-gcm/README.md#network-proxy-sdk-level

[lucarosty]

Thanks for the flags in the configuration.
The only suggestion that I can do is to remove the httpsAgent because from the firebase documentation is not an available options.
In your documentation you are right when you use HttpsProxyAgent module but it should be put in the httpAgent.
Another little change to do is the proxy in the credential object. If you do not set explicitly that parameter the authentication call done before sending the push notification messages will not pass though the proxy

[alex-friedl]

@lucarosty Thanks for the feedback. I tried to incoporate it in the latest commit on that branch. Could you check it out when you get the time?

Also, do you actually need support for enableLegacyHttpTransport ? It is already deprecated in the current firebase admin SDK

[alex-friedl]

@lucarosty Any update from your end?

[alex-friedl]

@lucarosty Do you still need this or can we close the issue and PRs ?

[lucarosty]

@alex-friedl: sorry for be disappeared for months but I've not have the time to test the change. I think if I remember well that the flag enableLegacyHttpTransport was the only way to use proxies.