From 4de5bb147c18b315e6be60a7c9f37ad3e14951a1 Mon Sep 17 00:00:00 2001
From: samuelburnham <45365069+samuelburnham@users.noreply.github.com>
Date: Mon, 24 Aug 2026 14:56:34 -0400
Subject: [PATCH] ci: Use `client-id` for the GitHub App token

`actions/create-github-app-token@v3` renamed `app-id` to `client-id` and
attached a deprecation message to the old name, which every run that mints
a token now prints as a warning. The input is passed straight through to
`@octokit/auth-app` as `appId`, which accepts an App ID or a client ID, so
the existing `TOKEN_APP_ID` secret works unchanged and callers need no
update.

actionlint's bundled metadata for the action predates the rename, so it
reports `client-id` as unknown and `app-id` as missing. Filter those two
messages in `actionlint.yaml` until it refreshes; the patterns name the
action, so a genuine typo in either input is still caught.
---
 .github/actionlint.yaml         | 10 ++++++++++
 .github/workflows/repo-sync.yml |  2 +-
 .github/workflows/typos.yml     |  2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml
index 7a9720b..19b051f 100644
--- a/.github/actionlint.yaml
+++ b/.github/actionlint.yaml
@@ -3,3 +3,13 @@ self-hosted-runner:
   labels:
     - gpu-bench
     - gpu-ci
+
+paths:
+  .github/workflows/**/*.{yml,yaml}:
+    ignore:
+      # `actions/create-github-app-token@v3` renamed `app-id` to `client-id`
+      # and deprecated the former. actionlint's bundled metadata for the action
+      # predates the rename, so it reports the new input as unknown and the
+      # deprecated one as missing. Drop these once actionlint refreshes it.
+      - 'input "client-id" is not defined in action "actions/create-github-app-token'
+      - 'missing input "app-id" which is required by action "actions/create-github-app-token'
diff --git a/.github/workflows/repo-sync.yml b/.github/workflows/repo-sync.yml
index d89de06..4eca8e0 100644
--- a/.github/workflows/repo-sync.yml
+++ b/.github/workflows/repo-sync.yml
@@ -32,7 +32,7 @@ jobs:
     - uses: actions/create-github-app-token@v3
       id: generate-token
       with:
-        app-id: ${{ secrets.TOKEN_APP_ID }}
+        client-id: ${{ secrets.TOKEN_APP_ID }}
         private-key: ${{ secrets.TOKEN_APP_PRIVATE_KEY }}
         permission-contents: write
         permission-workflows: write
diff --git a/.github/workflows/typos.yml b/.github/workflows/typos.yml
index cc035a5..209ec20 100644
--- a/.github/workflows/typos.yml
+++ b/.github/workflows/typos.yml
@@ -54,7 +54,7 @@ jobs:
         if: steps.typo-check.outputs.typos == 'true'
         id: generate-token
         with:
-          app-id: ${{ secrets.TOKEN_APP_ID }}
+          client-id: ${{ secrets.TOKEN_APP_ID }}
           private-key: ${{ secrets.TOKEN_APP_PRIVATE_KEY }}
           permission-contents: write
           permission-pull-requests: write