From d4d4ed107ba670402c207df00303e88ea408f070 Mon Sep 17 00:00:00 2001 From: Missy Messa Date: Tue, 1 Sep 2026 17:25:44 -0700 Subject: [PATCH] Remove orphaned SDK validation path Delete the unused validation template and package-source update wrappers that depended on BotAccount-dotnet-maestro-bot-PAT. No enabled install-scripts pipeline targets or includes this path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c08e3391-52d8-42e3-ad8c-ef2e5be92291 --- eng/update-packagesource.cmd | 2 - eng/update-packagesource.ps1 | 86 ------------------------------------ eng/validate-sdk.yml | 46 ------------------- 3 files changed, 134 deletions(-) delete mode 100644 eng/update-packagesource.cmd delete mode 100644 eng/update-packagesource.ps1 delete mode 100644 eng/validate-sdk.yml diff --git a/eng/update-packagesource.cmd b/eng/update-packagesource.cmd deleted file mode 100644 index c12187983f..0000000000 --- a/eng/update-packagesource.cmd +++ /dev/null @@ -1,2 +0,0 @@ -@echo off -powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0update-packagesource.ps1""" %*" diff --git a/eng/update-packagesource.ps1 b/eng/update-packagesource.ps1 deleted file mode 100644 index 1bf294ef0c..0000000000 --- a/eng/update-packagesource.ps1 +++ /dev/null @@ -1,86 +0,0 @@ -Param( - [string] $barToken, - [string] $gitHubPat, - [string] $packagesSource -) - -$ErrorActionPreference = "Stop" -. $PSScriptRoot\common\tools.ps1 - -# Batch and executable files exit and define $LASTEXITCODE. Powershell commands exit and define $? -function CheckExitCode ([string]$stage, [bool]$commandExitCode = $True) -{ - $exitCode = 0 - if($commandExitCode -eq -$False) { - $exitCode = 1 - } - else { - if ( Test-Path "LASTEXITCODE" -ErrorAction SilentlyContinue) - { - $exitCode = $LASTEXITCODE - } - } - - if ($exitCode -ne 0) { - Write-PipelineTelemetryError -Category "UpdatePackageSource" -Message "Something failed in stage: '$stage'. Check for errors above. Exiting now with exit code $exitCode..." - ExitWithExitCode $exitCode - } -} - -function StopDotnetIfRunning -{ - $dotnet = Get-Process "dotnet" -ErrorAction SilentlyContinue - if ($dotnet) { - stop-process $dotnet - } -} - -function AddSourceToNugetConfig([string]$nugetConfigPath, [string]$source) -{ - Write-Host "Adding '$source' to '$nugetConfigPath'..." - $nugetConfig = New-Object XML - $nugetConfig.PreserveWhitespace = $true - $nugetConfig.Load($nugetConfigPath) - $packageSources = $nugetConfig.SelectSingleNode("//packageSources") - $keyAttribute = $nugetConfig.CreateAttribute("key") - $keyAttribute.Value = "arcade-local" - $valueAttribute = $nugetConfig.CreateAttribute("value") - $valueAttribute.Value = $source - $newSource = $nugetConfig.CreateElement("add") - $newSource.Attributes.Append($keyAttribute) | Out-Null - $newSource.Attributes.Append($valueAttribute) | Out-Null - $packageSources.AppendChild($newSource) | Out-Null - $nugetConfig.Save($nugetConfigPath) -} - -try { - Push-Location $PSScriptRoot - $nugetConfigPath = Join-Path $RepoRoot "NuGet.config" - - Write-Host "Adding local source to NuGet.config" - AddSourceToNugetConfig $nugetConfigPath $packagesSource - CheckExitCode "Adding source to NuGet.config" $? - - Write-Host "Updating dependencies using Darc..." - $dotnetRoot = InitializeDotNetCli -install:$true - $DarcExe = "$dotnetRoot\tools" - Create-Directory $DarcExe - $DarcExe = Resolve-Path $DarcExe - . .\common\darc-init.ps1 -toolpath $DarcExe - CheckExitCode "Running darc-init" - - $Env:dotnet_root = $dotnetRoot - & $DarcExe\darc.exe update-dependencies --packages-folder $packagesSource --password $barToken --github-pat $gitHubPat --channel ".NET Tools - Latest" - CheckExitCode "Updating dependencies" -} -catch { - Write-Host $_.ScriptStackTrace - Write-PipelineTelemetryError -Category "UpdatePackageSource" -Message $_ - ExitWithExitCode 1 -} -finally { - Write-Host "Cleaning up workspace..." - StopDotnetIfRunning - Pop-Location -} -ExitWithExitCode 0 \ No newline at end of file diff --git a/eng/validate-sdk.yml b/eng/validate-sdk.yml deleted file mode 100644 index b86ee284f0..0000000000 --- a/eng/validate-sdk.yml +++ /dev/null @@ -1,46 +0,0 @@ -parameters: - buildArgs: '' - validateBlobFeedUrl: https://dotnetfeed.blob.core.windows.net/dotnet-core-test/index.json - buildConfig: Release - -jobs: -- template: /eng/common/templates/job/job.yml - parameters: - name: ValidateArcadeSDK - displayName: Validate Arcade SDK - enableMicrobuild: true - artifacts: - download: - path: build_stage_artifacts - publish: - artifacts: - name: Artifacts_ValidateSdk_Windows_NT_Release - logs: - name: Logs_ValidateSdk_Windows_NT_Release - timeoutInMinutes: 90 - pool: - name: NetCore1ESPool-Internal - demands: ImageOverride -equals Build.Server.Amd64.VS2017 - variables: - - group: DotNet-Maestro - - _BuildConfig: ${{ parameters.buildConfig }} - - _BuildArgs: ${{ parameters.buildArgs }} - - _ValidateBlobFeedUrl: ${{ parameters.validateBlobFeedUrl }} - preSteps: - - checkout: self - clean: true - steps: - - task: AzureCLI@2 - displayName: Update package source - inputs: - azureSubscription: "Darc: Maestro Production" - scriptType: ps - scriptLocation: inlineScript - inlineScript: > - .\eng\update-packagesource.ps1 - -gitHubPat $(BotAccount-dotnet-maestro-bot-PAT) - -packagesSource $(Build.SourcesDirectory)/build_stage_artifacts - - script: eng\common\cibuild.cmd - $(_BuildArgs) - /p:DotNetPublishBlobFeedUrl=$(_ValidateBlobFeedUrl) - displayName: Build / Validate