refactor: Name the response threshold for what it measures

minimumGzipResponseBytes becomes minCompressibleResponseBytes, and
ResponseRenderer.DEFAULT_MINIMUM_GZIP_BYTES becomes
DEFAULT_MIN_COMPRESSIBLE_BYTES.

The threshold is compared against the uncompressed body before any
coding is chosen, so it neither depends on gzip nor measures a
compressed size. "Compressible" says what it does: a body smaller than
this is not worth coding. It now mirrors maxDecompressedRequestBytes -
min and max, and both measure plain bytes.

Neither name has been released, and every push to master publishes to
Maven Central, so this is the last point at which the rename is free
rather than a breaking change to a public builder method.

Author: thced

README.md

@@ -497,7 +497,7 @@ coded, and neither is `text/event-stream`, which has to stay unbuffered.
 OpenApiServer.builder()
     .spec(spec)
     .handlers(handlers)
-    .minimumGzipResponseBytes(4096)  // raises the 1 KiB default; 0 compresses every eligible body
+    .minCompressibleResponseBytes(4096)  // raises the 1 KiB default; 0 compresses every eligible body
     .build();
 ```
 

src/main/java/com/retailsvc/http/OpenApiServer.java

@@ -246,7 +246,7 @@ public static final class Builder {
     private final Map<String, SchemeValidator> securityValidators = new LinkedHashMap<>();
     private boolean externalAuth = false;
     private long maxDecompressedRequestBytes = RequestBodyReader.DEFAULT_MAX_DECOMPRESSED_BYTES;
-    private long minimumGzipResponseBytes = ResponseRenderer.DEFAULT_MINIMUM_GZIP_BYTES;
+    private long minCompressibleResponseBytes = ResponseRenderer.DEFAULT_MIN_COMPRESSIBLE_BYTES;
     private final List<SpecBinding> bindings = new ArrayList<>();
 
     private Builder() {}
@@ -409,17 +409,18 @@ public Builder maxDecompressedRequestBytes(long maxDecompressedRequestBytes) {
     }
 
     /**
-     * Smallest response body worth gzipping, 1 KiB by default. Below this, the coding costs more
+     * Smallest response body worth compressing, 1 KiB by default. Below this, the coding costs more
      * than it saves. Set it to 0 to compress every compressible body, or high enough to exceed any
      * response this server produces to stop compressing altogether — useful when a proxy in front
      * already terminates compression.
      */
-    public Builder minimumGzipResponseBytes(long minimumGzipResponseBytes) {
-      if (minimumGzipResponseBytes < 0) {
+    public Builder minCompressibleResponseBytes(long minCompressibleResponseBytes) {
+      if (minCompressibleResponseBytes < 0) {
         throw new IllegalArgumentException(
-            "minimumGzipResponseBytes must be non-negative, got " + minimumGzipResponseBytes);
+            "minCompressibleResponseBytes must be non-negative, got "
+                + minCompressibleResponseBytes);
       }
-      this.minimumGzipResponseBytes = minimumGzipResponseBytes;
+      this.minCompressibleResponseBytes = minCompressibleResponseBytes;
       return this;
     }
 
@@ -471,7 +472,7 @@ public OpenApiServer build() throws IOException {
               externalAuth,
               List.copyOf(afterHooks),
               new RequestBodyReader(maxDecompressedRequestBytes),
-              new ResponseRenderer(resolved, minimumGzipResponseBytes));
+              new ResponseRenderer(resolved, minCompressibleResponseBytes));
       int resolvedPort = resolvePort();
       SSLContext sslContext =
           httpsCertChain != null ? PemSslContext.load(httpsCertChain, httpsPrivateKey) : null;

src/main/java/com/retailsvc/http/internal/ResponseRenderer.java

@@ -19,8 +19,8 @@
 /** Writes a {@link Response} to an {@link HttpExchange}. */
 public final class ResponseRenderer {
 
-  /** Default smallest body worth gzipping: 1 KiB. */
-  public static final long DEFAULT_MINIMUM_GZIP_BYTES = 1024;
+  /** Default smallest body worth compressing: 1 KiB. */
+  public static final long DEFAULT_MIN_COMPRESSIBLE_BYTES = 1024;
 
   private static final String CONTENT_TYPE = "Content-Type";
   private static final String CONTENT_ENCODING = "Content-Encoding";
@@ -34,11 +34,11 @@ public final class ResponseRenderer {
   private static final String OCTET_STREAM = "application/octet-stream";
 
   private final Map<String, TypeMapper> mappers;
-  private final long minimumGzipBytes;
+  private final long minCompressibleBytes;
 
-  public ResponseRenderer(Map<String, TypeMapper> mappers, long minimumGzipBytes) {
+  public ResponseRenderer(Map<String, TypeMapper> mappers, long minCompressibleBytes) {
     this.mappers = Map.copyOf(mappers);
-    this.minimumGzipBytes = minimumGzipBytes;
+    this.minCompressibleBytes = minCompressibleBytes;
   }
 
   public void render(HttpExchange exchange, Response response) throws IOException {
@@ -112,7 +112,7 @@ private boolean shouldCompress(
       return false;
     }
     addVary(headers);
-    return (length < 0 || length >= minimumGzipBytes) && acceptsGzip(exchange);
+    return (length < 0 || length >= minCompressibleBytes) && acceptsGzip(exchange);
   }
 
   /** The length a handler declared for a body it did not write, or -1 when absent or unreadable. */

src/test/java/com/retailsvc/http/OpenApiServerBuilderTest.java

@@ -71,10 +71,10 @@ void rejectsOversizedMaxDecompressedRequestBytes() {
   }
 
   @Test
-  void rejectsNegativeMinimumGzipResponseBytes() {
+  void rejectsNegativeMinCompressibleResponseBytes() {
     OpenApiServer.Builder b = OpenApiServer.builder();
 
-    assertThatThrownBy(() -> b.minimumGzipResponseBytes(-1))
+    assertThatThrownBy(() -> b.minCompressibleResponseBytes(-1))
         .isInstanceOf(IllegalArgumentException.class)
         .hasMessageContaining("-1");
   }
@@ -83,7 +83,7 @@ void rejectsNegativeMinimumGzipResponseBytes() {
   void acceptsContentCodingLimits() {
     OpenApiServer.Builder b = OpenApiServer.builder();
 
-    assertThat(b.maxDecompressedRequestBytes(4096).minimumGzipResponseBytes(0)).isSameAs(b);
+    assertThat(b.maxDecompressedRequestBytes(4096).minCompressibleResponseBytes(0)).isSameAs(b);
   }
 
   @Test

src/test/java/com/retailsvc/http/internal/DispatchHandlerTest.java

@@ -1,6 +1,6 @@
 package com.retailsvc.http.internal;
 
-import static com.retailsvc.http.internal.ResponseRenderer.DEFAULT_MINIMUM_GZIP_BYTES;
+import static com.retailsvc.http.internal.ResponseRenderer.DEFAULT_MIN_COMPRESSIBLE_BYTES;
 import static java.net.HttpURLConnection.HTTP_INTERNAL_ERROR;
 import static java.net.HttpURLConnection.HTTP_OK;
 import static org.assertj.core.api.Assertions.assertThat;
@@ -46,7 +46,10 @@ private static HttpExchange stubExchange() {
 
   private static DispatchHandler dispatcher(Map<String, RequestHandler> handlers) {
     return new DispatchHandler(
-        handlers, List.of(), List.of(), new ResponseRenderer(Map.of(), DEFAULT_MINIMUM_GZIP_BYTES));
+        handlers,
+        List.of(),
+        List.of(),
+        new ResponseRenderer(Map.of(), DEFAULT_MIN_COMPRESSIBLE_BYTES));
   }
 
   private static DispatchHandler dispatcher(
@@ -57,7 +60,7 @@ private static DispatchHandler dispatcher(
         handlers,
         interceptors,
         decorators,
-        new ResponseRenderer(Map.of(), DEFAULT_MINIMUM_GZIP_BYTES));
+        new ResponseRenderer(Map.of(), DEFAULT_MIN_COMPRESSIBLE_BYTES));
   }
 
   private static void withRequest(String operationId, ScopedValue.CallableOp<Void, Exception> body)

src/test/java/com/retailsvc/http/internal/ExtrasRouterTest.java

@@ -1,6 +1,6 @@
 package com.retailsvc.http.internal;
 
-import static com.retailsvc.http.internal.ResponseRenderer.DEFAULT_MINIMUM_GZIP_BYTES;
+import static com.retailsvc.http.internal.ResponseRenderer.DEFAULT_MIN_COMPRESSIBLE_BYTES;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.mockito.Mockito.mock;
@@ -146,7 +146,7 @@ private static ExtrasRouter newRouter(Map<String, RequestHandler> extras) {
     Map<String, TypeMapper> mappers = Map.of("application/json", new GsonTypeMapper());
     return new ExtrasRouter(
         extras,
-        new ResponseRenderer(mappers, DEFAULT_MINIMUM_GZIP_BYTES),
+        new ResponseRenderer(mappers, DEFAULT_MIN_COMPRESSIBLE_BYTES),
         new RequestBodyReader(RequestBodyReader.DEFAULT_MAX_DECOMPRESSED_BYTES));
   }
 

src/test/java/com/retailsvc/http/internal/RequestPreparationFilterTest.java

@@ -1,6 +1,6 @@
 package com.retailsvc.http.internal;
 
-import static com.retailsvc.http.internal.ResponseRenderer.DEFAULT_MINIMUM_GZIP_BYTES;
+import static com.retailsvc.http.internal.ResponseRenderer.DEFAULT_MIN_COMPRESSIBLE_BYTES;
 import static java.net.HttpURLConnection.HTTP_UNSUPPORTED_TYPE;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -118,7 +118,7 @@ public byte[] writeTo(Object value) {
         new DefaultValidator(spec::resolveSchema),
         mappers,
         rethrow,
-        new ResponseRenderer(mappers, DEFAULT_MINIMUM_GZIP_BYTES),
+        new ResponseRenderer(mappers, DEFAULT_MIN_COMPRESSIBLE_BYTES),
         List.of(),
         new RequestBodyReader(RequestBodyReader.DEFAULT_MAX_DECOMPRESSED_BYTES));
   }