Icon path incorrect.

[electricsteve]

Caught by veil, but still issue here. The icon path in mods.toml on 1.21.1 is invalid.

[18:09:25] [Worker-ResourceReload-2/ERROR] [Veil/]: Failed to load icon for pack: mod/create_tweaked_controllers
java.lang.IllegalArgumentException: Illegal segment .. in path [.., resources, logo.png]
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.FileUtil.validatePath(FileUtil.java:179) ~[client-1.21.1-20240808.144430-srg.jar%23377!/:?] {re:classloading,pl:connector_pre_launch:A}
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.packs.PathPackResources.getRootResource(PathPackResources.java:43) ~[client-1.21.1-20240808.144430-srg.jar%23377!/:?] {re:mixin,pl:connector_pre_launch:A,re:classloading,pl:mixin:APP:veil.neoforge.mixins.json:resources.PathPackResourcesMixin from mod veil,pl:mixin:APP:creativecore.mixins.json:PathPackResourcesAccessor from mod creativecore,pl:mixin:APP:modernfix-modernfix.mixins.json:perf.resourcepacks.PathPackResourcesMixin from mod modernfix,pl:mixin:A,pl:connector_pre_launch:A}
	at TRANSFORMER/minecraft@1.21.1/net.minecraft.server.packs.PathPackResources.veil$getIcon(PathPackResources.java:610) ~[client-1.21.1-20240808.144430-srg.jar%23377!/:?] {re:mixin,pl:connector_pre_launch:A,re:classloading,pl:mixin:APP:veil.neoforge.mixins.json:resources.PathPackResourcesMixin from mod veil,pl:mixin:APP:creativecore.mixins.json:PathPackResourcesAccessor from mod creativecore,pl:mixin:APP:modernfix-modernfix.mixins.json:perf.resourcepacks.PathPackResourcesMixin from mod modernfix,pl:mixin:A,pl:connector_pre_launch:A}
	at TRANSFORMER/veil@3.6.2/foundry.veil.impl.resource.VeilResourceManagerImpl.lambda$reloadClient$5(VeilResourceManagerImpl.java:177) ~[veil-neoforge-1.21.1-3.6.2.jar%23884!/:3.6.2] {re:classloading}
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[?:?] {}
	at java.base/java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411) ~[?:?] {}
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762) ~[?:?] {}
	at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276) ~[?:?] {}
	at java.base/java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(AbstractList.java:722) ~[?:?] {}
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] {}
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] {}
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[?:?] {}
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) ~[?:?] {}
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] {}
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?] {}
	at TRANSFORMER/veil@3.6.2/foundry.veil.impl.resource.VeilResourceManagerImpl.lambda$reloadClient$6(VeilResourceManagerImpl.java:170) ~[veil-neoforge-1.21.1-3.6.2.jar%23884!/:3.6.2] {re:classloading}
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) [?:?] {}
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) [?:?] {}
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387) [?:?] {}
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312) [?:?] {}
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843) [?:?] {re:mixin,re:computing_frames}
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808) [?:?] {re:mixin,re:computing_frames}
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188) [?:?] {re:mixin}

[getItemFromBlock]

The path was indeed invalid, but why would this cause an error with Veil? This does not produces any error without it hence why I didn't notice it

[electricsteve]

I have no idea 🤷

[electricsteve]

I see you fixed the issue, but haven't made a new release and closed this issue.

[getItemFromBlock]

I didn't got the time to make a release, there are still features that I need to finish adding and making a release takes quite some time. As for closing this, I usually close issues once an update with the fix has been published.