Skip to content

Commit 49f4967

Browse files
redsun82Copilot
andcommitted
Bazel skill: generated-target visibility is per-macro, not an invariant
Each macro picks whether its helper targets are private, package default or handed the caller's visibility. Keep the naming shapes as examples and the grep-the-suffix tip, drop the blanket claim. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 8565611 commit 49f4967

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/skills/bazel/SKILL.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@ debugging aid opts out and declares a plain `rust_binary` — see `swift-syntax-
5656
variable does the job.
5757

5858
Macros here are typically a thin public wrapper around a private rule (`codeql_csharp_binary`, `swift_cc_binary`). Keep
59-
the rule narrow and the ergonomics in the macro. Generated targets are named after the macro's `name` (`<name>-all`,
60-
`single_arch/<name>`, `internal/<name>`) and kept private; when an error names a target you cannot find in any source
61-
file, a macro minted it — grep the suffix under `misc/bazel/`.
59+
the rule narrow and the ergonomics in the macro. Each macro decorates the caller's `name` to mint its helper targets
60+
(`internal/<name>`, `single_arch/<name>`, `bin/<name>`), but the visibility they get is that macro's choice — private,
61+
package default, or the caller's own — so read it instead of assuming. When an error names a target you cannot find in
62+
any source file, a macro minted it — grep the suffix under `misc/bazel/`.
6263

6364
## Shared helpers
6465

0 commit comments

Comments
 (0)