Commit f5fa010
Add addContentTypeParser, drop after and ready, and date the change note in UTC
`addContentTypeParser` returns the server, so it belongs in the list. Its type
declaration says `void`, which is why it was missed: it is declared as a
property of an interface type rather than as a method, so it did not look like
the `set*` family.
Checking the rest of the instance against the runtime rather than against the
declarations then showed that `ready` never returns the server, in either of
its call forms, despite the declaration saying it does, and that `after`
returns it only when given a callback. Both are now excluded, which also makes
the predicate exactly what its name says. `onClose` returns the server too,
but it registers a hook, so it is excluded for the same reason as `addHook`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 2b19c84 commit f5fa010
4 files changed
Lines changed: 16 additions & 13 deletions
File tree
- javascript/ql
- lib
- change-notes
- semmle/javascript/frameworks
- test/query-tests/Security/CWE-770/MissingRateLimit
Lines changed: 14 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | | - | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| |||
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
56 | | - | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| 136 | + | |
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
| |||
0 commit comments