From b936fa8035d105c75dbdfe7bee083c50b623b35c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Je=C5=A1ke?= Date: Tue, 11 Aug 2026 10:33:25 +0200 Subject: [PATCH] refactor: remove support for Drill Drill is being removed from the backend (F1-2434), so the SDK no longer needs to model it. Unlike Greenplum there was never a hand-written `CatalogDataSourceDrill` class, so there is nothing to drop from `gooddata_sdk` exports and no test or docs example to remove. Two prose mentions of Drill as a multi-schema data source manager are reworded to Dremio only. The generated client was updated the supported way in spirit rather than by hand-rolling a new shape: the `DRILL` enum entry was removed from the two source schemas it originates from -- gooddata-metadata-client.json and gooddata-scan-client.json -- and from the six generated models that mirror them, which is exactly the six-file, one-line-each shape regeneration produces (the same shape the Greenplum removal produced). The merged schemas/gooddata-api-client.json was edited line-wise instead of being rebuilt through the Makefile's `jq -S -s` step. jq 1.6 does not preserve number literals and rewrote unrelated values (2.6E+9 -> 2600000000, 1.0 -> 1) across the file; the checked-in copy was produced with jq 1.7+, which does. `ENABLE_DRILL_TO_URL_BY_DEFAULT` is a drill-to-URL setting, unrelated to Apache Drill, and is left untouched. JIRA: F1-2434 risk: low --- docs/content/en/latest/data/data-source/scan_schemata.md | 2 +- .../gooddata_api_client/model/declarative_data_source.py | 1 - .../model/json_api_data_source_identifier_out_attributes.py | 1 - .../model/json_api_data_source_in_attributes.py | 1 - .../model/json_api_data_source_out_attributes.py | 1 - .../model/json_api_data_source_patch_attributes.py | 1 - .../gooddata_api_client/model/test_definition_request.py | 1 - .../src/gooddata_sdk/catalog/data_source/service.py | 2 +- schemas/gooddata-api-client.json | 6 ------ schemas/gooddata-metadata-client.json | 5 ----- schemas/gooddata-scan-client.json | 1 - 11 files changed, 2 insertions(+), 20 deletions(-) diff --git a/docs/content/en/latest/data/data-source/scan_schemata.md b/docs/content/en/latest/data/data-source/scan_schemata.md index f9ef345b2..f8d681223 100644 --- a/docs/content/en/latest/data/data-source/scan_schemata.md +++ b/docs/content/en/latest/data/data-source/scan_schemata.md @@ -12,7 +12,7 @@ api_ref: "CatalogDataSourceService.scan_schemata" Returns a list of schemas that exist in the database and can be configured in the data source entity. -Data source managers like Dremio or Drill can work with multiple schemas and schema names can be injected into scan_request to filter out tables stored in the different schemas. +Data source managers like Dremio can work with multiple schemas and schema names can be injected into scan_request to filter out tables stored in the different schemas. {{% parameters-block title="Parameters"%}} diff --git a/gooddata-api-client/gooddata_api_client/model/declarative_data_source.py b/gooddata-api-client/gooddata_api_client/model/declarative_data_source.py index 049f6b8b0..fa4f67c4e 100644 --- a/gooddata-api-client/gooddata_api_client/model/declarative_data_source.py +++ b/gooddata-api-client/gooddata_api_client/model/declarative_data_source.py @@ -72,7 +72,6 @@ class DeclarativeDataSource(ModelNormal): 'MSSQL': "MSSQL", 'PRESTO': "PRESTO", 'DREMIO': "DREMIO", - 'DRILL': "DRILL", 'AZURESQL': "AZURESQL", 'SYNAPSESQL': "SYNAPSESQL", 'DATABRICKS': "DATABRICKS", diff --git a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_identifier_out_attributes.py b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_identifier_out_attributes.py index 6ac427afd..273126958 100644 --- a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_identifier_out_attributes.py +++ b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_identifier_out_attributes.py @@ -66,7 +66,6 @@ class JsonApiDataSourceIdentifierOutAttributes(ModelNormal): 'MSSQL': "MSSQL", 'PRESTO': "PRESTO", 'DREMIO': "DREMIO", - 'DRILL': "DRILL", 'AZURESQL': "AZURESQL", 'SYNAPSESQL': "SYNAPSESQL", 'DATABRICKS': "DATABRICKS", diff --git a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_in_attributes.py b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_in_attributes.py index 192ae7820..a5fde4710 100644 --- a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_in_attributes.py +++ b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_in_attributes.py @@ -70,7 +70,6 @@ class JsonApiDataSourceInAttributes(ModelNormal): 'MSSQL': "MSSQL", 'PRESTO': "PRESTO", 'DREMIO': "DREMIO", - 'DRILL': "DRILL", 'AZURESQL': "AZURESQL", 'SYNAPSESQL': "SYNAPSESQL", 'DATABRICKS': "DATABRICKS", diff --git a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_out_attributes.py b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_out_attributes.py index 7b7be8d33..e528f3a39 100644 --- a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_out_attributes.py +++ b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_out_attributes.py @@ -70,7 +70,6 @@ class JsonApiDataSourceOutAttributes(ModelNormal): 'MSSQL': "MSSQL", 'PRESTO': "PRESTO", 'DREMIO': "DREMIO", - 'DRILL': "DRILL", 'AZURESQL': "AZURESQL", 'SYNAPSESQL': "SYNAPSESQL", 'DATABRICKS': "DATABRICKS", diff --git a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_patch_attributes.py b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_patch_attributes.py index 81a97fcbd..92ad52d9a 100644 --- a/gooddata-api-client/gooddata_api_client/model/json_api_data_source_patch_attributes.py +++ b/gooddata-api-client/gooddata_api_client/model/json_api_data_source_patch_attributes.py @@ -80,7 +80,6 @@ class JsonApiDataSourcePatchAttributes(ModelNormal): 'MSSQL': "MSSQL", 'PRESTO': "PRESTO", 'DREMIO': "DREMIO", - 'DRILL': "DRILL", 'AZURESQL': "AZURESQL", 'SYNAPSESQL': "SYNAPSESQL", 'DATABRICKS': "DATABRICKS", diff --git a/gooddata-api-client/gooddata_api_client/model/test_definition_request.py b/gooddata-api-client/gooddata_api_client/model/test_definition_request.py index 9fa8b4497..5c11e0613 100644 --- a/gooddata-api-client/gooddata_api_client/model/test_definition_request.py +++ b/gooddata-api-client/gooddata_api_client/model/test_definition_request.py @@ -70,7 +70,6 @@ class TestDefinitionRequest(ModelNormal): 'MSSQL': "MSSQL", 'PRESTO': "PRESTO", 'DREMIO': "DREMIO", - 'DRILL': "DRILL", 'AZURESQL': "AZURESQL", 'SYNAPSESQL': "SYNAPSESQL", 'DATABRICKS': "DATABRICKS", diff --git a/packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/service.py b/packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/service.py index 4a6119d90..2ad1d186a 100644 --- a/packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/service.py +++ b/packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/service.py @@ -402,7 +402,7 @@ def scan_schemata(self, data_source_id: str) -> list[str]: """Returns a list of schemas that exist in the database. Can be configured in the data source entity. Data source - managers like Dremio or Drill can work with multiple schemas + managers like Dremio can work with multiple schemas and schema names can be injected into scan_request to filter out tables stored in the different schemas. diff --git a/schemas/gooddata-api-client.json b/schemas/gooddata-api-client.json index dd9909078..20c889d88 100644 --- a/schemas/gooddata-api-client.json +++ b/schemas/gooddata-api-client.json @@ -6142,7 +6142,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -16358,7 +16357,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -16585,7 +16583,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -16770,7 +16767,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -17009,7 +17005,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -34545,7 +34540,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", diff --git a/schemas/gooddata-metadata-client.json b/schemas/gooddata-metadata-client.json index 9321c0003..4b5626b70 100644 --- a/schemas/gooddata-metadata-client.json +++ b/schemas/gooddata-metadata-client.json @@ -3652,7 +3652,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -12461,7 +12460,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -12688,7 +12686,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -12873,7 +12870,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", @@ -13112,7 +13108,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS", diff --git a/schemas/gooddata-scan-client.json b/schemas/gooddata-scan-client.json index ced24508d..438947f26 100644 --- a/schemas/gooddata-scan-client.json +++ b/schemas/gooddata-scan-client.json @@ -760,7 +760,6 @@ "MSSQL", "PRESTO", "DREMIO", - "DRILL", "AZURESQL", "SYNAPSESQL", "DATABRICKS",