From e1e04d78fa773cd3ddc3cde33f5f6277b8ce31fc Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 4 Aug 2026 14:57:40 -0700 Subject: [PATCH 1/8] chore(test): improve diff detection for unit tests --- .github/workflows/lint.yml | 2 +- .github/workflows/unittest.yml | 6 +++--- ci/get_package_shards.py | 2 +- ci/report_coverage.sh | 2 +- ci/run_conditional_tests.sh | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 69402439d08a..9ae0a8392f94 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -57,7 +57,7 @@ jobs: TEST_ALL_PACKAGES: ${{ steps.check-label.outputs.is_full_run }} run: | if [ -n "$TARGET_BRANCH" ]; then - git fetch origin "$TARGET_BRANCH" --depth=1 || true + git fetch origin "$TARGET_BRANCH" --deepen=200 || true fi python3 ci/get_package_shards.py diff --git a/.github/workflows/unittest.yml b/.github/workflows/unittest.yml index 971a9ad84003..ebe4dcbdef77 100644 --- a/.github/workflows/unittest.yml +++ b/.github/workflows/unittest.yml @@ -72,7 +72,7 @@ jobs: PACKAGE_WEIGHTS: ${{ env.PACKAGE_WEIGHTS }} run: | if [ -n "$TARGET_BRANCH" ]; then - git fetch origin "$TARGET_BRANCH" --depth=1 || true + git fetch origin "$TARGET_BRANCH" --deepen=200 || true fi python3 ci/get_package_shards.py @@ -168,8 +168,8 @@ jobs: echo "should_evaluate_coverage=true" >> "$GITHUB_OUTPUT" else TARGET_BRANCH="${TARGET_BRANCH:-main}" - git fetch origin "$TARGET_BRANCH" --depth=1 || true - num_files_changed=$(git diff --name-only "origin/${TARGET_BRANCH}" -- ${PACKAGE_DIRS} | wc -l | tr -d ' ') + git fetch origin "$TARGET_BRANCH" --deepen=200 || true + num_files_changed=$(git diff --name-only "origin/${TARGET_BRANCH}..." -- ${PACKAGE_DIRS} | wc -l | tr -d ' ') if [[ "${num_files_changed}" -gt 0 ]]; then echo "should_evaluate_coverage=true" >> "$GITHUB_OUTPUT" else diff --git a/ci/get_package_shards.py b/ci/get_package_shards.py index 77cc191cc3ac..c0b8803c4fc0 100644 --- a/ci/get_package_shards.py +++ b/ci/get_package_shards.py @@ -108,7 +108,7 @@ def get_packages_to_test(): return all_packages if build_type == 'presubmit': - git_diff_arg = f"origin/{target_branch}" + git_diff_arg = f"origin/{target_branch}..." elif build_type == 'continuous': git_diff_arg = "HEAD~1.." else: diff --git a/ci/report_coverage.sh b/ci/report_coverage.sh index f204bc45cdcc..00262d44d388 100755 --- a/ci/report_coverage.sh +++ b/ci/report_coverage.sh @@ -45,7 +45,7 @@ if [[ "${TEST_ALL_PACKAGES}" == "true" ]]; then modified_packages=$(for dir in ${PACKAGE_DIRS}; do ls -d ${dir}/*/ 2>/dev/null; done | cut -d/ -f1,2 | sort -u) elif [[ "${BUILD_TYPE}" == "presubmit" ]]; then # Presubmit build: evaluate coverage only for packages modified relative to the target branch - modified_packages=$(git diff --name-only "origin/${TARGET_BRANCH}" -- ${PACKAGE_DIRS} 2>/dev/null | cut -d/ -f1,2 | sort -u) + modified_packages=$(git diff --name-only "origin/${TARGET_BRANCH}..." -- ${PACKAGE_DIRS} 2>/dev/null | cut -d/ -f1,2 | sort -u) else # Continuous build (post-merge on main): evaluate coverage for packages modified in the last commit modified_packages=$(git diff --name-only HEAD~1 -- ${PACKAGE_DIRS} 2>/dev/null | cut -d/ -f1,2 | sort -u) diff --git a/ci/run_conditional_tests.sh b/ci/run_conditional_tests.sh index 241de51a4f88..a0593d9f29d8 100755 --- a/ci/run_conditional_tests.sh +++ b/ci/run_conditional_tests.sh @@ -54,9 +54,9 @@ elif [[ ${BUILD_TYPE} == "presubmit" ]]; then # For presubmit build, we want to know the difference from the # common commit in the target branch. if [ -n "${TARGET_BRANCH}" ]; then - git fetch origin "${TARGET_BRANCH}" --depth=1 || true + git fetch origin "${TARGET_BRANCH}" --deepen=200 || true fi - GIT_DIFF_ARG="origin/${TARGET_BRANCH}" + GIT_DIFF_ARG="origin/${TARGET_BRANCH}..." elif [[ ${BUILD_TYPE} == "continuous" ]]; then # For continuous build, we want to know the difference in the last From 45119914d6a2518fffc5012faa83dd3f37d20cc3 Mon Sep 17 00:00:00 2001 From: Shuowei Li Date: Tue, 4 Aug 2026 14:59:38 -0700 Subject: [PATCH 2/8] docs: add connector libraries overview table to package README (#17939) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds a **Related Libraries** table to the `google-cloud-bigquery` [README.rst](file:///usr/local/google/home/shuowei/src/google-cloud-python/google-cloud-python/packages/google-cloud-bigquery/README.rst) linking connector libraries for DataFrame operations: - **BigQuery DataFrames (`bigframes`)**: pandas/scikit-learn-like API powered by BigQuery engine. - **`pandas-gbq`**: integration for loading and writing pandas DataFrames. Fixes #<522853190> 🦕 --- packages/google-cloud-bigquery/README.rst | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/packages/google-cloud-bigquery/README.rst b/packages/google-cloud-bigquery/README.rst index 705ef5ce712c..22ccc2718bd4 100644 --- a/packages/google-cloud-bigquery/README.rst +++ b/packages/google-cloud-bigquery/README.rst @@ -21,6 +21,26 @@ processing power of Google's infrastructure. .. _Client Library Documentation: https://cloud.google.com/python/docs/reference/bigquery/latest/summary_overview .. _Product Documentation: https://cloud.google.com/bigquery/docs/reference/v2/ + +Related Libraries +----------------- + +For higher-level data analysis and DataFrame operations, consider using one of the following connector libraries: + +.. list-table:: + :header-rows: 1 + + * - Library + - Description + - Documentation + * - `BigQuery DataFrames (bigframes) `_ + - Flexible pandas-like and scikit-learn-like API powered by BigQuery engine for large-scale data analysis and ML. + - `BigFrames Docs `_ + * - `pandas-gbq `_ + - Convenient integration allowing pandas DataFrames to load from and write to BigQuery. + - `pandas-gbq Docs `_ + + Quick Start ----------- From 8f926dee336c5486e16a52947e12c6874f1f8b59 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 4 Aug 2026 15:39:10 -0700 Subject: [PATCH 3/8] use shared package list --- .github/workflows/unittest.yml | 29 ++++++----------------------- ci/get_package_shards.py | 6 ++++++ ci/report_coverage.sh | 30 +++++++++++++++++++----------- 3 files changed, 31 insertions(+), 34 deletions(-) diff --git a/.github/workflows/unittest.yml b/.github/workflows/unittest.yml index ebe4dcbdef77..d6a3d462e677 100644 --- a/.github/workflows/unittest.yml +++ b/.github/workflows/unittest.yml @@ -27,6 +27,7 @@ jobs: runs-on: ubuntu-latest outputs: matrix: ${{ steps.set-matrix.outputs.matrix }} + packages: ${{ steps.set-matrix.outputs.packages }} is_full_run: ${{ steps.check-label.outputs.is_full_run }} env: MAX_SHARDS: 16 @@ -72,7 +73,7 @@ jobs: PACKAGE_WEIGHTS: ${{ env.PACKAGE_WEIGHTS }} run: | if [ -n "$TARGET_BRANCH" ]; then - git fetch origin "$TARGET_BRANCH" --deepen=200 || true + git fetch origin "$TARGET_BRANCH" --depth=1 || true fi python3 ci/get_package_shards.py @@ -140,7 +141,7 @@ jobs: echo "All unit tests passed or were skipped" cover: - if: always() && !cancelled() && needs.all-tests.result == 'success' && needs.unit.result != 'skipped' + if: always() && !cancelled() && needs.all-tests.result == 'success' runs-on: ubuntu-latest needs: - all-tests @@ -158,42 +159,24 @@ jobs: uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5 with: python-version: "3.10" - - name: Determine if coverage evaluation is required - id: packages - env: - TEST_ALL_PACKAGES: ${{ needs.initialize.outputs.is_full_run }} - TARGET_BRANCH: ${{ github.base_ref || github.event.merge_group.base_ref }} - run: | - if [[ "${TEST_ALL_PACKAGES}" == "true" ]]; then - echo "should_evaluate_coverage=true" >> "$GITHUB_OUTPUT" - else - TARGET_BRANCH="${TARGET_BRANCH:-main}" - git fetch origin "$TARGET_BRANCH" --deepen=200 || true - num_files_changed=$(git diff --name-only "origin/${TARGET_BRANCH}..." -- ${PACKAGE_DIRS} | wc -l | tr -d ' ') - if [[ "${num_files_changed}" -gt 0 ]]; then - echo "should_evaluate_coverage=true" >> "$GITHUB_OUTPUT" - else - echo "should_evaluate_coverage=false" >> "$GITHUB_OUTPUT" - fi - fi - name: Install coverage - if: ${{ steps.packages.outputs.should_evaluate_coverage == 'true' }} + if: ${{ needs.initialize.outputs.packages != '' }} run: | python -m pip install --upgrade setuptools pip wheel python -m pip install coverage - name: Download coverage results - if: ${{ steps.packages.outputs.should_evaluate_coverage == 'true' }} + if: ${{ needs.initialize.outputs.packages != '' }} uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5 with: path: /dev/shm/.coverage-results/ merge-multiple: true - name: Report coverage results - if: ${{ steps.packages.outputs.should_evaluate_coverage == 'true' }} env: # TODO: default to 100% coverage after next gapic-generator release # https://github.com/googleapis/google-cloud-python/issues/17459 DEFAULT_FAIL_UNDER: 99 TEST_ALL_PACKAGES: ${{ needs.initialize.outputs.is_full_run }} + PACKAGE_LIST: ${{ needs.initialize.outputs.packages }} TARGET_BRANCH: ${{ github.base_ref || github.event.merge_group.base_ref }} BUILD_TYPE: presubmit run: | diff --git a/ci/get_package_shards.py b/ci/get_package_shards.py index c0b8803c4fc0..015adfc2bacd 100644 --- a/ci/get_package_shards.py +++ b/ci/get_package_shards.py @@ -227,7 +227,13 @@ def group_packages(packages_map): shards_json = json.dumps(shards) print(shards_json) + all_paths = [] + for paths in packages.values(): + all_paths.extend(paths) + packages_str = " ".join(all_paths) + github_output = os.environ.get("GITHUB_OUTPUT") if github_output: with open(github_output, "a") as f: f.write(f"matrix={shards_json}\n") + f.write(f"packages={packages_str}\n") diff --git a/ci/report_coverage.sh b/ci/report_coverage.sh index 00262d44d388..478e082ef5cd 100755 --- a/ci/report_coverage.sh +++ b/ci/report_coverage.sh @@ -26,21 +26,14 @@ MAX_JOBS=$(nproc) mkdir -p "${LOG_DIR}" -if [ ! -d "${RESULTS_DIR}" ]; then - echo "Error: No coverage results found in ${RESULTS_DIR}." - exit 1 -fi - -# Unzip any zipped coverage results -find "$RESULTS_DIR" -type f -name '*.zip' -print0 | xargs -0 -P "${MAX_JOBS}" -I {} unzip -q -o {} -d "$RESULTS_DIR" - -# Identify modified packages BUILD_TYPE="${BUILD_TYPE:-presubmit}" TARGET_BRANCH="${TARGET_BRANCH:-main}" - PACKAGE_DIRS="${PACKAGE_DIRS:-packages preview-packages}" -if [[ "${TEST_ALL_PACKAGES}" == "true" ]]; then +if [ "${PACKAGE_LIST+set}" = "set" ]; then + # If pre-determined package list is set, use it + modified_packages="${PACKAGE_LIST}" +elif [[ "${TEST_ALL_PACKAGES}" == "true" ]]; then # Test all packages mode: evaluate coverage for every package in the repository modified_packages=$(for dir in ${PACKAGE_DIRS}; do ls -d ${dir}/*/ 2>/dev/null; done | cut -d/ -f1,2 | sort -u) elif [[ "${BUILD_TYPE}" == "presubmit" ]]; then @@ -51,6 +44,21 @@ else modified_packages=$(git diff --name-only HEAD~1 -- ${PACKAGE_DIRS} 2>/dev/null | cut -d/ -f1,2 | sort -u) fi +if [ -z "${modified_packages}" ]; then + echo "============================================================" + echo "No modified packages to evaluate coverage for." + echo "============================================================" + exit 0 +fi + +if [ ! -d "${RESULTS_DIR}" ]; then + echo "Error: No coverage results found in ${RESULTS_DIR}." + exit 1 +fi + +# Unzip any zipped coverage results +find "$RESULTS_DIR" -type f -name '*.zip' -print0 | xargs -0 -P "${MAX_JOBS}" -I {} unzip -q -o {} -d "$RESULTS_DIR" + # Function to report coverage for a single package report_package_coverage() { local pkg=$1 From 4ab8dbfe335c3ed3e2104f8c9a2955d14df7f370 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 4 Aug 2026 15:51:16 -0700 Subject: [PATCH 4/8] Revert "docs: add connector libraries overview table to package README (#17939)" This reverts commit 45119914d6a2518fffc5012faa83dd3f37d20cc3. --- packages/google-cloud-bigquery/README.rst | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/packages/google-cloud-bigquery/README.rst b/packages/google-cloud-bigquery/README.rst index 22ccc2718bd4..705ef5ce712c 100644 --- a/packages/google-cloud-bigquery/README.rst +++ b/packages/google-cloud-bigquery/README.rst @@ -21,26 +21,6 @@ processing power of Google's infrastructure. .. _Client Library Documentation: https://cloud.google.com/python/docs/reference/bigquery/latest/summary_overview .. _Product Documentation: https://cloud.google.com/bigquery/docs/reference/v2/ - -Related Libraries ------------------ - -For higher-level data analysis and DataFrame operations, consider using one of the following connector libraries: - -.. list-table:: - :header-rows: 1 - - * - Library - - Description - - Documentation - * - `BigQuery DataFrames (bigframes) `_ - - Flexible pandas-like and scikit-learn-like API powered by BigQuery engine for large-scale data analysis and ML. - - `BigFrames Docs `_ - * - `pandas-gbq `_ - - Convenient integration allowing pandas DataFrames to load from and write to BigQuery. - - `pandas-gbq Docs `_ - - Quick Start ----------- From 90b2e0db577b9bfc371a6b2346b5d3e657734373 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 4 Aug 2026 16:04:14 -0700 Subject: [PATCH 5/8] use depth instead of deepen Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- ci/run_conditional_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/run_conditional_tests.sh b/ci/run_conditional_tests.sh index a0593d9f29d8..1f8affbc710e 100755 --- a/ci/run_conditional_tests.sh +++ b/ci/run_conditional_tests.sh @@ -54,7 +54,7 @@ elif [[ ${BUILD_TYPE} == "presubmit" ]]; then # For presubmit build, we want to know the difference from the # common commit in the target branch. if [ -n "${TARGET_BRANCH}" ]; then - git fetch origin "${TARGET_BRANCH}" --deepen=200 || true + git fetch origin "${TARGET_BRANCH}" --depth=200 || true fi GIT_DIFF_ARG="origin/${TARGET_BRANCH}..." From 7dd97c291ff0fae7bd20bd814c136be96229bda0 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 4 Aug 2026 16:06:33 -0700 Subject: [PATCH 6/8] changed package --- packages/google-apps-script-type/README.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/google-apps-script-type/README.rst b/packages/google-apps-script-type/README.rst index 6f141ed64ef1..d546678a34ed 100644 --- a/packages/google-apps-script-type/README.rst +++ b/packages/google-apps-script-type/README.rst @@ -196,3 +196,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment From 34076084b447b580fb88b0563f5605a945b9321c Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Tue, 4 Aug 2026 16:08:59 -0700 Subject: [PATCH 7/8] updated 15 packages --- packages/google-cloud-appoptimize/README.rst | 2 ++ packages/google-cloud-automl/README.rst | 2 ++ packages/google-cloud-chronicle/README.rst | 2 ++ packages/google-cloud-databasecenter/README.rst | 2 ++ packages/google-cloud-discoveryengine/README.rst | 2 ++ packages/google-cloud-financialservices/README.rst | 2 ++ packages/google-cloud-iam/README.rst | 2 ++ packages/google-cloud-logging/tmp/packages/google-cloud-logging | 1 + packages/google-cloud-managedkafka/README.rst | 2 ++ packages/google-cloud-monitoring-metrics-scopes/README.rst | 2 ++ packages/google-cloud-optimization/README.rst | 2 ++ packages/google-cloud-retail/README.rst | 2 ++ packages/google-cloud-videointelligence/README.rst | 2 ++ packages/google-shopping-merchant-datasources/README.rst | 2 ++ packages/google-shopping-merchant-lfp/README.rst | 2 ++ 15 files changed, 29 insertions(+) create mode 120000 packages/google-cloud-logging/tmp/packages/google-cloud-logging diff --git a/packages/google-cloud-appoptimize/README.rst b/packages/google-cloud-appoptimize/README.rst index 84cbdf98e241..675b111b863f 100644 --- a/packages/google-cloud-appoptimize/README.rst +++ b/packages/google-cloud-appoptimize/README.rst @@ -198,3 +198,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-automl/README.rst b/packages/google-cloud-automl/README.rst index eaba2f3efa21..e4e3b5f4d22f 100644 --- a/packages/google-cloud-automl/README.rst +++ b/packages/google-cloud-automl/README.rst @@ -197,3 +197,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-chronicle/README.rst b/packages/google-cloud-chronicle/README.rst index 4de962b76ada..c4855d675902 100644 --- a/packages/google-cloud-chronicle/README.rst +++ b/packages/google-cloud-chronicle/README.rst @@ -198,3 +198,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-databasecenter/README.rst b/packages/google-cloud-databasecenter/README.rst index 59e1be6f2e1d..4a5c7baeb559 100644 --- a/packages/google-cloud-databasecenter/README.rst +++ b/packages/google-cloud-databasecenter/README.rst @@ -202,3 +202,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-discoveryengine/README.rst b/packages/google-cloud-discoveryengine/README.rst index cc7640a39744..a370442ace96 100644 --- a/packages/google-cloud-discoveryengine/README.rst +++ b/packages/google-cloud-discoveryengine/README.rst @@ -196,3 +196,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-financialservices/README.rst b/packages/google-cloud-financialservices/README.rst index 87495b667e1d..822d8f95238b 100644 --- a/packages/google-cloud-financialservices/README.rst +++ b/packages/google-cloud-financialservices/README.rst @@ -196,3 +196,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-iam/README.rst b/packages/google-cloud-iam/README.rst index a80f0ff3dbbd..c883434fc778 100644 --- a/packages/google-cloud-iam/README.rst +++ b/packages/google-cloud-iam/README.rst @@ -201,3 +201,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-logging/tmp/packages/google-cloud-logging b/packages/google-cloud-logging/tmp/packages/google-cloud-logging new file mode 120000 index 000000000000..c25bddb6dd46 --- /dev/null +++ b/packages/google-cloud-logging/tmp/packages/google-cloud-logging @@ -0,0 +1 @@ +../.. \ No newline at end of file diff --git a/packages/google-cloud-managedkafka/README.rst b/packages/google-cloud-managedkafka/README.rst index bc96463acd95..a23d5ba9fd79 100644 --- a/packages/google-cloud-managedkafka/README.rst +++ b/packages/google-cloud-managedkafka/README.rst @@ -196,3 +196,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-monitoring-metrics-scopes/README.rst b/packages/google-cloud-monitoring-metrics-scopes/README.rst index e1096d5f69aa..16e9506f0a9a 100644 --- a/packages/google-cloud-monitoring-metrics-scopes/README.rst +++ b/packages/google-cloud-monitoring-metrics-scopes/README.rst @@ -201,3 +201,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-optimization/README.rst b/packages/google-cloud-optimization/README.rst index 7fd6091185a3..5d3b4b5e8361 100644 --- a/packages/google-cloud-optimization/README.rst +++ b/packages/google-cloud-optimization/README.rst @@ -198,3 +198,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-retail/README.rst b/packages/google-cloud-retail/README.rst index 8e7e1834b6ab..38b426fdf8d6 100644 --- a/packages/google-cloud-retail/README.rst +++ b/packages/google-cloud-retail/README.rst @@ -199,3 +199,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-cloud-videointelligence/README.rst b/packages/google-cloud-videointelligence/README.rst index 8f0e9852717e..64af0814459c 100644 --- a/packages/google-cloud-videointelligence/README.rst +++ b/packages/google-cloud-videointelligence/README.rst @@ -198,3 +198,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-shopping-merchant-datasources/README.rst b/packages/google-shopping-merchant-datasources/README.rst index 44dee2e237da..1cfff1474c2a 100644 --- a/packages/google-shopping-merchant-datasources/README.rst +++ b/packages/google-shopping-merchant-datasources/README.rst @@ -196,3 +196,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment diff --git a/packages/google-shopping-merchant-lfp/README.rst b/packages/google-shopping-merchant-lfp/README.rst index 9c4eed44a6e6..fb3defd4072b 100644 --- a/packages/google-shopping-merchant-lfp/README.rst +++ b/packages/google-shopping-merchant-lfp/README.rst @@ -196,3 +196,5 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) + +.. test comment From b9c52b6d8dc4dbc5c5217081c10a29d828b8fe2f Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Wed, 5 Aug 2026 09:14:09 -0700 Subject: [PATCH 8/8] reverted test comments --- packages/google-apps-script-type/README.rst | 2 -- packages/google-cloud-appoptimize/README.rst | 2 -- packages/google-cloud-automl/README.rst | 2 -- packages/google-cloud-chronicle/README.rst | 2 -- packages/google-cloud-databasecenter/README.rst | 2 -- packages/google-cloud-discoveryengine/README.rst | 2 -- packages/google-cloud-financialservices/README.rst | 2 -- packages/google-cloud-iam/README.rst | 2 -- packages/google-cloud-logging/tmp/packages/google-cloud-logging | 1 - packages/google-cloud-managedkafka/README.rst | 2 -- packages/google-cloud-monitoring-metrics-scopes/README.rst | 2 -- packages/google-cloud-optimization/README.rst | 2 -- packages/google-cloud-retail/README.rst | 2 -- packages/google-cloud-videointelligence/README.rst | 2 -- packages/google-shopping-merchant-datasources/README.rst | 2 -- packages/google-shopping-merchant-lfp/README.rst | 2 -- 16 files changed, 31 deletions(-) delete mode 120000 packages/google-cloud-logging/tmp/packages/google-cloud-logging diff --git a/packages/google-apps-script-type/README.rst b/packages/google-apps-script-type/README.rst index d546678a34ed..6f141ed64ef1 100644 --- a/packages/google-apps-script-type/README.rst +++ b/packages/google-apps-script-type/README.rst @@ -196,5 +196,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-appoptimize/README.rst b/packages/google-cloud-appoptimize/README.rst index 675b111b863f..84cbdf98e241 100644 --- a/packages/google-cloud-appoptimize/README.rst +++ b/packages/google-cloud-appoptimize/README.rst @@ -198,5 +198,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-automl/README.rst b/packages/google-cloud-automl/README.rst index e4e3b5f4d22f..eaba2f3efa21 100644 --- a/packages/google-cloud-automl/README.rst +++ b/packages/google-cloud-automl/README.rst @@ -197,5 +197,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-chronicle/README.rst b/packages/google-cloud-chronicle/README.rst index c4855d675902..4de962b76ada 100644 --- a/packages/google-cloud-chronicle/README.rst +++ b/packages/google-cloud-chronicle/README.rst @@ -198,5 +198,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-databasecenter/README.rst b/packages/google-cloud-databasecenter/README.rst index 4a5c7baeb559..59e1be6f2e1d 100644 --- a/packages/google-cloud-databasecenter/README.rst +++ b/packages/google-cloud-databasecenter/README.rst @@ -202,5 +202,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-discoveryengine/README.rst b/packages/google-cloud-discoveryengine/README.rst index a370442ace96..cc7640a39744 100644 --- a/packages/google-cloud-discoveryengine/README.rst +++ b/packages/google-cloud-discoveryengine/README.rst @@ -196,5 +196,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-financialservices/README.rst b/packages/google-cloud-financialservices/README.rst index 822d8f95238b..87495b667e1d 100644 --- a/packages/google-cloud-financialservices/README.rst +++ b/packages/google-cloud-financialservices/README.rst @@ -196,5 +196,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-iam/README.rst b/packages/google-cloud-iam/README.rst index c883434fc778..a80f0ff3dbbd 100644 --- a/packages/google-cloud-iam/README.rst +++ b/packages/google-cloud-iam/README.rst @@ -201,5 +201,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-logging/tmp/packages/google-cloud-logging b/packages/google-cloud-logging/tmp/packages/google-cloud-logging deleted file mode 120000 index c25bddb6dd46..000000000000 --- a/packages/google-cloud-logging/tmp/packages/google-cloud-logging +++ /dev/null @@ -1 +0,0 @@ -../.. \ No newline at end of file diff --git a/packages/google-cloud-managedkafka/README.rst b/packages/google-cloud-managedkafka/README.rst index a23d5ba9fd79..bc96463acd95 100644 --- a/packages/google-cloud-managedkafka/README.rst +++ b/packages/google-cloud-managedkafka/README.rst @@ -196,5 +196,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-monitoring-metrics-scopes/README.rst b/packages/google-cloud-monitoring-metrics-scopes/README.rst index 16e9506f0a9a..e1096d5f69aa 100644 --- a/packages/google-cloud-monitoring-metrics-scopes/README.rst +++ b/packages/google-cloud-monitoring-metrics-scopes/README.rst @@ -201,5 +201,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-optimization/README.rst b/packages/google-cloud-optimization/README.rst index 5d3b4b5e8361..7fd6091185a3 100644 --- a/packages/google-cloud-optimization/README.rst +++ b/packages/google-cloud-optimization/README.rst @@ -198,5 +198,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-retail/README.rst b/packages/google-cloud-retail/README.rst index 38b426fdf8d6..8e7e1834b6ab 100644 --- a/packages/google-cloud-retail/README.rst +++ b/packages/google-cloud-retail/README.rst @@ -199,5 +199,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-cloud-videointelligence/README.rst b/packages/google-cloud-videointelligence/README.rst index 64af0814459c..8f0e9852717e 100644 --- a/packages/google-cloud-videointelligence/README.rst +++ b/packages/google-cloud-videointelligence/README.rst @@ -198,5 +198,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-shopping-merchant-datasources/README.rst b/packages/google-shopping-merchant-datasources/README.rst index 1cfff1474c2a..44dee2e237da 100644 --- a/packages/google-shopping-merchant-datasources/README.rst +++ b/packages/google-shopping-merchant-datasources/README.rst @@ -196,5 +196,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment diff --git a/packages/google-shopping-merchant-lfp/README.rst b/packages/google-shopping-merchant-lfp/README.rst index fb3defd4072b..9c4eed44a6e6 100644 --- a/packages/google-shopping-merchant-lfp/README.rst +++ b/packages/google-shopping-merchant-lfp/README.rst @@ -196,5 +196,3 @@ Logging details #. The Google-specific logging configurations (default handlers for environment-based configuration; not propagating logging events to the root logger) get executed the first time *any* client library is instantiated in your application, and only if the affected loggers have not been previously configured. (This is the reason for 2.i. above.) - -.. test comment