From 9224bc761c80a92149eadbe761acc53742a78cfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:20:10 +0200 Subject: [PATCH 1/9] no_multiple_statements_per_line --- .php-cs-fixer.php | 1 + tests/unit/classes/ClassInspectorTest.php | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index b2c8ef60a..abc2cc8f9 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -59,6 +59,7 @@ 'no_leading_import_slash' => true, 'no_leading_namespace_whitespace' => true, 'no_mixed_echo_print' => true, + 'no_multiple_statements_per_line' => true, 'no_multiline_whitespace_around_double_arrow' => true, 'no_singleline_whitespace_before_semicolons' => true, 'no_space_around_double_colon' => true, diff --git a/tests/unit/classes/ClassInspectorTest.php b/tests/unit/classes/ClassInspectorTest.php index 6ce35e003..c85958e90 100644 --- a/tests/unit/classes/ClassInspectorTest.php +++ b/tests/unit/classes/ClassInspectorTest.php @@ -47,7 +47,8 @@ trait C class D implements IC, ID { - use B; use C; + use B; + use C; } class E extends D { From 1ceebb9fdb025ce3a25d73f6921922b1fc611e3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:40:34 +0200 Subject: [PATCH 2/9] visibility_required -> modifier_keywords --- .php-cs-fixer.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index abc2cc8f9..54ebe76f5 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -46,6 +46,7 @@ 'magic_constant_casing' => true, 'magic_method_casing' => true, 'method_argument_space' => ['on_multiline' => 'ignore'], + 'modifier_keywords' => true, 'multiline_whitespace_before_semicolons' => true, 'native_function_casing' => true, 'native_type_declaration_casing' => true, @@ -59,8 +60,8 @@ 'no_leading_import_slash' => true, 'no_leading_namespace_whitespace' => true, 'no_mixed_echo_print' => true, - 'no_multiple_statements_per_line' => true, 'no_multiline_whitespace_around_double_arrow' => true, + 'no_multiple_statements_per_line' => true, 'no_singleline_whitespace_before_semicolons' => true, 'no_space_around_double_colon' => true, 'no_trailing_comma_in_singleline' => true, @@ -122,7 +123,6 @@ 'trim_array_spaces' => true, 'type_declaration_spaces' => true, 'types_spaces' => true, - 'visibility_required' => true, 'void_return' => true, 'whitespace_after_comma_in_array' => true, ]) From dce94d7e95dd10f3bf2eec126ef14cfe1c292ff7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:42:44 +0200 Subject: [PATCH 3/9] no_redundant_readonly_property --- .php-cs-fixer.php | 1 + 1 file changed, 1 insertion(+) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 54ebe76f5..59421ede2 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -62,6 +62,7 @@ 'no_mixed_echo_print' => true, 'no_multiline_whitespace_around_double_arrow' => true, 'no_multiple_statements_per_line' => true, + 'no_redundant_readonly_property' => true, 'no_singleline_whitespace_before_semicolons' => true, 'no_space_around_double_colon' => true, 'no_trailing_comma_in_singleline' => true, From dc07e4fe338a8702e8463e5c459fbcc6d5332df5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:46:51 +0200 Subject: [PATCH 4/9] stringable_for_to_string --- .php-cs-fixer.php | 1 + 1 file changed, 1 insertion(+) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 59421ede2..04bb0b35f 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -117,6 +117,7 @@ 'spaces_inside_parentheses' => ['space' => 'none'], 'standardize_increment' => true, 'standardize_not_equals' => true, + 'stringable_for_to_string' => true, 'switch_case_semicolon_to_colon' => true, 'switch_case_space' => true, 'ternary_to_null_coalescing' => true, From f17f3aa87402dae47b21709cc41fbc5d0e017148 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:54:09 +0200 Subject: [PATCH 5/9] include --- .php-cs-fixer.php | 1 + src/mako/view/renderers/PHP.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 04bb0b35f..4ce479834 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -35,6 +35,7 @@ 'function_to_constant' => true, 'get_class_to_class_keyword' => true, 'heredoc_to_nowdoc' => true, + 'include' => true, 'integer_literal_case' => true, 'lambda_not_used_import' => true, 'linebreak_after_opening_tag' => true, diff --git a/src/mako/view/renderers/PHP.php b/src/mako/view/renderers/PHP.php index 23fdfebd3..b71a2e60a 100644 --- a/src/mako/view/renderers/PHP.php +++ b/src/mako/view/renderers/PHP.php @@ -31,7 +31,7 @@ public function render(string $__view__, array $__variables__): string ob_start(); - include ($__view__); + include $__view__; return ob_get_clean(); } From a5f7e5023f8599705b055a27d5cedb2e9c5839be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:54:15 +0200 Subject: [PATCH 6/9] no_useless_printf --- .php-cs-fixer.php | 1 + 1 file changed, 1 insertion(+) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 4ce479834..1cb6e322e 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -73,6 +73,7 @@ 'no_unset_cast' => true, 'no_unused_imports' => true, 'no_useless_concat_operator' => true, + 'no_useless_printf' => true, 'no_useless_sprintf' => true, 'no_whitespace_before_comma_in_array' => true, 'no_whitespace_in_blank_line' => true, From 145ef59ab85d9c4f11de5e817ed7ca4d4f1e8532 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:56:33 +0200 Subject: [PATCH 7/9] no_useless_return --- .php-cs-fixer.php | 1 + 1 file changed, 1 insertion(+) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 1cb6e322e..d1f6bdad7 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -74,6 +74,7 @@ 'no_unused_imports' => true, 'no_useless_concat_operator' => true, 'no_useless_printf' => true, + 'no_useless_return' => true, 'no_useless_sprintf' => true, 'no_whitespace_before_comma_in_array' => true, 'no_whitespace_in_blank_line' => true, From 97241d91181450a2365b31dbf09a283dd8a2caa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 09:59:54 +0200 Subject: [PATCH 8/9] simplified_null_return --- .php-cs-fixer.php | 1 + tests/unit/reactor/traits/FireTraitTest.php | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index d1f6bdad7..bf8aa6922 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -108,6 +108,7 @@ 'semicolon_after_instruction' => true, 'short_scalar_cast' => true, 'simple_to_complex_string_variable' => true, + 'simplified_null_return' => true, 'single_blank_line_at_eof' => true, 'single_class_element_per_statement' => true, 'single_import_per_statement' => true, diff --git a/tests/unit/reactor/traits/FireTraitTest.php b/tests/unit/reactor/traits/FireTraitTest.php index 4f0dbf508..61b7b1cbe 100644 --- a/tests/unit/reactor/traits/FireTraitTest.php +++ b/tests/unit/reactor/traits/FireTraitTest.php @@ -61,9 +61,9 @@ public function getPath() return '/foo/bar'; } - public function getEnvironment() + public function getEnvironment(): void { - return null; + } }; } @@ -102,9 +102,9 @@ public function getPath() return '/foo/bar'; } - public function getEnvironment() + public function getEnvironment(): void { - return null; + } }; } From 2f4012b16c288497c2ce86115c79ed5905fdb147 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederic=20G=2E=20=C3=98stby?= Date: Sun, 9 Aug 2026 10:07:17 +0200 Subject: [PATCH 9/9] Update FireTraitTest.php --- tests/unit/reactor/traits/FireTraitTest.php | 26 ++++++++++----------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/unit/reactor/traits/FireTraitTest.php b/tests/unit/reactor/traits/FireTraitTest.php index 61b7b1cbe..6ff6e882a 100644 --- a/tests/unit/reactor/traits/FireTraitTest.php +++ b/tests/unit/reactor/traits/FireTraitTest.php @@ -27,7 +27,7 @@ public function testBuildReactorPath(): void public function __construct() { $this->app = new class { - public function getPath() + public function getPath(): string { return DIRECTORY_SEPARATOR . 'foo' . DIRECTORY_SEPARATOR . 'bar'; } @@ -56,14 +56,14 @@ public function testBuildCommandWithoutEnv(): void public function __construct() { $this->app = new class { - public function getPath() + public function getPath(): string { return '/foo/bar'; } - public function getEnvironment(): void + public function getEnvironment(): ?string { - + return null; } }; } @@ -97,14 +97,14 @@ public function testBuildBackgroundCommandWithoutEnv(): void public function __construct() { $this->app = new class { - public function getPath() + public function getPath(): string { return '/foo/bar'; } - public function getEnvironment(): void + public function getEnvironment(): ?string { - + return null; } }; } @@ -138,12 +138,12 @@ public function testBuildCommandWithEnv(): void public function __construct() { $this->app = new class { - public function getPath() + public function getPath(): string { return '/foo/bar'; } - public function getEnvironment() + public function getEnvironment(): ?string { return 'dev'; } @@ -179,12 +179,12 @@ public function testBuildCommandWithEnvWithManualOverride(): void public function __construct() { $this->app = new class { - public function getPath() + public function getPath(): string { return '/foo/bar'; } - public function getEnvironment() + public function getEnvironment(): ?string { return 'dev'; } @@ -220,12 +220,12 @@ public function testBuildCommandWithEnvWithoutUsingSame(): void public function __construct() { $this->app = new class { - public function getPath() + public function getPath(): string { return '/foo/bar'; } - public function getEnvironment() + public function getEnvironment(): ?string { return 'dev'; }