Skip to content

Commit 47a89d3

Browse files
committed
ci: 336 runs on the one job that has qemu-arm, and its PASS line is demanded
336 declares `# requires: qemu-arm`, which no sharded runner has, so on a shard it exits 0 without running a single row. Adding it to the loop and not to the assertions below would have been that defect one layer in — the same shape the comment above 332 already records. Both the PASS line and a row count are demanded, because a fixture that stopped iterating still prints its PASS line.
1 parent 17be228 commit 47a89d3

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

.github/workflows/ci-linux-e2e.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ jobs:
188188
tests/e2e/131_freestanding_bsp_supplies_everything.sh \
189189
tests/e2e/132_freestanding_test_and_artifacts.sh \
190190
tests/e2e/133_freestanding_std_subset.sh \
191-
tests/e2e/332_cortex_m_builds_and_boots.sh; do
191+
tests/e2e/332_cortex_m_builds_and_boots.sh \
192+
tests/e2e/336_armv7a_builds_and_boots.sh; do
192193
echo "=== $t ==="
193194
bash "$t" 2>&1 | tee "$(basename "$t").log"
194195
rc=${PIPESTATUS[0]}
@@ -221,6 +222,15 @@ jobs:
221222
booted=$(grep -c 'booted on ' 332_cortex_m_builds_and_boots.sh.log || true)
222223
[ "$booted" = "4" ] || {
223224
echo "332 booted $booted rows, expected 4"; exit 1; }
225+
# ⚠️ 336 IS HERE FOR THE SAME REASON, AND ADDING IT TO THE LOOP ABOVE
226+
# WITHOUT ADDING IT HERE WOULD HAVE BEEN THE SAME DEFECT: it declares
227+
# `# requires: qemu-arm`, so on a shard it exits 0 having run nothing.
228+
grep -q 'PASS: armv7-a rows build, boot' \
229+
336_armv7a_builds_and_boots.sh.log || {
230+
echo "336 (armv7-a) skipped on the runner that must run it"; exit 1; }
231+
a32=$(grep -c 'booted on virt' 336_armv7a_builds_and_boots.sh.log || true)
232+
[ "$a32" = "2" ] || {
233+
echo "336 booted $a32 rows, expected 2"; exit 1; }
224234
225235
# ──────────────────────────────────────────────────────────────────
226236
# Hermetic (no host toolchain): the ONLY environment class that

0 commit comments

Comments
 (0)