Skip to content

Commit 75ccff6

Browse files
committed
fixup! sqlite: validate StatementSync.run() integers
1 parent 990ea83 commit 75ccff6

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/node_sqlite.cc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,15 @@ inline MaybeLocal<Value> IntegerToValue(Isolate* isolate,
112112
return BigInt::New(isolate, value);
113113
}
114114

115-
if (value >= -kMaxSafeJsInteger && value <= kMaxSafeJsInteger) {
116-
return Number::New(isolate, value);
115+
if (value < -kMaxSafeJsInteger || value > kMaxSafeJsInteger) {
116+
THROW_ERR_OUT_OF_RANGE(
117+
isolate,
118+
"Value is too large to be represented as a JavaScript number: %" PRId64,
119+
value);
120+
return MaybeLocal<Value>();
117121
}
118122

119-
THROW_ERR_OUT_OF_RANGE(
120-
isolate,
121-
"Value is too large to be represented as a JavaScript number: %" PRId64,
122-
value);
123-
return MaybeLocal<Value>();
123+
return Number::New(isolate, value);
124124
}
125125

126126
#define CHECK_ERROR_OR_THROW(isolate, db, expr, expected, ret) \

0 commit comments

Comments
 (0)