From 0cfdb00d9d8bac05ac62ad65191b670191db1b83 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Wed, 19 Aug 2026 07:13:12 -0700 Subject: [PATCH] sqlite: remove unused column name helper Remove the unused column name helper from StatementExecutionHelper. It became unused after all() and get() switched to cached names. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> --- src/node_sqlite.cc | 14 -------------- src/node_sqlite.h | 3 --- 2 files changed, 17 deletions(-) diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc index c6b8a8d0a61..2662f29efc8 100644 --- a/src/node_sqlite.cc +++ b/src/node_sqlite.cc @@ -3147,20 +3147,6 @@ MaybeLocal StatementExecutionHelper::ColumnToValue(Environment* env, return js_val; } -MaybeLocal StatementExecutionHelper::ColumnNameToName(Environment* env, - sqlite3_stmt* stmt, - const int column) { - const char* col_name = sqlite3_column_name(stmt, column); - if (col_name == nullptr) { - THROW_ERR_INVALID_STATE(env, "Cannot get name of column %d", column); - return MaybeLocal(); - } - - return String::NewFromUtf8( - env->isolate(), col_name, NewStringType::kInternalized) - .As(); -} - void StatementSync::MemoryInfo(MemoryTracker* tracker) const {} Maybe ExtractRowValues(Environment* env, diff --git a/src/node_sqlite.h b/src/node_sqlite.h index 7fec61dbf9a..6976c20a938 100644 --- a/src/node_sqlite.h +++ b/src/node_sqlite.h @@ -187,9 +187,6 @@ class StatementExecutionHelper { sqlite3_stmt* stmt, const int column, bool use_big_ints); - static v8::MaybeLocal ColumnNameToName(Environment* env, - sqlite3_stmt* stmt, - const int column); static v8::MaybeLocal Get(Environment* env, StatementSync* statement); };