From b570ad9df85440e6c91363da63729dc513fc3915 Mon Sep 17 00:00:00 2001 From: Rafal Rudnicki Date: Fri, 7 Aug 2026 11:09:44 +0000 Subject: [PATCH] Rename methods to follow Rust conventions --- oneapi-rs/examples/kernel_launch.rs | 4 ++-- oneapi-rs/examples/kernel_launch_derive.rs | 4 ++-- oneapi-rs/examples/sycl-ls.rs | 14 +++++++------- oneapi-rs/src/device.rs | 4 ++-- oneapi-rs/src/info.rs | 6 +++--- oneapi-rs/src/info/device-info.rs | 6 +++--- oneapi-rs/src/info/event-info.rs | 2 +- oneapi-rs/src/info/platform-info.rs | 6 +++--- oneapi-rs/src/kernel.rs | 2 +- oneapi-rs/src/lib.rs | 4 ++-- oneapi-rs/src/platform.rs | 4 ++-- oneapi-rs/src/queue.rs | 2 +- 12 files changed, 29 insertions(+), 29 deletions(-) diff --git a/oneapi-rs/examples/kernel_launch.rs b/oneapi-rs/examples/kernel_launch.rs index ce8aa2c..ee245f8 100644 --- a/oneapi-rs/examples/kernel_launch.rs +++ b/oneapi-rs/examples/kernel_launch.rs @@ -27,10 +27,10 @@ async fn main() { let mut device_buffer = queue.alloc_device::(1024).await; let kernel = queue - .get_context() + .context() .create_kernel_bundle_from_source(IOTA_SRC) .build() - .get_kernel("iota"); + .kernel("iota"); unsafe { queue.launch( diff --git a/oneapi-rs/examples/kernel_launch_derive.rs b/oneapi-rs/examples/kernel_launch_derive.rs index 66e628d..f54aa22 100644 --- a/oneapi-rs/examples/kernel_launch_derive.rs +++ b/oneapi-rs/examples/kernel_launch_derive.rs @@ -32,10 +32,10 @@ fn main() { let mut buffer = queue.alloc_shared::(1024).wait(); let kernel = queue - .get_context() + .context() .create_kernel_bundle_from_source(IOTA_SRC) .build() - .get_kernel("iota"); + .kernel("iota"); unsafe { queue.launch( diff --git a/oneapi-rs/examples/sycl-ls.rs b/oneapi-rs/examples/sycl-ls.rs index 1e0ec88..3f37857 100644 --- a/oneapi-rs/examples/sycl-ls.rs +++ b/oneapi-rs/examples/sycl-ls.rs @@ -9,13 +9,13 @@ use oneapi_rs::prelude::*; fn main() { - for platform in Platform::get_platforms() { - for device in platform.get_devices() { - let device_type = device.get_info::(); - let platform_name = platform.get_info::(); - let device_name = device.get_info::(); - let device_version = device.get_info::(); - let platform_version = platform.get_info::(); + for platform in Platform::all() { + for device in platform.devices() { + let device_type = device.info::(); + let platform_name = platform.info::(); + let device_name = device.info::(); + let device_version = device.info::(); + let platform_version = platform.info::(); println!( "[{device_type:?}] {platform_name}, {device_name} {device_version} [{platform_version}]" diff --git a/oneapi-rs/src/device.rs b/oneapi-rs/src/device.rs index d2d4d5c..bbcbdb5 100644 --- a/oneapi-rs/src/device.rs +++ b/oneapi-rs/src/device.rs @@ -27,7 +27,7 @@ impl From> for Device { impl Device { /// Returns a [`Vec`] containing all the root devices from all SYCL backends /// available in the system which have the device type encapsulated by [`DeviceType`](crate::info::DeviceType). - pub fn get_devices() -> Vec { + pub fn all() -> Vec { ffi::get_devices() .into_iter() .map(|device| Self(device.ptr)) @@ -35,7 +35,7 @@ impl Device { } /// Returns the associated SYCL platform. - pub fn get_platform(&self) -> Platform { + pub fn platform(&self) -> Platform { let raw_platform = ffi::get_platform(&self.0); Platform(raw_platform) } diff --git a/oneapi-rs/src/info.rs b/oneapi-rs/src/info.rs index 821c399..973ebc9 100644 --- a/oneapi-rs/src/info.rs +++ b/oneapi-rs/src/info.rs @@ -29,13 +29,13 @@ pub trait Info: Sealed { type Target; /// Returns information for a given Target. - fn get_item(target: &Self::Target) -> Self::Item; + fn item(target: &Self::Target) -> Self::Item; } /// Types which can be queried for information. pub trait InfoTarget: Sealed { /// Queries this object for information requested by given generic parameter. - fn get_info>(&self) -> T::Item { - T::get_item(self) + fn info>(&self) -> T::Item { + T::item(self) } } diff --git a/oneapi-rs/src/info/device-info.rs b/oneapi-rs/src/info/device-info.rs index 3696850..caba6ec 100644 --- a/oneapi-rs/src/info/device-info.rs +++ b/oneapi-rs/src/info/device-info.rs @@ -17,7 +17,7 @@ impl Sealed for DeviceType {} impl Info for DeviceType { type Item = crate::info::DeviceType; type Target = Device; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_device_type(&target.0) } } @@ -28,7 +28,7 @@ impl Sealed for Version {} impl Info for Version { type Item = String; type Target = Device; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_version(&target.0) } } @@ -39,7 +39,7 @@ impl Sealed for Name {} impl Info for Name { type Item = String; type Target = Device; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_name(&target.0) } } diff --git a/oneapi-rs/src/info/event-info.rs b/oneapi-rs/src/info/event-info.rs index 9517429..bb44cc9 100644 --- a/oneapi-rs/src/info/event-info.rs +++ b/oneapi-rs/src/info/event-info.rs @@ -17,7 +17,7 @@ impl Sealed for CommandExecutionStatus {} impl Info for CommandExecutionStatus { type Item = crate::info::EventCommandStatus; type Target = Event; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_command_execution_status(&target.0) } } diff --git a/oneapi-rs/src/info/platform-info.rs b/oneapi-rs/src/info/platform-info.rs index 179e4a8..6537286 100644 --- a/oneapi-rs/src/info/platform-info.rs +++ b/oneapi-rs/src/info/platform-info.rs @@ -17,7 +17,7 @@ impl Sealed for Version {} impl Info for Version { type Item = String; type Target = Platform; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_version(&target.0) } } @@ -28,7 +28,7 @@ impl Sealed for Name {} impl Info for Name { type Item = String; type Target = Platform; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_name(&target.0) } } @@ -39,7 +39,7 @@ impl Sealed for Vendor {} impl Info for Vendor { type Item = String; type Target = Platform; - fn get_item(target: &Self::Target) -> Self::Item { + fn item(target: &Self::Target) -> Self::Item { ffi::get_vendor(&target.0) } } diff --git a/oneapi-rs/src/kernel.rs b/oneapi-rs/src/kernel.rs index 60b425e..8aad3d5 100644 --- a/oneapi-rs/src/kernel.rs +++ b/oneapi-rs/src/kernel.rs @@ -34,7 +34,7 @@ impl From> for ExecutableKern } impl ExecutableKernelBundle { - pub fn get_kernel(&mut self, name: &str) -> Kernel { + pub fn kernel(&mut self, name: &str) -> Kernel { ffi::get_kernel(&mut self.0, name).into() } } diff --git a/oneapi-rs/src/lib.rs b/oneapi-rs/src/lib.rs index 46e5dad..dad5448 100644 --- a/oneapi-rs/src/lib.rs +++ b/oneapi-rs/src/lib.rs @@ -44,10 +44,10 @@ //! 3. Build a SYCL kernel. //! ```rust,ignore //! let kernel = queue -//! .get_context() +//! .context() //! .create_kernel_bundle_from_source(IOTA_SRC) //! .build() -//! .get_kernel("iota"); +//! .kernel("iota"); //! ``` //! //! 4. Launch your kernel. diff --git a/oneapi-rs/src/platform.rs b/oneapi-rs/src/platform.rs index c398771..2cf575f 100644 --- a/oneapi-rs/src/platform.rs +++ b/oneapi-rs/src/platform.rs @@ -23,7 +23,7 @@ impl InfoTarget for Platform {} impl Platform { /// Returns a [`Vec`] containing all SYCL platforms from all SYCL backends available in the system. - pub fn get_platforms() -> Vec { + pub fn all() -> Vec { ffi::get_platforms() .into_iter() .map(|platform| Self(platform.ptr)) @@ -31,7 +31,7 @@ impl Platform { } /// Returns a [`Vec`] containing all the root devices associated with this `Platform`. - pub fn get_devices(&self) -> Vec { + pub fn devices(&self) -> Vec { ffi::get_devices(&self.0) .into_iter() .map(|device| Device(device.ptr)) diff --git a/oneapi-rs/src/queue.rs b/oneapi-rs/src/queue.rs index 6235cdf..fee0e76 100644 --- a/oneapi-rs/src/queue.rs +++ b/oneapi-rs/src/queue.rs @@ -39,7 +39,7 @@ impl Queue { } /// Returns the SYCL queue’s context. - pub fn get_context(&self) -> Context { + pub fn context(&self) -> Context { ffi::get_context(&self.0).into() }