Numeric strings gets converted to integers

[leoleva]

Bug Report

Rector version: Rector 2.2.7

Numeric strings gets converted to integers

Minimal PHP Code Causing Issue

https://getrector.com/demo/fbbafe10-f1d1-4353-b03f-4ce5583cd4fc

-    /**
-     * @OA\Property(
-     *     example="01112"
-     * )
-     */
+    #[OA\Property(example: 1112)]

Expected Behaviour

It should remain as a string

[samsonasik]

This is expected, at least on some annotation -> attribute transformation, eg:

-    /**
-     * @Assert\Length(
-     *     min="100",
-     *     max="255",
-     *     maxMessage="some Message",
-     *     allowed="true"
-     * )
-     */
+    #[Assert\Length(min: 100, max: 255, maxMessage: 'some Message', allowed: 'true')]

handled at

rector/src/PhpAttribute/AttributeArrayNameInliner.php

Lines 55 to 62 in 5dac06a

	if ($arg->value instanceof String_ && is_numeric($arg->value->value)) {
	// use equal over identical on purpose to verify if it is an integer
	if ((float) $arg->value->value == (int) $arg->value->value) {
	$arg->value = new Int_((int) $arg->value->value);
	} else {
	$arg->value = new Float_((float) $arg->value->value);
	}
	}

Do you have reference of specific OpenApi\Annotations\Property that keep the value of numeric string?

[leoleva]

This behaviour can cause issues. In the current open api docs example, it's shown as an integer, while actually it has to be a string.

[samsonasik]

Ref of example field

https://github.com/zircote/swagger-php/blob/61416ad6ead9f5e6af4316eada899535cfd38f07/src/Attributes/Property.php#L61

[samsonasik]

I created PR:

• [Php80] Handle OpenApi\Attributes\Property example to keep numeric string on AnnotationToAttributeRector rector-src#7677

for it.

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.