Skip to content

tt clean don't show files it is going to delete before confirmation #1237

Description

@tmr-g

tt clean must show files it is going to delete before confirmation:

To avoid accidental deletion of files, tt clean shows the files it is going to delete and asks for confirmation.

But it doesn't.

...
   • Processing application instances file
   • Instance "instance001"
   • Instance "instance002"
   • Instance "instance003"

Confirm [y/n]: y
   • removed "/doc_src/snippets/centralized_config/instances.enabled/tarantool_config_storage/var/log/instance001/tt.log"
   • removed "/doc_src/snippets/centralized_config/instances.enabled/tarantool_config_storage/var/lib/instance001/00000000000000000000.snap"
   • removed "/doc_src/snippets/centralized_config/instances.enabled/tarantool_config_storage/var/lib/instance001/00000000000000000000.xlog"
   • removed "/doc_src/snippets/centralized_config/instances.enabled/tarantool_config_storage/var/lib/instance001/00000000000000000037.xlog"
   • removed "/doc_src/snippets/centralized_config/instances.enabled/tarantool_config_storage/var/lib/instance001/00000000000000000041.snap"
   • removed "/doc_src/snippets/centralized_config/instances.enabled/tarantool_config_storage/var/lib/instance001/00000000000000000041.xlog"
   • tarantool_config_storage:instance001...	[OK]

See:

tt/cli/cmd/clean.go

Lines 76 to 89 in 7dd32dc

if !forceRemove {
confirm, err = util.AskConfirm(os.Stdin, "\nConfirm")
if err != nil {
return err
}
}
if confirm || forceRemove {
for file := range removeFiles {
err = os.Remove(file)
if err != nil {
return err
}
log.Debugf("removed %q", file)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions