From cd0726f663f9380c1fd70ce94708bfeef021b19b Mon Sep 17 00:00:00 2001 From: Jeevan Mahesha Date: Fri, 24 Jul 2026 16:10:07 +0530 Subject: [PATCH 1/2] refactor: remove unused ChangeDetectionStrategy from LoginComponent and LoggedInComponent --- apps/example-app-karma/src/app/issues/issue-491.spec.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/apps/example-app-karma/src/app/issues/issue-491.spec.ts b/apps/example-app-karma/src/app/issues/issue-491.spec.ts index 89c6e844..9c967710 100644 --- a/apps/example-app-karma/src/app/issues/issue-491.spec.ts +++ b/apps/example-app-karma/src/app/issues/issue-491.spec.ts @@ -1,4 +1,4 @@ -import { Component, inject, ChangeDetectionStrategy } from '@angular/core'; +import { Component, inject } from '@angular/core'; import { Router } from '@angular/router'; import { render, screen } from '@testing-library/angular'; import userEvent from '@testing-library/user-event'; @@ -35,8 +35,6 @@ it('test click event with router.navigate', async () => { }); @Component({ - // eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection - changeDetection: ChangeDetectionStrategy.Eager, template: `

Login

@@ -52,8 +50,6 @@ class LoginComponent { } @Component({ - // eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection - changeDetection: ChangeDetectionStrategy.Eager, template: `

Logged In

`, }) class LoggedInComponent {} From ba7a7591d615d8f72ec2eba270d589da3cd13649 Mon Sep 17 00:00:00 2001 From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> Date: Mon, 27 Jul 2026 22:16:22 +0200 Subject: [PATCH 2/2] ci: fix test suite --- angular.json | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/angular.json b/angular.json index 0035220a..2e9f26cd 100644 --- a/angular.json +++ b/angular.json @@ -4,7 +4,7 @@ "cli": { "analytics": false, "cache": { - "enabled": true, + "enabled": false, "path": "./.cache/angular", "environment": "all" } @@ -32,9 +32,17 @@ }, "defaultConfiguration": "production" }, + "test-build-zoneless": { + "builder": "@angular/build:application", + "options": { + "polyfills": [], + "tsConfig": "projects/testing-library/tsconfig.spec.json" + } + }, "test": { "builder": "@angular/build:unit-test", "options": { + "buildTarget": "testing-library:test-build-zoneless", "setupFiles": ["projects/testing-library/test-setup.ts"] } },