Skip to content

support puppeteer-core with pptr-testing-library/extend #48

Description

@catdad

Current, the extend tries to require and modify the puppeteer module. However, I've found several use cases for using puppeteer-core to already-installed browsers and not require users to install an unnecessary version of chromium. One such example is when testing Electron apps.

It would be great if the extend helper could work with puppeteer-core as well. Currently, it hard-codes looking for puppeteer specifically. When it is not available, it errors. I did a quick check and it seems to work just fine with puppeteer-core. Perhaps it can be added as an extra libPrefix to check?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions