Commit 35454ba
authored
fix(cli): keep docker login output out of build logs (#4909)
On self-hosted and local builds, the registry login step's output landed
in the shared build log buffer, so every build log carried docker's
`WARNING! Your credentials are stored unencrypted` block. The warning is
misleading in our context: the credentials are per-project, short-lived
deploy tokens on an ephemeral builder machine.
Login output now goes to debug logging only; a single `Logged in to
<registry>` marker is pushed into the build log on success (so failure
logs still show auth ran), and a failed login still returns its full
output.1 parent 7fb8217 commit 35454ba
2 files changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
514 | 514 | | |
515 | 515 | | |
516 | 516 | | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
517 | 521 | | |
518 | | - | |
| 522 | + | |
519 | 523 | | |
520 | 524 | | |
521 | 525 | | |
522 | 526 | | |
523 | 527 | | |
524 | 528 | | |
525 | 529 | | |
526 | | - | |
| 530 | + | |
527 | 531 | | |
528 | 532 | | |
529 | 533 | | |
| 534 | + | |
| 535 | + | |
530 | 536 | | |
531 | 537 | | |
532 | 538 | | |
| |||
0 commit comments