Skip to content

Commit 61cba49

Browse files
committed
fix(webapp): always reload the smart-column sample when the source changes
The load effect skipped the fetch while a previous request was in flight and never retried, so quickly switching source could leave the sample and preview showing the old (or no) source. The effect only fires on open/sampleUrl change, so the guard was unnecessary; drop it.
1 parent 1e2b056 commit 61cba49

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

apps/webapp/app/components/runs/v3/AddSmartColumnDialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export function AddSmartColumnDialog({
9999
}, [organization.slug, project.slug, environment.slug, currentSearch, sampleFiltersKey, source]);
100100

101101
useEffect(() => {
102-
if (open && sample.state === "idle") {
102+
if (open) {
103103
sample.load(sampleUrl);
104104
}
105105
// eslint-disable-next-line react-hooks/exhaustive-deps

0 commit comments

Comments
 (0)