refactor(ntx-builder): extract transaction selection out of the account actor - #2583
Open
SantiagoPittella wants to merge 1 commit into
Open
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-ntx-extract-selection
branch
from
September 7, 2026 14:18
83603ed to
8f5a83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves selection, the failure-attribution helpers and the transaction arguments builder out of
AccountActorintoselection.rs, and movescandidate.rs,allowlist.rsandexecute.rsout ofactor/select_candidatebecomes a free function that reports the notes an account's allowlist rejects rather than writing them. The actor does that write, as it already does for every other note failure, so behaviour is unchanged.Changelog